Re: [PATCH] Change spinlock mutex to semaphor in ec.c

[Rich Townsend <rhdt-OBnUx95tOyn10jlvfTC4gA@public.gmane.org>]

Dmitry Torokhov wrote:
> On Thursday 03 February 2005 19:24, Rich Townsend wrote:
> 
>>Hi all --
>>
>>Attached is a patch against the 2.6.10 kernel, to convert the mutexing 
>>in the embdedded controller driver from a spinlock to a semaphore. The 
>>rationale behind this is to permit sleeping inside the acpi_ec_wait() 
>>polling routine.
>>
> 
> 
> Hi,
> 
> Last time such patch was proposed there were some concerns regarding
> possible interrupt storm, see the follwing thread:
> 
> http://marc.theaimsgroup.com/?l=acpi4linux&m=110055992814866&w=2
> 
> I have an alternative patch that tries to address these concerns,
> unfortunately I do not have a box with EC controller so it is
> completely untested.
> 

I've just tried your patch out on 2.6.11-rc3 (with acpi-dsdt-initrd and 
swsusp2 patches), and it causes a kernel oops when the EC is accessed at 
boot time. Unfortunately, the backtrace is too long to see where the 
oops arises; I'm sure there's a way of capturing the oops output, but I 
don't know it yet (suggestions welcome).

cheers,

Rich


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl