Re: [Suspend2-devel] Cause of Suspend2 resume failures on Toshiba laptops

Re: [Suspend2-devel] Cause of Suspend2 resume failures on Toshiba laptops

[Bernard Blackham]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

On Sat, Mar 05, 2005 at 10:44:58AM +0200, Dumitru Ciobarcianu wrote:
> ??n data de S??, 05-03-2005 la 01:50 +0800, Bernard Blackham a scris:
> > The attached patch more or less reverts the change in 2.6.9-rc1 that
> > began this all. If you have a Toshiba or other laptop that's
> > affected by this, I ask you to see if it helps your problems. (It
> > hacks around the problem rather than fixing it, but I'm not entirely
> > sure what functionality it disables).
> 
> You are on the right track , it does the trick, I did serveral
> suspend/resume cycles whitout problems. 
> 
> But (yes, it's a but :) it is functionally equivalent with using the
> other workaround (booting at resume with acpi=off) meaning that I lose
> all the acpi events (AC events, LID events, etc). The system records the
> event (if I do an "watch cat /proc/acpi/ac_adapter/ADP1/state" it shows
> the current state correctly) but acpid does not receive the event, and
> thus can not act accordingly :(  (Toshiba Satellite Pro 6100) 

Ahh, d'oh. Try this patch instead.

After more investigation, it seems that the issue is the GPE is
fired but not serviced because kacpid is frozen. This in itself
would be okay, however, the GPE isn't being disabled before the
method executes (despite there being code there to do so), and hence
fires continuously.

The attached patch makes kacpid NOFREEZE so the GPE does get
serviced (eventually), but probably still isn't the correct
solution. (A better solution being making sure the GPE gets disabled
in the first place ... still looking into this).

Bernard.

-- 
 Bernard Blackham <bernard at blackham dot com dot au>

[-- Attachment #2: toshiba-acpi-hack-2.diff --]
[-- Type: text/plain, Size: 376 bytes --]

--- linux-2.6.9-rc1/drivers/acpi/osl.c.orig	2005-03-05 17:44:13.000000000 +0800
+++ linux-2.6.9-rc1/drivers/acpi/osl.c	2005-03-05 17:44:16.000000000 +0800
@@ -87,7 +87,7 @@
 		return AE_NULL_ENTRY;
 	}
 #endif
-	kacpid_wq = create_singlethread_workqueue("kacpid", 0);
+	kacpid_wq = create_singlethread_workqueue("kacpid", PF_NOFREEZE);
 	BUG_ON(!kacpid_wq);
 
 	return AE_OK;

Re: [Suspend2-devel] Cause of Suspend2 resume failures on Toshiba laptops

[Dumitru Ciobarcianu]

În data de Sî, 05-03-2005 la 18:02 +0800, Bernard Blackham a scris:
> Ahh, d'oh. Try this patch instead.
> 
> After more investigation, it seems that the issue is the GPE is
> fired but not serviced because kacpid is frozen. This in itself
> would be okay, however, the GPE isn't being disabled before the
> method executes (despite there being code there to do so), and hence
> fires continuously.
> 
> The attached patch makes kacpid NOFREEZE so the GPE does get
> serviced (eventually), but probably still isn't the correct
> solution. (A better solution being making sure the GPE gets disabled
> in the first place ... still looking into this).


You got it this time!
Several successful suspend/resume cycles for me! And even the events are
working! :) 

Thanks, 

-- 
Cioby




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

Re: [Suspend2-devel] Cause of Suspend2 resume failures on Toshiba laptops

[mhf-tdrK/OAtAx2ELgA04lAiVw]

On Friday 04 March 2005 18:50, Bernard Blackham wrote:
> Hi all,
>
> As some of you will know, some laptops (notably almost
> all recent Toshibas) have issues resuming with Software
> Suspend 2, resulting in a hang during "Reading caches",
> or a stream of "Unable to queue event ..." messages. If
> you try and resume enough times, occasionally it will
> make it to the end of resuming and the system will be
> perfectly usable.
>
> The attached patch more or less reverts the change in
> 2.6.9-rc1 that began this all. If you have a Toshiba or
> other laptop that's affected by this, I ask you to see if
> it helps your problems. (It hacks around the problem
> rather than fixing it, but I'm not entirely sure what
> functionality it disables).
>
> To the ACPI developers:
>
> I'm not entirely sure what this is breaking. What uses
> these GPEs? It seems the hangs are caused by one of these
> GPEs firing upon resume (though I'm not sure why it
> causes a hang - perhaps related to the low memory
> conditions during a suspend/resume cycle?)
>
> The comment above the line I changed mentions that the
> GPE enable mask is updated, but not the HW GPE itself.
> Whereabouts are these later enabled?
>
> Are the HW GPE enable masks stored in memory that might
> be replaced when resuming, with their values from
> suspend? If so, could/should GPEs be disabled before
> suspending so that they aren't enabled at an unfortunate
> moment on resume?
>
> Apologies if none of the above makes much sense - it
> doesn't make all that much sense to me yet :)
>
> Thanks,
>
> Bernard.

Hi Bernard,

I am afraid the only effect of the patch on my Toshiba L2
is that the RTC stops working, thus the rtc.ko module can
not be inserted (no such device).

Resume still hangs with the GPE out of memory failure
after restoring the orig kernel.

If you need my DSDT, let me know.

Regards
Michael



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: Cause of Suspend2 resume failures on Toshiba laptops

[Dumitru Ciobarcianu]

În data de Du, 06-03-2005 la 17:46 +0100, mhf@berlios.de a scris:
> I am afraid the only effect of the patch on my Toshiba L2
> is that the RTC stops working, thus the rtc.ko module can
> not be inserted (no such device).

Please revert the first patch and use the second and the 3rd.
toshiba-acpi-hack-2.diff and toshiba-acpi-hack-3.diff. 
(if you already did that i'll just shut up and sit in a corner :)

-- 
Cioby