* s4bios: does anyone use it?
@ 2005-03-05 19:14 Pavel Machek
[not found] ` <20050305191405.GA1463-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2005-03-05 19:14 UTC (permalink / raw)
To: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
Hi!
Is there single user of s4bios? It used to work for me 4 notebooks
ago, but I never really used it. I think I'm the only person that ever
seen it working, but I could be wrong. Is there anyone using s4bios in
2.6.11?
If not, I guess we should remove that code from kernel. It is not
usefull, and it is likely broken.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050305191405.GA1463-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
@ 2005-03-05 21:08 ` Brice Goglin
[not found] ` <422A1FB6.3000504-vYW+cPY1g1pg9hUCZPvPmw@public.gmane.org>
2005-03-05 22:01 ` Stefan Seyfried
2005-03-07 17:08 ` Bruno Ducrot
1 sibling, 2 replies; 13+ messages in thread
From: Brice Goglin @ 2005-03-05 21:08 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
Pavel Machek a écrit :
> Hi!
>
> Is there single user of s4bios? It used to work for me 4 notebooks
> ago, but I never really used it. I think I'm the only person that ever
> seen it working, but I could be wrong. Is there anyone using s4bios in
> 2.6.11?
>
> If not, I guess we should remove that code from kernel. It is not
> usefull, and it is likely broken.
> Pavel
Hi Pavel,
I always suspend my Compaq Evo N6OOc to disk using "echo 4b > /proc/acpi/sleep".
I don't remember the reason why I originally did choose this one instead of S4.
I just checked that S4 and S4Bios work the same on 2.6.11-mm1 (even with my
PCMCIA wireless card connected, great!).
From what I remember, I didn't see any difference between S4 and S4Bios in
recent vanilla kernels.
By the way, it seems that Radeon makes suspend slower because it needs
to be blanked or something like that. Is there any way to avoid this ?
Regards
Brice
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <422A1FB6.3000504-vYW+cPY1g1pg9hUCZPvPmw@public.gmane.org>
@ 2005-03-05 21:17 ` Pavel Machek
2005-03-05 21:26 ` Brice Goglin
0 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2005-03-05 21:17 UTC (permalink / raw)
To: Brice Goglin; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
Hi!
> >Is there single user of s4bios? It used to work for me 4 notebooks
> >ago, but I never really used it. I think I'm the only person that ever
> >seen it working, but I could be wrong. Is there anyone using s4bios in
> >2.6.11?
> >
> >If not, I guess we should remove that code from kernel. It is not
> >usefull, and it is likely broken.
> > Pavel
> I always suspend my Compaq Evo N6OOc to disk using "echo 4b >
> /proc/acpi/sleep".
> I don't remember the reason why I originally did choose this one instead of
> S4.
> I just checked that S4 and S4Bios work the same on 2.6.11-mm1 (even with my
> PCMCIA wireless card connected, great!).
> From what I remember, I didn't see any difference between S4 and S4Bios in
> recent vanilla kernels.
Can you try cat /proc/acpi/sleep? If there's no difference between S4
and S4bios, than you are probably just using plain S4...
> By the way, it seems that Radeon makes suspend slower because it needs
> to be blanked or something like that. Is there any way to avoid this ?
Yes, but it will take quite long to do it properly. pm_message_t
framework needs to go in, first.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
2005-03-05 21:17 ` Pavel Machek
@ 2005-03-05 21:26 ` Brice Goglin
2005-03-05 21:32 ` Pavel Machek
0 siblings, 1 reply; 13+ messages in thread
From: Brice Goglin @ 2005-03-05 21:26 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, ACPI mailing list, seife, Len Brown
Pavel Machek a écrit :
> Can you try cat /proc/acpi/sleep? If there's no difference between S4
> and S4bios, than you are probably just using plain S4...
puligny:~% cat /proc/acpi/sleep
S0 S1 S3 S4 S4bios S5
Where am I suppose to see a difference between S4 and S4Bios here ?
From what I see in acpi_system_write_sleep in drivers/acpi/sleep/proc.c
4 uses software_suspend while 4b uses acpi_suspend(4)
(SOFTWARE_SUSPEND is set in my .config)
Is this code the right one ?
/* Check for S4 bios request */
if (!strcmp(str,"4b")) {
error = acpi_suspend(4);
goto Done;
}
state = simple_strtoul(str, NULL, 0);
#ifdef CONFIG_SOFTWARE_SUSPEND
if (state == 4) {
error = software_suspend();
goto Done;
}
#endif
error = acpi_suspend(state);
> Yes, but it will take quite long to do it properly. pm_message_t
> framework needs to go in, first.
Ok, great! I'll be happy to test it soon :)
Brice
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
2005-03-05 21:26 ` Brice Goglin
@ 2005-03-05 21:32 ` Pavel Machek
[not found] ` <20050305213236.GH1424-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2005-03-05 21:32 UTC (permalink / raw)
To: Brice Goglin; +Cc: kernel list, ACPI mailing list, seife, Len Brown
Hi!
> >Can you try cat /proc/acpi/sleep? If there's no difference between S4
> >and S4bios, than you are probably just using plain S4...
>
> puligny:~% cat /proc/acpi/sleep
> S0 S1 S3 S4 S4bios S5
>
> Where am I suppose to see a difference between S4 and S4Bios here ?
Hmm, your system says it supports s4bios. But if you can see
Writing data to swap (XXX pages)... XXX %
then you are definitely using swsusp. Strange.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050305213236.GH1424-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
@ 2005-03-05 21:45 ` Brice Goglin
0 siblings, 0 replies; 13+ messages in thread
From: Brice Goglin @ 2005-03-05 21:45 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
> Hmm, your system says it supports s4bios. But if you can see
>
> Writing data to swap (XXX pages)... XXX %
>
> then you are definitely using swsusp. Strange.
That's what I see.
Thanks,
Brice
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
2005-03-05 21:08 ` Brice Goglin
[not found] ` <422A1FB6.3000504-vYW+cPY1g1pg9hUCZPvPmw@public.gmane.org>
@ 2005-03-05 22:01 ` Stefan Seyfried
1 sibling, 0 replies; 13+ messages in thread
From: Stefan Seyfried @ 2005-03-05 22:01 UTC (permalink / raw)
To: Brice Goglin; +Cc: Pavel Machek, kernel list, ACPI mailing list, Len Brown
Brice Goglin wrote:
> From what I remember, I didn't see any difference between S4 and S4Bios in
> recent vanilla kernels.
I have seen exactly the same thing and concluded that S4bios is broken.
Since it is tricky to set up (you usually need a special hibernation
partition or a special file in a FAT partition) and probably slow as
hell (at least if it has anything to do with the APM BIOS suspend to
disk routines, and i assume it does), i'd shed no tears if it would go
away ;-)
--
Stefan Seyfried, QA / R&D Team Mobile Devices, SUSE LINUX Nürnberg.
"Any ideas, John?"
"Well, surrounding them's out."
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050305191405.GA1463-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-05 21:08 ` Brice Goglin
@ 2005-03-07 17:08 ` Bruno Ducrot
[not found] ` <20050307170852.GB31985-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
1 sibling, 1 reply; 13+ messages in thread
From: Bruno Ducrot @ 2005-03-07 17:08 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
On Sat, Mar 05, 2005 at 08:14:05PM +0100, Pavel Machek wrote:
> Hi!
>
> Is there single user of s4bios? It used to work for me 4 notebooks
> ago, but I never really used it.
I don't have anymore my toshiba laptop where S4 bios was first
implemented.
> I think I'm the only person that ever
> seen it working, but I could be wrong.
You are indeed wrong.
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050307170852.GB31985-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
@ 2005-03-07 20:44 ` Pavel Machek
[not found] ` <20050307204401.GA15212-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2005-03-07 20:44 UTC (permalink / raw)
To: Bruno Ducrot; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
Hi!
> >
> > Is there single user of s4bios? It used to work for me 4 notebooks
> > ago, but I never really used it.
>
> I don't have anymore my toshiba laptop where S4 bios was first
> implemented.
>
> > I think I'm the only person that ever
> > seen it working, but I could be wrong.
>
> You are indeed wrong.
Okay, so we had 2 users in past but have 0 users now? :-).
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: s4bios: does anyone use it?
@ 2005-03-08 5:24 Li, Shaohua
2005-03-08 9:18 ` [ACPI] " Pavel Machek
0 siblings, 1 reply; 13+ messages in thread
From: Li, Shaohua @ 2005-03-08 5:24 UTC (permalink / raw)
To: Pavel Machek, Bruno Ducrot
Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Brown, Len
Hi,
>> >
>> > Is there single user of s4bios? It used to work for me 4 notebooks
>> > ago, but I never really used it.
>>
>> I don't have anymore my toshiba laptop where S4 bios was first
>> implemented.
>>
>> > I think I'm the only person that ever
>> > seen it working, but I could be wrong.
>>
>> You are indeed wrong.
>
>Okay, so we had 2 users in past but have 0 users now? :-).
I wonder how could anyone use S4BIOS in 2.6.11. S4 and S4b all came into
'enter_state'. and in acpi_sleep_init:
if (i == ACPI_STATE_S4) {
if (acpi_gbl_FACS->S4bios_f) {
sleep_states[i] = 1;
printk(" S4bios");
acpi_pm_ops.pm_disk_mode =
PM_DISK_FIRMWARE;
}
if (sleep_states[i])
acpi_pm_ops.pm_disk_mode =
PM_DISK_PLATFORM;
}
That means we actually can't set PM_DISK_FIRMWARE (always set
PM_DISK_PLATFORM). Is this intended? If no, .pm_disk_mode should be a
mask.
Thanks,
Shaohua
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [ACPI] s4bios: does anyone use it?
2005-03-08 5:24 s4bios: does anyone use it? Li, Shaohua
@ 2005-03-08 9:18 ` Pavel Machek
[not found] ` <20050308091856.GB16436-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2005-03-08 9:18 UTC (permalink / raw)
To: Li, Shaohua, Andrew Morton
Cc: Bruno Ducrot, kernel list, ACPI mailing list, seife, Brown, Len
Hi!
> >Okay, so we had 2 users in past but have 0 users now? :-).
> I wonder how could anyone use S4BIOS in 2.6.11. S4 and S4b all came into
> 'enter_state'. and in acpi_sleep_init:
>
> if (i == ACPI_STATE_S4) {
> if (acpi_gbl_FACS->S4bios_f) {
> sleep_states[i] = 1;
> printk(" S4bios");
> acpi_pm_ops.pm_disk_mode =
> PM_DISK_FIRMWARE;
> }
> if (sleep_states[i])
> acpi_pm_ops.pm_disk_mode =
> PM_DISK_PLATFORM;
> }
> That means we actually can't set PM_DISK_FIRMWARE (always set
> PM_DISK_PLATFORM). Is this intended? If no, .pm_disk_mode should be a
> mask.
pm_disk_mode is settable using /sys/power/disk, no? Anyway, what about
this, then?
--- clean/Documentation/feature-removal-schedule.txt 2005-01-22 21:24:50.000000000 +0100
+++ linux/Documentation/feature-removal-schedule.txt 2005-03-08 10:18:05.000000000 +0100
@@ -15,3 +15,8 @@
against the LSB, and can be replaced by using udev.
Who: Greg Kroah-Hartman <greg@kroah.com>
+What: ACPI S4bios support
+When: May 2005
+Why: Noone uses it, and it probably does not work, anyway. swsusp is
+ faster, more reliable, and people are actually using it.
+Who: Pavel Machek <pavel@suse.cz>
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050307204401.GA15212-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
@ 2005-03-08 9:20 ` Bruno Ducrot
0 siblings, 0 replies; 13+ messages in thread
From: Bruno Ducrot @ 2005-03-08 9:20 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, ACPI mailing list, seife-l3A5Bk7waGM, Len Brown
On Mon, Mar 07, 2005 at 09:44:01PM +0100, Pavel Machek wrote:
> Okay, so we had 2 users in past but have 0 users now? :-).
I don't know. I remember having at least one positive feedback one or
two years ago, but this was for an old 2.4 kernel (does that count ?),
maybe if that guy switched to 2.6 there will be then one user now using
S4bios under 2.6 who knows :)
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: s4bios: does anyone use it?
[not found] ` <20050308091856.GB16436-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
@ 2005-03-08 9:42 ` Stefan Seyfried
0 siblings, 0 replies; 13+ messages in thread
From: Stefan Seyfried @ 2005-03-08 9:42 UTC (permalink / raw)
To: Pavel Machek
Cc: Li, Shaohua, Andrew Morton, Bruno Ducrot, kernel list,
ACPI mailing list, Brown, Len
Pavel Machek wrote:
> Hi!
>
>> >Okay, so we had 2 users in past but have 0 users now? :-).
>> I wonder how could anyone use S4BIOS in 2.6.11. S4 and S4b all came into
>> 'enter_state'. and in acpi_sleep_init:
>>
>> if (i == ACPI_STATE_S4) {
>> if (acpi_gbl_FACS->S4bios_f) {
>> sleep_states[i] = 1;
>> printk(" S4bios");
>> acpi_pm_ops.pm_disk_mode =
>> PM_DISK_FIRMWARE;
>> }
>> if (sleep_states[i])
>> acpi_pm_ops.pm_disk_mode =
>> PM_DISK_PLATFORM;
>> }
>> That means we actually can't set PM_DISK_FIRMWARE (always set
>> PM_DISK_PLATFORM). Is this intended? If no, .pm_disk_mode should be a
>> mask.
>
> pm_disk_mode is settable using /sys/power/disk, no?
No, it isn't. That was my original point: you can write "firmware" into
it, but it has no effect. This probably was a side-effect of the "make
firmware mode not default" patch from a year ago.
But the real question is: what is firmware mode good for today? Is there
a single machine where firmware mode once worked, but swsusp does not
work today?
> Anyway, what about this, then?
>
> --- clean/Documentation/feature-removal-schedule.txt 2005-01-22 21:24:50.000000000 +0100
> +++ linux/Documentation/feature-removal-schedule.txt 2005-03-08 10:18:05.000000000 +0100
Fine with me. I think it cannot work since ~one year (when we changed
the default from "firmware if available" to "shutdown always", the code
piece cited above) and nobody complained until now, so it won't be
missed IMO.
--
Stefan Seyfried, QA / R&D Team Mobile Devices, SUSE LINUX Nürnberg.
"Any ideas, John?"
"Well, surrounding them's out."
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2005-03-08 9:42 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-08 5:24 s4bios: does anyone use it? Li, Shaohua
2005-03-08 9:18 ` [ACPI] " Pavel Machek
[not found] ` <20050308091856.GB16436-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-08 9:42 ` Stefan Seyfried
-- strict thread matches above, loose matches on Subject: below --
2005-03-05 19:14 Pavel Machek
[not found] ` <20050305191405.GA1463-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-05 21:08 ` Brice Goglin
[not found] ` <422A1FB6.3000504-vYW+cPY1g1pg9hUCZPvPmw@public.gmane.org>
2005-03-05 21:17 ` Pavel Machek
2005-03-05 21:26 ` Brice Goglin
2005-03-05 21:32 ` Pavel Machek
[not found] ` <20050305213236.GH1424-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-05 21:45 ` Brice Goglin
2005-03-05 22:01 ` Stefan Seyfried
2005-03-07 17:08 ` Bruno Ducrot
[not found] ` <20050307170852.GB31985-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2005-03-07 20:44 ` Pavel Machek
[not found] ` <20050307204401.GA15212-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-08 9:20 ` Bruno Ducrot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox