public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* RE: ACPI key events handling
@ 2005-03-10  8:55 Li, Shaohua
       [not found] ` <16A54BF5D6E14E4D916CE26C9AD30575015B5180-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Li, Shaohua @ 2005-03-10  8:55 UTC (permalink / raw)
  To: Karol Kozimor, Paulo Vitor Magacho da Silva
  Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

How about below patch? It fixes current ec address space handler bugs.

Thanks,
Shaohua


diff -puN drivers/acpi/ec.c~ec_addr_space_handler drivers/acpi/ec.c
--- 2.5/drivers/acpi/ec.c~ec_addr_space_handler	2005-03-08
09:19:05.228720200 +0800
+++ 2.5-root/drivers/acpi/ec.c	2005-03-08 10:35:54.130060696 +0800
@@ -441,7 +441,7 @@ acpi_ec_space_handler (
 {
 	int			result = 0;
 	struct acpi_ec		*ec = NULL;
-	u32			temp = 0;
+	u32			temp = *value;
 	acpi_integer		f_v = 0;
 	int 			i = 0;
 
@@ -462,10 +462,9 @@ next_byte:
 	switch (function) {
 	case ACPI_READ:
 		result = acpi_ec_read(ec, (u8) address, &temp);
-		*value = (acpi_integer) temp;
 		break;
 	case ACPI_WRITE:
-		result = acpi_ec_write(ec, (u8) address, (u8) *value);
+		result = acpi_ec_write(ec, (u8) address, (u8) temp);
 		break;
 	default:
 		result = -EINVAL;
@@ -474,19 +473,18 @@ next_byte:
 	}
 
 	bit_width -= 8;
-	if(bit_width){
-
+	if (bit_width){
 		if(function == ACPI_READ)
-			f_v |= (acpi_integer) (*value) << 8*i;
+			f_v |= temp << 8 * i;
 		if(function == ACPI_WRITE)
-			(*value) >>=8; 
+			temp >>= 8;
 		i++;
+		(u8)address ++;
 		goto next_byte;
 	}
 
-
 	if(function == ACPI_READ){
-		f_v |= (acpi_integer) (*value) << 8*i;
+		f_v |= temp << 8 * i;
 		*value = f_v;
 	}
 
@@ -505,8 +503,6 @@ out:
 	default:
 		return_VALUE(AE_OK);
 	}
-	
-
 }
 
>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Karol Kozimor
>Sent: Thursday, March 10, 2005 4:50 PM
>To: Paulo Vitor Magacho da Silva
>Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Re: [ACPI] ACPI key events handling
>
>Thus wrote Paulo Vitor Magacho da Silva:
>>   I have an ACER 163lmi laptop and I am having problem with some of
the
>Fn
>> keys. I don't know if this is related to ACPI or not.
>>   The problem is that when I press some the Fn keys, like the sleep
>button
>> (Fn+F4), and I look at the /proc/acpi/event, sometimes the key works
>> sometimes it doesn't. I did also the check of the Fn keys with the
acerhk
>> driver. My laptop has the mail, internet, p1, p2, wireless, buttons.
And
>> when I press those buttons, sometimes I get the correct reading from
the
>> acerhk driver, sometimes when I press the mail buttons it reads back
the
>> wireless, or any other key, and sometimes it just reads garbage.
>
>Sounds like another instance of
>http://bugzilla.kernel.org/show_bug.cgi?id=4124
>
>Best regards,
>
>--
>Karol 'sziwan' Kozimor
>sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org
>
>
>-------------------------------------------------------
>SF email is sponsored by - The IT Product Guide
>Read honest & candid reviews on hundreds of IT Products from real
users.
>Discover which products truly live up to the hype. Start reading now.
>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>_______________________________________________
>Acpi-devel mailing list
>Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-03-18 18:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-10  8:55 ACPI key events handling Li, Shaohua
     [not found] ` <16A54BF5D6E14E4D916CE26C9AD30575015B5180-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-03-10 16:28   ` Thomas Renninger
     [not found]     ` <42307593.8040501-l3A5Bk7waGM@public.gmane.org>
2005-03-11  0:48       ` Li Shaohua
2005-03-11  2:23       ` [PATCH] ACPI EC address space handler - " Li Shaohua
     [not found]         ` <1110507818.3692.4.camel-U5EdaLXB8smDugQYiPIPGdh3ngVCH38I@public.gmane.org>
2005-03-18 18:40           ` Thomas Renninger
2005-03-10 22:44   ` Paulo Vitor Magacho da Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox