Re: Re: What's up with the Embedded Controller driver? [was Re: [ACPI] patched sms-cm acpi/ec.c to 2.6.11.5]

Rich Townsend
2005-03-29T15:09:21Z

Yu, Luming wrote:
> I'm sorry, what is sbs-cm packag?
> Please make sure sbs-cm package is using ec_read/write functions defined in ec.c

The sbs-cm package is a patchset for DSDT, that implements the Control
Method battery API for systems that use Smart Battery technology; see here:

http://sourceforge.net/projects/sbs-linux/

The ec_read/write functions are NOT used in sbs-cm, because all accesses
to the Embedded Controller are done from within the AML virtual machine,
using the EC OperationRegion. So in fact sbs-cm accesses the EC via the
address space handler in ec.c, NOT the read/write routines.

Note that many of the people reporting problems with ec.c (including
myself, Pedro and Francois) are using this package. So it may be that
the problem with ec.c is in the address space handler.

cheers,

Rich

>
> Thanks
> Luming
>
>
>>-----Original Message-----
>>From: Rich Townsend [mailto:rhdt-OBnUx95tOyn10jlvfTC4gA@public.gmane.org]
>>Sent: 2005年3月29日 22:50
>>To: Yu, Luming
>>Cc: François Valenduc; ACPI devel
>>Subject: Re: [ACPI] Re: What's up with the Embedded Controller
>>driver? [was Re: [ACPI] patched sms-cm acpi/ec.c to 2.6.11.5]
>>
>>Yu, Luming wrote:
>>
>>>You modified DSDT just remove some AML methods that related to EC.
>>>That means it just delete the problem.
>>>I believe if you think this is the regression, just because
>>
>>the changeset
>>
>>http://linux-acpi.bkbits.net:8080/26-latest-test/diffs/include/
>>acpi/acconfig.h@1.55?nav=index.html|src/.|src/include|src/inclu
>
> de/acpi|hist/include/acpi/acconfig.h
>
>>>make _those AML methods just run.
>>>So, this is NOT a regression problem.
>>>
>>>Please cat /proc/interrupts to me before accessing EC and
>>
>>after accessing EC.(using burst mode EC patch)
>>
>>Hi Yuming --
>>
>>I'm using your ec patch, plus a DSDT modified using my sbs-cm package
>>(which accesses the Smart Battery system through the EC address space
>>handler). Here's what happens to the interrupts when I access
>>the battery:
>>
>>rhdt@sto ~ $ cat /proc/interrupts
>> CPU0
>> 0: 127116981 XT-PIC timer
>> 1: 213426 XT-PIC i8042
>> 2: 0 XT-PIC cascade
>> 6: 171382 XT-PIC i915@pci:0000:00:02.0, uhci_hcd,
>>uhci_hcd, uhci_hcd, eth1
>> 8: 8 XT-PIC rtc
>> 9: 3305062 XT-PIC acpi
>>10: 1965890 XT-PIC Intel 82801DB-ICH4, yenta, ehci_hcd,
>>ipw2200
>>12: 4335843 XT-PIC i8042
>>14: 466033 XT-PIC ide0
>>15: 28 XT-PIC ide1
>>NMI: 0
>>LOC: 0
>>ERR: 0
>>rhdt@sto ~ $ cat /proc/acpi/battery/BAT0/state
>>present: yes
>>capacity state: ok
>>charging state: charged
>>present rate: 0 mA
>>remaining capacity: 4081 mAh
>>present voltage: 16699 mV
>>rhdt@sto ~ $ cat /proc/interrupts
>> CPU0
>> 0: 127131974 XT-PIC timer
>> 1: 213488 XT-PIC i8042
>> 2: 0 XT-PIC cascade
>> 6: 171462 XT-PIC i915@pci:0000:00:02.0, uhci_hcd,
>>uhci_hcd, uhci_hcd, eth1
>> 8: 8 XT-PIC rtc
>> 9: 3305297 XT-PIC acpi
>>10: 1966133 XT-PIC Intel 82801DB-ICH4, yenta, ehci_hcd,
>>ipw2200
>>12: 4335843 XT-PIC i8042
>>14: 466065 XT-PIC ide0
>>15: 28 XT-PIC ide1
>>NMI: 0
>>LOC: 0
>>ERR: 0
>>
>>Note that the battery access took over 5 seconds! And note, of course,
>>the big jump in the acpi interrupt count.
>>
>>cheers,
>>
>>Rich
>>

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.