Re: [RFC/PATCH 3/3] ACPI based I/O APIC hot-plug

Greg KH
2005-04-22T15:15:17Z

On Fri, Apr 22, 2005 at 08:58:01AM -0600, Bjorn Helgaas wrote:
> On Fri, 2005-04-22 at 15:38 +0900, Kenji Kaneshige wrote:
> > Bjorn Helgaas wrote:
> > >
> > >>+ if ((dev->class >> 8) != PCI_CLASS_SYSTEM_PIC)
> > >>+ continue;
> > >>+ if ((dev->class & 0xff) == 0x10 || (dev->class & 0xff) == 0x20)
> > >
> > >
> > > What are 0x10 and 0x20? Looks like they should be #defines in
> > > include/linux/pci_ids.h.
> >
> > 0x10 and 0x20 are programing interfaces for I/O APIC and I/O xAPIC
> > respectively. #define for these values looks good. But I don't know
> > if I can put new #defines into pci_ids.h and how to name them because
> > I could not find the header file (including pci_ids.h) that #defines
> > the values for programming interfaces. So I want to add the comments
> > to explain these values (0x10, 0x20) instead of adding new #defines into
> > pci_ids.h for now.
>
> I think your patch should just add the values to pci_ids.h. If
> somebody doesn't like that, he or she will complain and you can fall
> back to just using 0x10 and 0x20. But I suspect it will be fine.

Yes, I have no problem with that.

thanks,

greg k-h

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.