Re: [ACPI] [RFC/PATCH 3/3] ACPI based I/O APIC hot-plug

Kenji Kaneshige
2005-04-25T09:16:12Z

Bjorn Helgaas wrote:
> On Fri, 2005-04-22 at 15:38 +0900, Kenji Kaneshige wrote:
>
>>Bjorn Helgaas wrote:
>>
>>>>+ if ((dev->class >> 8) != PCI_CLASS_SYSTEM_PIC)
>>>>+ continue;
>>>>+ if ((dev->class & 0xff) == 0x10 || (dev->class & 0xff) == 0x20)
>>>
>>>
>>>What are 0x10 and 0x20? Looks like they should be #defines in
>>>include/linux/pci_ids.h.
>>
>>0x10 and 0x20 are programing interfaces for I/O APIC and I/O xAPIC
>>respectively. #define for these values looks good. But I don't know
>>if I can put new #defines into pci_ids.h and how to name them because
>>I could not find the header file (including pci_ids.h) that #defines
>>the values for programming interfaces. So I want to add the comments
>>to explain these values (0x10, 0x20) instead of adding new #defines into
>>pci_ids.h for now.
>
>
> I think your patch should just add the values to pci_ids.h. If
> somebody doesn't like that, he or she will complain and you can fall
> back to just using 0x10 and 0x20. But I suspect it will be fine.
>
>

Thank you for advice. I'll try to add new #defines for I/O APIC
and I/O xAPIC to pci_ids.h.

Thanks,
Kenji Kaneshige