public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH] enable acpi_os_allocate() to allocate larger memory
Date: Mon, 23 May 2005 20:28:17 +0900	[thread overview]
Message-ID: <4291BE51.1090004@jp.fujitsu.com> (raw)

Hi,

I encountered the problem that I could not read /proc/acpi/dsdt on my
machine. It turned out that acpi_os_allocate() was failed to allocate
buffer. The DSDT on my machine was too large for acpi_os_allocate() to
allocate the buffer.

Current acpi_os_allocate() interface is implemented by using kmalloc()
whose maximum allocation size is limited. So acpi_os_allocate() would
fail if larger size than maximum allocation size of kmalloc was
specified. I think this restriction should be removed.

The following patch enables acpi_os_allocate() to allocate larger
memory.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>


---

 linux-2.6.12-rc4-kanesige/drivers/acpi/osl.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff -puN drivers/acpi/osl.c~fix_acpi_os_allocate drivers/acpi/osl.c
--- linux-2.6.12-rc4/drivers/acpi/osl.c~fix_acpi_os_allocate	2005-05-23 20:09:34.000000000 +0900
+++ linux-2.6.12-rc4-kanesige/drivers/acpi/osl.c	2005-05-23 20:09:34.000000000 +0900
@@ -37,6 +37,7 @@
 #include <linux/delay.h>
 #include <linux/workqueue.h>
 #include <linux/nmi.h>
+#include <linux/vmalloc.h>
 #include <acpi/acpi.h>
 #include <asm/io.h>
 #include <acpi/acpi_bus.h>
@@ -145,13 +146,20 @@ acpi_os_vprintf(const char *fmt, va_list
 void *
 acpi_os_allocate(acpi_size size)
 {
-	return kmalloc(size, GFP_KERNEL);
+	void *ptr = kmalloc(size, GFP_KERNEL);
+	if (!ptr)
+		ptr = vmalloc(size);
+	return ptr;
 }
 
 void
 acpi_os_free(void *ptr)
 {
-	kfree(ptr);
+	if (VMALLOC_START <= (unsigned long)ptr &&
+	    (unsigned long)ptr < VMALLOC_END)
+		vfree(ptr);
+	else
+		kfree(ptr);
 }
 EXPORT_SYMBOL(acpi_os_free);
 

_


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click

             reply	other threads:[~2005-05-23 11:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 11:28 Kenji Kaneshige [this message]
     [not found] ` <4291BE51.1090004-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-05-23 13:42   ` [PATCH] enable acpi_os_allocate() to allocate larger memory Alan Cox
     [not found]     ` <1116855778.5744.47.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-05-24  2:27       ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4291BE51.1090004@jp.fujitsu.com \
    --to=kaneshige.kenji-+cum20s59erqfuhtdcdx3a@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox