public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] enable acpi_os_allocate() to allocate larger	memory
Date: Tue, 24 May 2005 11:27:55 +0900	[thread overview]
Message-ID: <4292912B.9020709@jp.fujitsu.com> (raw)
In-Reply-To: <1116855778.5744.47.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

Alan Cox wrote:
> On Llu, 2005-05-23 at 12:28, Kenji Kaneshige wrote:
> 
>>-	return kmalloc(size, GFP_KERNEL);
>>+	void *ptr = kmalloc(size, GFP_KERNEL);
>>+	if (!ptr)
> 
> 
> 
> This looks reasonable. Do you think it would be better to use
> GFP_KERNEL|__GFP_NORETRY|__GFP_NOWARN ?

Yes, this makes sense.
I'll update the patch and post it again.

Thanks,
Kenji Kaneshige


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click

      parent reply	other threads:[~2005-05-24  2:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 11:28 [PATCH] enable acpi_os_allocate() to allocate larger memory Kenji Kaneshige
     [not found] ` <4291BE51.1090004-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-05-23 13:42   ` Alan Cox
     [not found]     ` <1116855778.5744.47.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-05-24  2:27       ` Kenji Kaneshige [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4292912B.9020709@jp.fujitsu.com \
    --to=kaneshige.kenji-+cum20s59erqfuhtdcdx3a@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox