From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Kaneshige Subject: Re: [PATCH] enable acpi_os_allocate() to allocate larger memory Date: Tue, 24 May 2005 11:27:55 +0900 Message-ID: <4292912B.9020709@jp.fujitsu.com> References: <4291BE51.1090004@jp.fujitsu.com> <1116855778.5744.47.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1116855778.5744.47.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Alan Cox Cc: Len Brown , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Alan Cox wrote: > On Llu, 2005-05-23 at 12:28, Kenji Kaneshige wrote: > >>- return kmalloc(size, GFP_KERNEL); >>+ void *ptr = kmalloc(size, GFP_KERNEL); >>+ if (!ptr) > > > > This looks reasonable. Do you think it would be better to use > GFP_KERNEL|__GFP_NORETRY|__GFP_NOWARN ? Yes, this makes sense. I'll update the patch and post it again. Thanks, Kenji Kaneshige ------------------------------------------------------- This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes! http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click