From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Date: Wed, 15 Jun 2005 13:31:37 -0400 Message-ID: <42B065F9.7070902@pobox.com> References: <20050615052916.GA23394@kroah.com> <20050615053031.GB23394@kroah.com> <20050615053120.GC23394@kroah.com> <20050615094833.GB11898@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20050615094833.GB11898-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Andi Kleen Cc: Greg KH , len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-pci-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org Andi Kleen wrote: > On Tue, Jun 14, 2005 at 10:31:20PM -0700, Greg KH wrote: > >>Now that we have access to the whole MCFG table, let's properly use it >>for all pci device accesses (as that's what it is there for, some boxes >>don't put all the busses into one entry.) >> >>If, for some reason, the table is incorrect, we fallback to the "old >>style" of mmconfig accesses, namely, we just assume the first entry in >>the table is the one for us, and blindly use it. > > > I think it would be better to set different bus->ops at probe > time, not walk the table at runtime. Makes sense to me... Jeff ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click