From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Kaneshige Subject: Re: Re: ACPI hot-plug notification help needed Date: Wed, 03 Aug 2005 13:37:20 +0900 Message-ID: <42F04A00.8060804@jp.fujitsu.com> References: <200507251735.23394.bjorn.helgaas@hp.com> <200508011620.02609.bjorn.helgaas@hp.com> <20050801170345.A16268@unix-os.sc.intel.com> <200508021641.26007.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200508021641.26007.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bjorn Helgaas Cc: Keshavamurthy Anil S , naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi, > ACPI_FUNCTION_TRACE("acpi_bus_check_device"); > > + /* > + * If no device exists for this namespace node, a DEVICE_CHECK > + * notification means the device has appeared. > + */ > + if (acpi_bus_get_device(handle, &device)) { > + result = acpi_bus_add_device(handle); > + if (status_changed && result == 0) > + *status_changed = 1; > + return_VALUE(result); > + } > + > if (!device) I think acpi_bus_check_device() might be called even though device's status was not changed. So I think we should check device's current status (_STA value) before doing this. Thanks, Kenji Kaneshige ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click