From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthieu castet Subject: Re: Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend] Date: Thu, 04 Aug 2005 18:08:16 +0200 Message-ID: <42F23D70.5010201@free.fr> References: <200508020955.54844.bjorn.helgaas@hp.com> <200508031541.53777.bjorn.helgaas@hp.com> <42F20C5B.3020506@free.fr> <200508040957.55485.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200508040957.55485.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bjorn Helgaas Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Shaohua Li , Adam Belay , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org Bjorn Helgaas wrote: > On Thursday 04 August 2005 6:38 am, matthieu castet wrote: > >>Bjorn Helgaas wrote: >> >>>On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: >>> >>>>Bjorn Helgaas wrote: >>>> >>>>> drivers/char/hpet.c >>>>> This probably should be converted to PNP. I'll >>>>> look into doing this. >>>> >>>>IIRC, I am not sure that the pnp layer was able to pass the 64 bits >>>>memory adress for hpet correctly. But it would be nice if it works. >>> >>>You're right, this was broken. But I've been pushing a PNPACPI >>>patch to fix this. >>> >> >>Yes but is ACPI_RSTYPE_ADDRESS64 possible on 32 bit machine ? > > > I can't think of a case where that would make sense, but I don't > actually know the answer. > > >>In this case your patch won't work as res->mem_resource[i].start and >>res->mem_resource[i].end are unsigned long, and 64 bit value won't fit. > > > True. But fixing that would be pretty far-reaching (changing struct > resource), so I'm not worried until it is shown to be a problem. > Ok, may be you could add a BUG_ON(sizeof(long)==4) for ACPI_RSTYPE_ADDRESS64. Matthieu ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf