From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Kaneshige Subject: Re: [PATCH 2.6.13-rc4 1/2] fix possible null pointer access - acpi_pci_irq_enable Date: Mon, 08 Aug 2005 13:24:09 +0900 Message-ID: <42F6DE69.5090101@jp.fujitsu.com> References: <42ED97C2.7060409@jp.fujitsu.com> <42ED9830.7060808@jp.fujitsu.com> <20050803113637.GB4038@elf.ucw.cz> <42F2C20F.4050807@jp.fujitsu.com> <20050805071918.GG1780@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20050805071918.GG1780-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Pavel Machek , Andrew Morton Cc: Len Brown , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi, >>>Should people be passing NULLs here, anyway? Is not the right fix to >>>remove the check, and remove the (!dev) check, too, and just fix the >>>callers? People are going to fix the oops, but noone is going to see >>>that ACPI_DEBUG_PRINT... >> >>As you said, I think people should not pass NULLs here, and we should >>fix the caller. But I think it is not bad to check (!dev) and (!dev->bus) >>in these functions instead of panic. How about using WARN_ON here to >>notify people of badness? > > > No, just read l-k archives. Just dereference it. It wil oops in a nice > way, and developer *will* see and fix it. OK. I'll make a new patch that removes the check. Andrew, could you please drop the following two patches from -mm tree? o fix-possible-null-pointer-access-acpi_pci_irq_enable.patch o fix-possible-null-pointer-access-acpi_pci_irq_disable.patch Thanks, Kenji Kaneshige ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf