Re: [PATCH 2.6.13-rc4 1/2] fix possible null pointer access - acpi_pci_irq_enable

Pavel Machek
2005-08-05T07:19:18Z

Hi!

> >Should people be passing NULLs here, anyway? Is not the right fix to
> >remove the check, and remove the (!dev) check, too, and just fix the
> >callers? People are going to fix the oops, but noone is going to see
> >that ACPI_DEBUG_PRINT...
>
> As you said, I think people should not pass NULLs here, and we should
> fix the caller. But I think it is not bad to check (!dev) and (!dev->bus)
> in these functions instead of panic. How about using WARN_ON here to
> notify people of badness?

No, just read l-k archives. Just dereference it. It wil oops in a nice
way, and developer *will* see and fix it.

Pavel
--
if you have sharp zaurus hardware you don't need... you know my address