Re: [PATCH 2.6.13-rc4 1/2] fix possible null pointer access - acpi_pci_irq_enable

Andrew Morton
2005-08-08T05:07:36Z

Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org> wrote:
>
> Hi,
>
> >>>Should people be passing NULLs here, anyway? Is not the right fix to
> >>>remove the check, and remove the (!dev) check, too, and just fix the
> >>>callers? People are going to fix the oops, but noone is going to see
> >>>that ACPI_DEBUG_PRINT...
> >>
> >>As you said, I think people should not pass NULLs here, and we should
> >>fix the caller. But I think it is not bad to check (!dev) and (!dev->bus)
> >>in these functions instead of panic. How about using WARN_ON here to
> >>notify people of badness?
> >
> >
> > No, just read l-k archives. Just dereference it. It wil oops in a nice
> > way, and developer *will* see and fix it.
>
> OK. I'll make a new patch that removes the check.
>
> Andrew, could you please drop the following two patches from -mm tree?
>
> o fix-possible-null-pointer-access-acpi_pci_irq_enable.patch
> o fix-possible-null-pointer-access-acpi_pci_irq_disable.patch
>

They're not in -mm any more. Either they've been merged into Len's tree or
I accidentally dropped them, assuming they were in Len's tree due to them
throwing rejects.