public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
To: "Moore, Robert" <robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: ML ACPI-devel
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	dhurst-mn4gwa5WIIQysxA8WJXlww@public.gmane.org
Subject: Re: Latest acpica
Date: Thu, 08 Sep 2005 19:21:33 +0200	[thread overview]
Message-ID: <4320731D.5070706@suse.de> (raw)
In-Reply-To: <971FCB6690CD0E4898387DBF7552B90E02A69A30-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>

Moore, Robert wrote:
> The compilation errors of this form:
> 
> 
> dsdt_org.dsl   149:                     , AddressRangeMemory,
> TypeStatic)
> 
> Error    1094 -                Missing ResourceSource string (required)
> ^
> are caused by specifying a ResourceIndex with no corresponding
> ResourceString.  We recently tightened up the iASL compiler to detect
> this condition and flag it as an error, as per the following text from
> the ACPI specification, 3.0:
> 
> DWord Address Space Descriptor 
> 
> Byte 46
>  Resource Source Index
>  (Optional) Only present if Resource Source (below) is present. This
> field gives an index to the specific resource descriptor that this
> device consumes from in the current resource template for the device
> object pointed to in Resource Source.
>  
> A relevant ASL source statement is below.
> 
>                 DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, Cacheable, ReadWrite,
> 
>                     0x00000000, // Address Space Granularity
> 
>                     0x000A0000, // Address Range Minimum
> 
>                     0x000BFFFF, // Address Range Maximum
> 
>                     0x00000000, // Address Translation Offset
> 
>                     0x00020000, 0x00,,
> 
>                     , AddressRangeMemory, TypeStatic)
> 
> It is the 0x00 that is causing the issue, it should not be there.
> 
Yes those 0x00 are there.
> 
> However, we recently changed the disassembler to detect this condition
> within existing AML code and to emit ASL code that is compilable.  In
> this case, the statement comes out of the disassembler like this:
> 
>  
> 
>                 DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, Cacheable, ReadWrite,
> 
>                     0x00000000, // Address Space Granularity
> 
>                     0x000A0000, // Address Range Minimum
> 
>                     0x000BFFFF, // Address Range Maximum
> 
>                     0x00000000, // Address Translation Offset
> 
>                     0x00020000,,,
> 
>                     , AddressRangeMemory, TypeStatic)
> 
> Which is compilable code.

Ok, thanks.
Then the DSDT posted lately in (subject) "Compal EFL30 ACPI"
Cannot be compiled with newer ACPICA versions because it has been disassembled
with an older iasl...

> 
> This change to the disassembler appeared in ACPICA version 20050617:
> 
> Enhanced the disassembler to emit compilable code in the face of
> incorrect AML resource descriptors. If the optional ResourceSourceIndex
> is present, but the ResourceSource is not, do not emit the
> ResourceSourceIndex in the disassembly. Otherwise, the resulting code
> cannot be compiled without errors.
> 
> 
      Thomas


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

  parent reply	other threads:[~2005-09-08 17:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-08 16:50 Latest acpica Moore, Robert
     [not found] ` <971FCB6690CD0E4898387DBF7552B90E02A69A30-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-09-08 17:21   ` Thomas Renninger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-18 20:31 Moore, Robert
     [not found] ` <971FCB6690CD0E4898387DBF7552B90E031CC3AC-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-10-19  3:38   ` Andrew Grover
2005-10-13 17:15 Moore, Robert
2005-09-08 19:35 Moore, Robert
     [not found] ` <971FCB6690CD0E4898387DBF7552B90E02AA4005-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-10-12 17:37   ` Andrew Grover
     [not found]     ` <c0a09e5c0510121037l3be5774bj3ec5e0d50449c69f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-10-12 21:56       ` Mattia Dongili
     [not found]         ` <20051012215628.GG3658-MEqNC12sBsHxa7XIdbXXog@public.gmane.org>
2005-10-13  0:00           ` Andrew Grover
     [not found]             ` <c0a09e5c0510121700saa456d6kff2b05b858bc1251-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-10-13  7:56               ` Mattia Dongili
2005-10-18 20:14       ` Mattia Dongili
     [not found]         ` <20051018201407.GB3945-MEqNC12sBsHxa7XIdbXXog@public.gmane.org>
2005-10-18 20:23           ` Andrew Grover
2005-09-08 19:23 Moore, Robert
     [not found] ` <971FCB6690CD0E4898387DBF7552B90E02AA3FD6-sBd4vmA9Se5Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2005-09-08 19:30   ` Matthew Wilcox
2005-09-08 10:15 Thomas Renninger
     [not found] ` <43200F57.9040000-l3A5Bk7waGM@public.gmane.org>
2005-09-08 16:59   ` Frank
     [not found]     ` <200509081859.57340.hugelmopf-S0/GAf8tV78@public.gmane.org>
2005-09-08 17:15       ` Thomas Renninger
2005-09-08 18:38       ` Matthew Wilcox
     [not found]         ` <20050908183832.GA4770-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2005-09-08 19:49           ` Frank
     [not found]             ` <200509082149.57483.hugelmopf-S0/GAf8tV78@public.gmane.org>
2005-09-09  8:10               ` Sebastian Henschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4320731D.5070706@suse.de \
    --to=trenn-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=dhurst-mn4gwa5WIIQysxA8WJXlww@public.gmane.org \
    --cc=robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox