RE: Latest acpica

RE: Latest acpica

[Moore, Robert]

The compilation errors of this form:


dsdt_org.dsl   149:                     , AddressRangeMemory,
TypeStatic)

Error    1094 -                Missing ResourceSource string (required)
^

 
are caused by specifying a ResourceIndex with no corresponding
ResourceString.  We recently tightened up the iASL compiler to detect
this condition and flag it as an error, as per the following text from
the ACPI specification, 3.0:


DWord Address Space Descriptor 

Byte 46
 Resource Source Index
 (Optional) Only present if Resource Source (below) is present. This
field gives an index to the specific resource descriptor that this
device consumes from in the current resource template for the device
object pointed to in Resource Source.
 


A relevant ASL source statement is below.

 

                DWordMemory (ResourceProducer, PosDecode, MinFixed,
MaxFixed, Cacheable, ReadWrite,

                    0x00000000, // Address Space Granularity

                    0x000A0000, // Address Range Minimum

                    0x000BFFFF, // Address Range Maximum

                    0x00000000, // Address Translation Offset

                    0x00020000, 0x00,,

                    , AddressRangeMemory, TypeStatic)

 

It is the 0x00 that is causing the issue, it should not be there.

 

However, we recently changed the disassembler to detect this condition
within existing AML code and to emit ASL code that is compilable.  In
this case, the statement comes out of the disassembler like this:

 

                DWordMemory (ResourceProducer, PosDecode, MinFixed,
MaxFixed, Cacheable, ReadWrite,

                    0x00000000, // Address Space Granularity

                    0x000A0000, // Address Range Minimum

                    0x000BFFFF, // Address Range Maximum

                    0x00000000, // Address Translation Offset

                    0x00020000,,,

                    , AddressRangeMemory, TypeStatic)

 

Which is compilable code.

 

This change to the disassembler appeared in ACPICA version 20050617:

 

Enhanced the disassembler to emit compilable code in the face of
incorrect AML resource descriptors. If the optional ResourceSourceIndex
is present, but the ResourceSource is not, do not emit the
ResourceSourceIndex in the disassembly. Otherwise, the resulting code
cannot be compiled without errors.


> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Thomas Renninger
> Sent: Thursday, September 08, 2005 3:16 AM
> To: ML ACPI-devel
> Subject: [ACPI] Latest acpica
> 
> acpica-unix-20050902.tar.gz
> is now available under:
> http://developer.intel.com/technology/iapc/acpi/downloads.htm
> Thanks.
> 
> There is one concern:
> This has been discussed some weeks ago.
> The compiler throws dozens of errors on some DSDTs:
> 
> DSDT.dsl   777:                     , AddressRangeMemory, TypeStatic)
> Error    1084 -            Missing ResourceSource string (required) ^
> 
> I cannot find the mail now, but IIRC Len said this was added to
identify
> how many DSDTs violate specs (is it optional or not?) and should be
> removed
> again later.
> 
> The patch attached lowers the error to a warning, so that you get a
> compiled
> DSDT as output.
> Not sure, maybe the error/warning case should be reverted totally?
> 
> 
>       Thomas


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Thomas Renninger]

Moore, Robert wrote:
> The compilation errors of this form:
> 
> 
> dsdt_org.dsl   149:                     , AddressRangeMemory,
> TypeStatic)
> 
> Error    1094 -                Missing ResourceSource string (required)
> ^
> are caused by specifying a ResourceIndex with no corresponding
> ResourceString.  We recently tightened up the iASL compiler to detect
> this condition and flag it as an error, as per the following text from
> the ACPI specification, 3.0:
> 
> DWord Address Space Descriptor 
> 
> Byte 46
>  Resource Source Index
>  (Optional) Only present if Resource Source (below) is present. This
> field gives an index to the specific resource descriptor that this
> device consumes from in the current resource template for the device
> object pointed to in Resource Source.
>  
> A relevant ASL source statement is below.
> 
>                 DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, Cacheable, ReadWrite,
> 
>                     0x00000000, // Address Space Granularity
> 
>                     0x000A0000, // Address Range Minimum
> 
>                     0x000BFFFF, // Address Range Maximum
> 
>                     0x00000000, // Address Translation Offset
> 
>                     0x00020000, 0x00,,
> 
>                     , AddressRangeMemory, TypeStatic)
> 
> It is the 0x00 that is causing the issue, it should not be there.
> 
Yes those 0x00 are there.
> 
> However, we recently changed the disassembler to detect this condition
> within existing AML code and to emit ASL code that is compilable.  In
> this case, the statement comes out of the disassembler like this:
> 
>  
> 
>                 DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, Cacheable, ReadWrite,
> 
>                     0x00000000, // Address Space Granularity
> 
>                     0x000A0000, // Address Range Minimum
> 
>                     0x000BFFFF, // Address Range Maximum
> 
>                     0x00000000, // Address Translation Offset
> 
>                     0x00020000,,,
> 
>                     , AddressRangeMemory, TypeStatic)
> 
> Which is compilable code.

Ok, thanks.
Then the DSDT posted lately in (subject) "Compal EFL30 ACPI"
Cannot be compiled with newer ACPICA versions because it has been disassembled
with an older iasl...

> 
> This change to the disassembler appeared in ACPICA version 20050617:
> 
> Enhanced the disassembler to emit compilable code in the face of
> incorrect AML resource descriptors. If the optional ResourceSourceIndex
> is present, but the ResourceSource is not, do not emit the
> ResourceSourceIndex in the disassembly. Otherwise, the resulting code
> cannot be compiled without errors.
> 
> 
      Thomas


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

RE: Latest acpica

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 2464 bytes --]

It is my understanding that only flex-old will work to build iASL,
because the new flex is not compatible with lex in some important areas.

 

I don't know any more than this.

Bob

 

 

-----Original Message-----
From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
[mailto:acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Andrew
Grover
Sent: Tuesday, October 18, 2005 1:24 PM
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Moore, Robert
Subject: Re: [ACPI] Latest acpica

 

Yeah I wish I knew enough flex to fix it, too. How hard can it be? :) --
Andy

On 10/18/05, Mattia Dongili <malattia-k2GhghHVRtY@public.gmane.org
<mailto:malattia-k2GhghHVRtY@public.gmane.org> > wrote:

On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> I am using GNU flex 2.5.31. I was able to get it to build (on x86_64
even)
> with the attached patch. I have also attached the warnings, in case
those
> are of interest.

I tried building my DSDT with a patched iasl built with the latest flex 
available in debian (2.5.31) but it seems the -l flag is doing more bad
than good. I get a bunch of (meaningless) errors:

DSDT.dsl    34:     Scope (\_GPE)
Error    1094 -                ^ syntax error, unexpected
PARSEOP_NAMESEG, expecting ')'

DSDT.dsl    38:             Notify (\_SB.PCI0.USB1, 0x02)
Error    1094 -                        ^ syntax error, unexpected
PARSEOP_NAMESEG, expecting ','

DSDT.dsl    38:             Notify (\_SB.PCI0.USB1, 0x02)
Error    1094 -                         ^ Invalid character (0x2E),
expecting ASL keyword or name

DSDT.dsl    43:             Notify (\_SB.PCI0.USB2, 0x02)
Error    1094 -                        ^ syntax error, unexpected
PARSEOP_NAMESEG, expecting ','
...
...
ASL Input:  DSDT.dsl - 3597 lines, 124899 bytes, 20 keywords
Compilation complete. 15 Errors, 0 Warnings, 0 Remarks, 2 Optimizations

while building with flex-old I only get: 

DSDT.dsl  1347:                     Field (ECR, AnyAcc, Lock, Preserve)
Error    1073 -                              ^ Host Operation Region
requires ByteAcc access

ASL Input:  DSDT.dsl - 3896 lines, 131852 bytes, 1959 keywords
Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 388 Optimizations

So I'll probably simply build-depend on flex-old by now and I'll try to
learn 
more of flex soon :)

--
mattia
:wq!

 


[-- Attachment #2: Type: text/html, Size: 6564 bytes --]

Re: Latest acpica

[Andrew Grover]

[-- Attachment #1: Type: text/plain, Size: 2956 bytes --]

Debian may be OK using flex-old but distros less concerned with backwards
compatibility, such as Red Hat Fedora, no longer ship it. "flex -l" got it
compiling but produced compilation errors (see Mattia's email), so I'd think
it probably just needs a few more nudges to start working.

Once it compiles, then we can package it and get it added to the Fedora
Extras repo. Then FC users can type "yum install iasl" and have it
automatically installed and ready to go, which I think would make getting
started with iasl a lot easier.

Regards -- Andy

On 10/18/05, Moore, Robert <robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
>  It is my understanding that only flex-old will work to build iASL,
> because the new flex is not compatible with lex in some important areas.
>
> I don't know any more than this.
>
> Bob
> ----Original Message-----
>
> *From:* acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:
> acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] *On Behalf Of *Andrew Grover
> *Sent:* Tuesday, October 18, 2005 1:24 PM
> *To:* acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Moore, Robert
> *Subject:* Re: [ACPI] Latest acpica
>
>  Yeah I wish I knew enough flex to fix it, too. How hard can it be? :) --
> Andy
>
> On 10/18/05, *Mattia Dongili* <malattia-k2GhghHVRtY@public.gmane.org > wrote:
>
> On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> > I am using GNU flex 2.5.31. I was able to get it to build (on x86_64
> even)
> > with the attached patch. I have also attached the warnings, in case
> those
> > are of interest.
>
> I tried building my DSDT with a patched iasl built with the latest flex
> available in debian (2.5.31) but it seems the -l flag is doing more bad
> than good. I get a bunch of (meaningless) errors:
>
> DSDT.dsl 34: Scope (\_GPE)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ')'
>
> DSDT.dsl 38: Notify (\_SB.PCI0.USB1, 0x02)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','
>
> DSDT.dsl 38: Notify (\_SB.PCI0.USB1, 0x02)
> Error 1094 - ^ Invalid character (0x2E), expecting ASL keyword or name
>
> DSDT.dsl 43: Notify (\_SB.PCI0.USB2, 0x02)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','
> ...
> ...
> ASL Input: DSDT.dsl - 3597 lines, 124899 bytes, 20 keywords
> Compilation complete. 15 Errors, 0 Warnings, 0 Remarks, 2 Optimizations
>
> while building with flex-old I only get:
>
> DSDT.dsl 1347: Field (ECR, AnyAcc, Lock, Preserve)
> Error 1073 - ^ Host Operation Region requires ByteAcc access
>
> ASL Input: DSDT.dsl - 3896 lines, 131852 bytes, 1959 keywords
> Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 388 Optimizations
>
> So I'll probably simply build-depend on flex-old by now and I'll try to
> learn
> more of flex soon :)
>
> --
> mattia
> :wq!
>
>

[-- Attachment #2: Type: text/html, Size: 6966 bytes --]

RE: Latest acpica

[Moore, Robert]

I am the developer and maintainer for ACPICA and the iASL compiler. If
there are any changes required, send them to me and I will integrate
them.

Bob


> -----Original Message-----
> From: Mattia Dongili [mailto:malattia-k2GhghHVRtY@public.gmane.org]
> Sent: Thursday, October 13, 2005 12:57 AM
> To: Andrew Grover
> Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Moore, Robert
> Subject: Re: [ACPI] Latest acpica
> 
> On Thu, October 13, 2005 2:00 am, Andrew Grover said:
> [...nice insight on acpica-unix...]
> >
> > Regards -- Andy (no longer working on acpi, I just want a debian
iasl
> pkg
> > ;-)
> 
> Thanks a lot, you'll have your package soon :)
> 
> --
> mattia
> :wq!
> 



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

RE: Latest acpica

[Moore, Robert]

And this seems like a fairly relevant quote as well:

>Flex no longer conforms to the POSIX lex behaviour



> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Matthew Wilcox
> Sent: Thursday, September 08, 2005 12:31 PM
> To: Moore, Robert
> Cc: Frank; acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [ACPI] Latest acpica
> 
> On Thu, Sep 08, 2005 at 12:23:50PM -0700, Moore, Robert wrote:
> > Tell me what needs to change in order to make it compatible.
> 
> I've never looked into it in any detail.  From the Debian description:
> 
>  The behaviour of Flex has undergone a major change since version
>  2.5.4a; Flex scanners are now reenterant, you may have multiple
>  scanners in the same program with differing sets of defaults, and
>  they play nicer with modern C and C++ compilers. The Flip side is
>  that Flex no longer conforms to the POSIX lex behaviour, and the
>  scanners require conforming implementations when flex is used in ANSI
>  C mode. The package flex-old provides the older behaviour.
> 
> The GNU web page has some more detail:
> 
>
http://www.gnu.org/software/flex/manual/html_chapter/flex_20.html#SEC20
> 
> and there's a bug showing exactly this problem being encountered here:
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=191942
> 
> The important bit is probably the quote:
> 
> 	The relevant change in the new flex is that it's no longer valid
> 	to call unput() from the section after %%, only in actions or
> 	in the %{ ... %} section.
> 
> HTH.
> 
> 
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing
& QA
> Security * Process Improvement & Measurement *
http://www.sqe.com/bsce5sf
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Andrew Grover]

[-- Attachment #1.1: Type: text/plain, Size: 3272 bytes --]

I am using GNU flex 2.5.31. I was able to get it to build (on x86_64 even)
with the attached patch. I have also attached the warnings, in case those
are of interest.

(Any Debian people want to package iasl?)

Regards -- Andy

On 9/8/05, Moore, Robert <robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> And this seems like a fairly relevant quote as well:
>
> >Flex no longer conforms to the POSIX lex behaviour
>
>
>
> > -----Original Message-----
> > From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> > admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Matthew Wilcox
> > Sent: Thursday, September 08, 2005 12:31 PM
> > To: Moore, Robert
> > Cc: Frank; acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > Subject: Re: [ACPI] Latest acpica
> >
> > On Thu, Sep 08, 2005 at 12:23:50PM -0700, Moore, Robert wrote:
> > > Tell me what needs to change in order to make it compatible.
> >
> > I've never looked into it in any detail. From the Debian description:
> >
> > The behaviour of Flex has undergone a major change since version
> > 2.5.4a; Flex scanners are now reenterant, you may have multiple
> > scanners in the same program with differing sets of defaults, and
> > they play nicer with modern C and C++ compilers. The Flip side is
> > that Flex no longer conforms to the POSIX lex behaviour, and the
> > scanners require conforming implementations when flex is used in ANSI
> > C mode. The package flex-old provides the older behaviour.
> >
> > The GNU web page has some more detail:
> >
> >
> http://www.gnu.org/software/flex/manual/html_chapter/flex_20.html#SEC20
> >
> > and there's a bug showing exactly this problem being encountered here:
> >
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=191942
> >
> > The important bit is probably the quote:
> >
> > The relevant change in the new flex is that it's no longer valid
> > to call unput() from the section after %%, only in actions or
> > in the %{ ... %} section.
> >
> > HTH.
> >
> >
> > -------------------------------------------------------
> > SF.Net email is Sponsored by the Better Software Conference & EXPO
> > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> > Practices
> > Agile & Plan-Driven Development * Managing Projects & Teams * Testing
> & QA
> > Security * Process Improvement & Measurement *
> http://www.sqe.com/bsce5sf
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
>

[-- Attachment #1.2: Type: text/html, Size: 4771 bytes --]

[-- Attachment #2: iasl.diff --]
[-- Type: text/x-patch, Size: 983 bytes --]

diff -Naur acpica-unix-20050930-orig/compiler/aslglobal.h acpica-unix-20050930/compiler/aslglobal.h
--- acpica-unix-20050930-orig/compiler/aslglobal.h	2005-09-30 15:50:18.000000000 -0700
+++ acpica-unix-20050930/compiler/aslglobal.h	2005-10-12 10:26:33.000000000 -0700
@@ -143,7 +143,6 @@
 extern FILE                         *AslCompilerin;
 extern int                          AslCompilerdebug;
 extern const ASL_MAPPING_ENTRY      AslKeywordMapping[];
-extern char                         *AslCompilertext;
 extern char                         hex[];
 
 #define ASL_LINE_BUFFER_SIZE        512
diff -Naur acpica-unix-20050930-orig/compiler/Makefile acpica-unix-20050930/compiler/Makefile
--- acpica-unix-20050930-orig/compiler/Makefile	2005-09-30 15:50:19.000000000 -0700
+++ acpica-unix-20050930/compiler/Makefile	2005-10-12 10:09:39.000000000 -0700
@@ -85,7 +85,7 @@
 #YACC=	yacc
 YACC=	bison
 YFLAGS+= -v -d
-LEX=	flex
+LEX=	flex -l
 LFLAGS+= -i
 
 #.if $(YACC) == "bison"





[-- Attachment #3: err.log --]
[-- Type: text/x-log, Size: 2250 bytes --]

conflicts: 61 shift/reduce, 18 reduce/reduce
aslcompiler.y:915.7-81: warning: rule never reduced because of conflicts: TermArg: Type2IntegerOpcode
aslcompiler.y:916.7-81: warning: rule never reduced because of conflicts: TermArg: Type2StringOpcode
aslcompiler.y:917.7-81: warning: rule never reduced because of conflicts: TermArg: Type2BufferOpcode
aslcompiler.y:918.7-81: warning: rule never reduced because of conflicts: TermArg: Type2BufferOrStringOpcode
aslcompiler.y:964.7-82: warning: rule never reduced because of conflicts: OptionalParameterTypePackage: ','
aslcompiler.y:983.37-48: warning: rule never reduced because of conflicts: ParameterTypesPackageList: /* empty */
aslcompiler.y:984.7-46: warning: rule never reduced because of conflicts: ParameterTypesPackageList: ObjectTypeKeyword
aslcompiler.y:988.7-989.69: warning: rule never reduced because of conflicts: ParameterTypesPackageList: ParameterTypesPackage ',' ParameterTypesPackage
aslcompiler.y:994.7-82: warning: rule never reduced because of conflicts: OptionalParameterTypesPackage: ','
aslcompiler.y:1585.7-38: warning: rule never reduced because of conflicts: CaseTermList: CaseTerm
aslcompiler.y:1594.7-38: warning: rule never reduced because of conflicts: DefaultTermList: CaseTerm
aslcompiler.y:3077.37-48: warning: rule never reduced because of conflicts: OptionalResourceType: /* empty */
aslcompilerlex.c: In function `AslCompilerlex':
aslcompilerlex.c:2125: warning: label `find_rule' defined but not used
aslcompiler.l: At top level:
aslcompilerlex.c:4395: warning: 'yy_flex_strlen' defined but not used
asllisting.c: In function `LsAmlListingWalk':
asllisting.c:322: warning: cast from pointer to integer of different size
aslopt.c: In function `OptBuildShortestPath':
aslopt.c:439: warning: int format, different type arg (arg 7)
aslopt.c:439: warning: int format, different type arg (arg 8)
aslopt.c: In function `OptOptimizeNamePath':
aslopt.c:755: warning: int format, different type arg (arg 8)
aslopt.c:755: warning: int format, different type arg (arg 10)
aslopt.c:815: warning: int format, different type arg (arg 7)
../osunixxf.c: In function `AcpiOsGetRootPointer':
../osunixxf.c:188: warning: implicit declaration of function `AeLocalGetRootPointer'

Re: Latest acpica

[Mattia Dongili]

On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> I am using GNU flex 2.5.31. I was able to get it to build (on x86_64 even)
> with the attached patch. I have also attached the warnings, in case those
> are of interest.
> 
> (Any Debian people want to package iasl?)

I submitted the ITP, but I'm wondering which licence it is supposed to
be. On the Intel site the Linux package is said to be GPLed but
downloaded files (and the www licence agreement) don't report that as
this is the Unix version.

I also gave a shot to the acpisrc tool that moves everything into a
GPLv2 + CodeStyle clean source tree but the generated source doesn't
build.

Could anybody clarify it?

Thanks a lot
-- 
mattia
:wq!


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: Latest acpica

[Andrew Grover]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

When you cut through the legalese, the ACPICA license, which is what the
acpica-unix release is released under, is BSD-style. (Proof of this is that
FreeBSD uses it ;-) So there shouldn't be any licensing issues.

As for acpisrc, it is a very specialized tool that works in conjunction with
some shellscripts to Linuxize the code. I don't think it is worth packaging,
since only the guy who ports CA releases to Linux (i.e. Len Brown) really
uses it... but it's there for the curious. (a nit: it doesn't attach GPLv2,
it attaches dual BSD/GPLv2.)

Regards -- Andy (no longer working on acpi, I just want a debian iasl pkg
;-)

On 10/12/05, Mattia Dongili <malattia-k2GhghHVRtY@public.gmane.org> wrote:
>
> On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> > I am using GNU flex 2.5.31. I was able to get it to build (on x86_64
> even)
> > with the attached patch. I have also attached the warnings, in case
> those
> > are of interest.
> >
> > (Any Debian people want to package iasl?)
>
> I submitted the ITP, but I'm wondering which licence it is supposed to
> be. On the Intel site the Linux package is said to be GPLed but
> downloaded files (and the www licence agreement) don't report that as
> this is the Unix version.
>
> I also gave a shot to the acpisrc tool that moves everything into a
> GPLv2 + CodeStyle clean source tree but the generated source doesn't
> build.
>
> Could anybody clarify it?
>
> Thanks a lot
> --
> mattia
> :wq!
>

[-- Attachment #2: Type: text/html, Size: 1827 bytes --]

Re: Latest acpica

[Mattia Dongili]

On Thu, October 13, 2005 2:00 am, Andrew Grover said:
[...nice insight on acpica-unix...]
>
> Regards -- Andy (no longer working on acpi, I just want a debian iasl pkg
> ;-)

Thanks a lot, you'll have your package soon :)

-- 
mattia
:wq!




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: Latest acpica

[Mattia Dongili]

On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> I am using GNU flex 2.5.31. I was able to get it to build (on x86_64 even)
> with the attached patch. I have also attached the warnings, in case those
> are of interest.

I tried building my DSDT with a patched iasl built with the latest flex
available in debian (2.5.31) but it seems the -l flag is doing more bad
than good. I get a bunch of (meaningless) errors:

DSDT.dsl    34:     Scope (\_GPE)
Error    1094 -                ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ')'

DSDT.dsl    38:             Notify (\_SB.PCI0.USB1, 0x02)
Error    1094 -                        ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','

DSDT.dsl    38:             Notify (\_SB.PCI0.USB1, 0x02)
Error    1094 -                         ^ Invalid character (0x2E), expecting ASL keyword or name

DSDT.dsl    43:             Notify (\_SB.PCI0.USB2, 0x02)
Error    1094 -                        ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','
...
...
ASL Input:  DSDT.dsl - 3597 lines, 124899 bytes, 20 keywords
Compilation complete. 15 Errors, 0 Warnings, 0 Remarks, 2 Optimizations

while building with flex-old I only get:

DSDT.dsl  1347:                     Field (ECR, AnyAcc, Lock, Preserve)
Error    1073 -                              ^ Host Operation Region requires ByteAcc access

ASL Input:  DSDT.dsl - 3896 lines, 131852 bytes, 1959 keywords
Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 388 Optimizations

So I'll probably simply build-depend on flex-old by now and I'll try to learn
more of flex soon :)

-- 
mattia
:wq!


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: Latest acpica

[Andrew Grover]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Yeah I wish I knew enough flex to fix it, too. How hard can it be? :) --
Andy

On 10/18/05, Mattia Dongili <malattia-k2GhghHVRtY@public.gmane.org> wrote:
>
> On Wed, Oct 12, 2005 at 10:37:59AM -0700, Andrew Grover wrote:
> > I am using GNU flex 2.5.31. I was able to get it to build (on x86_64
> even)
> > with the attached patch. I have also attached the warnings, in case
> those
> > are of interest.
>
> I tried building my DSDT with a patched iasl built with the latest flex
> available in debian (2.5.31) but it seems the -l flag is doing more bad
> than good. I get a bunch of (meaningless) errors:
>
> DSDT.dsl 34: Scope (\_GPE)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ')'
>
> DSDT.dsl 38: Notify (\_SB.PCI0.USB1, 0x02)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','
>
> DSDT.dsl 38: Notify (\_SB.PCI0.USB1, 0x02)
> Error 1094 - ^ Invalid character (0x2E), expecting ASL keyword or name
>
> DSDT.dsl 43: Notify (\_SB.PCI0.USB2, 0x02)
> Error 1094 - ^ syntax error, unexpected PARSEOP_NAMESEG, expecting ','
> ...
> ...
> ASL Input: DSDT.dsl - 3597 lines, 124899 bytes, 20 keywords
> Compilation complete. 15 Errors, 0 Warnings, 0 Remarks, 2 Optimizations
>
> while building with flex-old I only get:
>
> DSDT.dsl 1347: Field (ECR, AnyAcc, Lock, Preserve)
> Error 1073 - ^ Host Operation Region requires ByteAcc access
>
> ASL Input: DSDT.dsl - 3896 lines, 131852 bytes, 1959 keywords
> Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 388 Optimizations
>
> So I'll probably simply build-depend on flex-old by now and I'll try to
> learn
> more of flex soon :)
>
> --
> mattia
> :wq!
>

[-- Attachment #2: Type: text/html, Size: 3323 bytes --]

RE: Latest acpica

[Moore, Robert]

Tell me what needs to change in order to make it compatible.
Bob

> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Matthew Wilcox
> Sent: Thursday, September 08, 2005 11:39 AM
> To: Frank
> Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [ACPI] Latest acpica
> 
> On Thu, Sep 08, 2005 at 06:59:57PM +0200, Frank wrote:
> > I am having problems compiling this compiler on AMD64.
> > It throws the following error message:
> >
> > [compiler] $ make
> > cc -Wall -O2 -Wstrict-prototypes -D_LINUX -DACPI_ASL_COMPILER -
> I../include
> > -c -o aslcompilerlex.o aslcompilerlex.c
> > aslcompiler.l: In function `comment':
> > aslcompiler.l:847: error: `yytext_ptr' undeclared (first use in this
> function)
> > aslcompiler.l:847: error: (Each undeclared identifier is reported
only
> once
> > aslcompiler.l:847: error: for each function it appears in.)
> > make: *** [aslcompilerlex.o] Error 1
> 
> Are you on Debian?  I think this means you need to install flex-old.
> 
> Do Intel have any plans to make this compatible with versions of GNU
flex
> after 2.5.4a?
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing
& QA
> Security * Process Improvement & Measurement *
http://www.sqe.com/bsce5sf
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Matthew Wilcox]

On Thu, Sep 08, 2005 at 12:23:50PM -0700, Moore, Robert wrote:
> Tell me what needs to change in order to make it compatible.

I've never looked into it in any detail.  From the Debian description:

 The behaviour of Flex has undergone a major change since version
 2.5.4a; Flex scanners are now reenterant, you may have multiple
 scanners in the same program with differing sets of defaults, and
 they play nicer with modern C and C++ compilers. The Flip side is
 that Flex no longer conforms to the POSIX lex behaviour, and the
 scanners require conforming implementations when flex is used in ANSI
 C mode. The package flex-old provides the older behaviour.

The GNU web page has some more detail:

http://www.gnu.org/software/flex/manual/html_chapter/flex_20.html#SEC20

and there's a bug showing exactly this problem being encountered here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=191942

The important bit is probably the quote:

	The relevant change in the new flex is that it's no longer valid
	to call unput() from the section after %%, only in actions or
	in the %{ ... %} section.

HTH.


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Latest acpica

[Thomas Renninger]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

acpica-unix-20050902.tar.gz
is now available under:
http://developer.intel.com/technology/iapc/acpi/downloads.htm
Thanks.

There is one concern:
This has been discussed some weeks ago.
The compiler throws dozens of errors on some DSDTs:

DSDT.dsl   777:                     , AddressRangeMemory, TypeStatic)
Error    1084 -            Missing ResourceSource string (required) ^

I cannot find the mail now, but IIRC Len said this was added to identify
how many DSDTs violate specs (is it optional or not?) and should be removed
again later.

The patch attached lowers the error to a warning, so that you get a compiled
DSDT as output.
Not sure, maybe the error/warning case should be reverted totally?


      Thomas

[-- Attachment #2: resource_string_warning.diff --]
[-- Type: text/x-patch, Size: 3108 bytes --]

--- compiler/aslrestype2.c.orig	2005-09-08 12:05:25.000000000 +0200
+++ compiler/aslrestype2.c	2005-09-08 12:08:10.000000000 +0200
@@ -331,7 +331,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -545,7 +545,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -757,7 +757,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -1430,7 +1430,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -1639,7 +1639,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -1846,7 +1846,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -2034,7 +2034,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -2234,7 +2234,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -2431,7 +2431,7 @@
              */
             else if (ResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;
@@ -2592,7 +2592,7 @@
              */
             else if (HasResSourceIndex)
             {
-                AslError (ASL_ERROR, ASL_MSG_RESOURCE_SOURCE,
+                AslError (ASL_WARNING, ASL_MSG_RESOURCE_SOURCE,
                     InitializerOp, NULL);
             }
             break;

Re: Latest acpica

[Frank]

I am having problems compiling this compiler on AMD64.
It throws the following error message:

[compiler] $ make
cc -Wall -O2 -Wstrict-prototypes -D_LINUX -DACPI_ASL_COMPILER -I../include    
-c -o aslcompilerlex.o aslcompilerlex.c
aslcompiler.l: In function `comment':
aslcompiler.l:847: error: `yytext_ptr' undeclared (first use in this function)
aslcompiler.l:847: error: (Each undeclared identifier is reported only once
aslcompiler.l:847: error: for each function it appears in.)
make: *** [aslcompilerlex.o] Error 1

This is not a new error though, I have had it for at least the 20050309 and 
20050513 release. It happens with GCC 3.3, 3.4 and 4.0... anybody an idea? It 
can't be happening only to me, can it?

Thanks,
Frank

> acpica-unix-20050902.tar.gz
> is now available under:
> http://developer.intel.com/technology/iapc/acpi/downloads.htm
> Thanks.


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Thomas Renninger]

Frank wrote:
> I am having problems compiling this compiler on AMD64.
> It throws the following error message:
> 
> [compiler] $ make
> cc -Wall -O2 -Wstrict-prototypes -D_LINUX -DACPI_ASL_COMPILER -I../include    
> -c -o aslcompilerlex.o aslcompilerlex.c
> aslcompiler.l: In function `comment':
> aslcompiler.l:847: error: `yytext_ptr' undeclared (first use in this function)
> aslcompiler.l:847: error: (Each undeclared identifier is reported only once
> aslcompiler.l:847: error: for each function it appears in.)
> make: *** [aslcompilerlex.o] Error 1
> 
> This is not a new error though, I have had it for at least the 20050309 and 
> 20050513 release. It happens with GCC 3.3, 3.4 and 4.0... anybody an idea? It 
> can't be happening only to me, can it?
I had no problems compiling the code on x86_64.
Maybe you have to update lex/yacc packages?
> 
> Thanks,
> Frank

     Thomas


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Matthew Wilcox]

On Thu, Sep 08, 2005 at 06:59:57PM +0200, Frank wrote:
> I am having problems compiling this compiler on AMD64.
> It throws the following error message:
> 
> [compiler] $ make
> cc -Wall -O2 -Wstrict-prototypes -D_LINUX -DACPI_ASL_COMPILER -I../include    
> -c -o aslcompilerlex.o aslcompilerlex.c
> aslcompiler.l: In function `comment':
> aslcompiler.l:847: error: `yytext_ptr' undeclared (first use in this function)
> aslcompiler.l:847: error: (Each undeclared identifier is reported only once
> aslcompiler.l:847: error: for each function it appears in.)
> make: *** [aslcompilerlex.o] Error 1

Are you on Debian?  I think this means you need to install flex-old.

Do Intel have any plans to make this compatible with versions of GNU flex
after 2.5.4a?



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Frank]

Thanks a lot, this solved it. Maybe a note on the download page might be 
helpful?

Am Donnerstag, 8. September 2005 20:38 schrieb Matthew Wilcox:
> On Thu, Sep 08, 2005 at 06:59:57PM +0200, Frank wrote:
> > I am having problems compiling this compiler on AMD64.
> > It throws the following error message:
>
> Are you on Debian?  I think this means you need to install flex-old.



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: Latest acpica

[Sebastian Henschel]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

hello Frank...

* Frank <hugelmopf-S0/GAf8tV78@public.gmane.org> [2005-09-08 22:36 +0200]:
> Thanks a lot, this solved it. Maybe a note on the download page might be 
> helpful?

done: http://acpi.sf.net/download.html

i always wanted to do that, but it always slipped out of my mind. :)

cheers,
 Sebastian


> Am Donnerstag, 8. September 2005 20:38 schrieb Matthew Wilcox:
> > On Thu, Sep 08, 2005 at 06:59:57PM +0200, Frank wrote:
> > > I am having problems compiling this compiler on AMD64.
> > > It throws the following error message:
> >
> > Are you on Debian?  I think this means you need to install flex-old.

-- 
Oo......................................................................oO
Jeden Tag eine Erisische Tat!
Oo. OpenPGP key ID: 0x7A62F9B4  Geekcode: GCSd-s:a-C++ULB+++W++M+PS+++ .oO

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]