public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
To: "Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: ML ACPI-devel
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	jfvasconcelos-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] Fixed buffered ACPI events for a lot ASUS machines
Date: Mon, 12 Sep 2005 13:39:15 +0200	[thread overview]
Message-ID: <432568E3.6040401@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi,

I finally could resolve the buffering of ACPI events on
some ASUS (M6N, M6000, A3500N, A6000G, maybe more...)
when battery module is loaded.

After hours of hopeless debugging I could track it down by comparing
with Yu Luming's previously patch posted on bugzilla.kernel.org.

Yu, could you confirm that this is really fixing a bug and totally safe?

Or was this intended and could possibly lead to problems on other machines?

Thanks,

      Thomas

[-- Attachment #2: acpi_fix_ASUS_M6N_bufferd_events.diff --]
[-- Type: text/x-patch, Size: 346 bytes --]

--- drivers/acpi/ec.c.orig	2005-09-12 13:22:13.000000000 +0200
+++ drivers/acpi/ec.c	2005-09-12 13:22:22.000000000 +0200
@@ -840,8 +840,8 @@
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Evaluating %s\n", object_name));
 
 	acpi_evaluate_object(ec->common.handle, object_name, NULL, NULL);
-end:	
 	atomic_dec(&ec->burst.pending_gpe);
+end:	
 	return;
 }
 

             reply	other threads:[~2005-09-12 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 11:39 Thomas Renninger [this message]
     [not found] ` <432568E3.6040401-l3A5Bk7waGM@public.gmane.org>
2005-09-13  2:31   ` [PATCH] Fixed buffered ACPI events for a lot ASUS machines Yu Luming
     [not found]     ` <200509131031.43570.luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2005-09-13  7:18       ` Thomas Renninger
     [not found]         ` <43267D43.3070305-l3A5Bk7waGM@public.gmane.org>
2005-09-13  9:08           ` Yu Luming
     [not found]             ` <200509131708.53544.luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2005-09-13 10:39               ` [Acpi4asus-user] " Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432568E3.6040401@suse.de \
    --to=trenn-l3a5bk7wagm@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jfvasconcelos-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox