Re: [PATCH] Fixed buffered ACPI events for a lot ASUS machines

[Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>]

Yu Luming wrote:
> On Monday 12 September 2005 19:39, Thomas Renninger wrote:
>> Hi,
>>
>>  I finally could resolve the buffering of ACPI events on
>>  some ASUS (M6N, M6000, A3500N, A6000G, maybe more...)
>>  when battery module is loaded.
>>
>>  After hours of hopeless debugging I could track it down by comparing
>>  with Yu Luming's previously patch posted on bugzilla.kernel.org.
> Do you mean the patch at http://bugzilla.kernel.org/show_bug.cgi?id=3851#c75?
> or http://bugzilla.kernel.org/show_bug.cgi?id=3851#c74
>>  Yu, could you confirm that this is really fixing a bug and totally safe?
>>
> Now ec->burst.pending_gpe is useless. it will be cleaned up.
> 
>>  Or was this intended and could possibly lead to problems on other
>> machines?
> 
> If the attached patch fixs the bug, I guess you are using old code.
> 
I used vanilla-2.6.13 with acpica-20050902 patches on it.
So it still seems to be used, at least on ASUS machines.
One of your old EC-burst patches in
http://bugzilla.kernel.org/show_bug.cgi?id=3851
had this little change. After reports of working ASUS machines with
this one, I found that newer EC-burst version do not have this
change anymore, but behave as the non EC-burst code on these machines.

Therefore I asked whether this change was intended or whether it is
a bug that slipped in by accident. So I expect the latter?

Thanks,

      Thomas


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf