public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonas Oreland <jonas-fAbYwIrWRvUAvxtiuMwx3w@public.gmane.org>
To: "Li, Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Fw: ACPI, pm timer and ASUS a8v
Date: Wed, 21 Sep 2005 12:19:58 +0200	[thread overview]
Message-ID: <433133CE.30002@mysql.com> (raw)
In-Reply-To: <59D45D057E9702469E5775CBB56411F1784E83@pdsmsx406>

Li, Shaohua wrote:
> How about add something like this:
> if (fadt->revision >= FADT2_REVISION_ID) {
> 		/* FADT rev. 2 */
> 		if (fadt->xpm_tmr_blk.address_space_id !=
> ACPI_ADR_SPACE_SYSTEM_IO)
> 			return 0;
> 
> 		pmtmr_ioport = fadt->xpm_tmr_blk.address;
> +		if (!pmtmr_ioport)
> +			pmtmr_ioport = fadt->V1_pm_tmr_blk;
> 	} else {
> 		/* FADT rev. 1 */
> 		pmtmr_ioport = fadt->V1_pm_tmr_blk;
> 	}

this works

/jonas

ps.
	I opened as andrew suggested a bug report: http://bugzilla.kernel.org/show_bug.cgi?id=5283
ds.

> 
> 
> 
>>-----Original Message-----
>>From: Jonas Oreland [mailto:jonas-fAbYwIrWRvUAvxtiuMwx3w@public.gmane.org]
>>Sent: Wednesday, September 21, 2005 3:44 PM
>>To: Li, Shaohua
>>Cc: Andrew Morton; acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>>Subject: Re: [ACPI] Fw: ACPI, pm timer and ASUS a8v
>>
>>Li, Shaohua wrote:
>>
>>>Hi Jonas,
>>>What the dmesg in the failure case? It seems the attched dmesg has
> 
> the
> 
>>>correct pm-timer info.
>>
>>yes, this is the "my own hardcoded" version.
>>
>>attaching one from failure case.
>>
>>thank you for looking at it.
>>
>>/Jonas
>>
>>
>>>Thanks,
>>>Shaohua
>>>
>>>
>>>
>>>>-----Original Message-----
>>>>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>>>>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Andrew Morton
>>>>Sent: Wednesday, September 21, 2005 2:18 PM
>>>>To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>>>>Cc: Jonas Oreland
>>>>Subject: [ACPI] Fw: ACPI, pm timer and ASUS a8v
>>>>
>>>>
>>>>Jonas, you'll probably need to raise an ACPi report at
>>>
>>>bugzilla.kernel.org
>>>
>>>
>>>>for this one please.
>>>>
>>>>Begin forwarded message:
>>>>
>>>>Date: Tue, 20 Sep 2005 14:12:53 +0200
>>>>From: Jonas Oreland <jonas-fAbYwIrWRvUAvxtiuMwx3w@public.gmane.org>
>>>>To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>>Subject: ACPI, pm timer and ASUS a8v
>>>>
>>>>
>>>>Hi,
>>>>
>>>>I running 2.6.12-gentoo-r10
>>>>I have a ASUS a8v motherboard with a AMD64 X2
>>>>
>>>>This gives me problem with clock drift
>>>>(see http://bugzilla.kernel.org/show_bug.cgi?id=5105)
>>>>
>>>>So I tried using notsc to force usage of pm timer.
>>>>
>>>>But!
>>>>The the acpi code find the fadt->xpm_tmr_blk.address to 0
>>>>Making the code yet again fall back to PIT/TSC
>>>>
>>>>I booted my system can run
>>>>perch> grep PM_ /proc/ioports
>>>>0808-080b : PM_TMR
>>>>
>>>>And harded the address 0x808 into pmtmr_ioport
>>>>This works. The system is using pmtmr and I get no clock drift
>>>>(tested now for ~a day)
>>>>
>>>>But why do ACPI find 0 as pmtmr_ioport?
>>>>
>>>>/Jonas
>>>
>>>
>>>
> 
> 



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

  reply	other threads:[~2005-09-21 10:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-21  8:09 Fw: ACPI, pm timer and ASUS a8v Li, Shaohua
2005-09-21 10:19 ` Jonas Oreland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-09-21  8:23 Li, Shaohua
2005-09-21  8:30 ` Andrew Morton
     [not found]   ` <20050921013019.74b5059e.akpm-3NddpPZAyC0@public.gmane.org>
2005-09-21  8:44     ` Shaohua Li
2005-09-21  7:03 Li, Shaohua
2005-09-21  7:44 ` Jonas Oreland
2005-09-21  6:17 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433133CE.30002@mysql.com \
    --to=jonas-fabywirwrvuavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox