From: Arnd Bergmann <arnd@arndb.de>
To: linaro-acpi@lists.linaro.org
Cc: Ashwin Chaugule <ashwin.chaugule@linaro.org>,
linux acpi <linux-acpi@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [Linaro-acpi] [PATCH v5 1/2] Mailbox: Add support for Platform Communication Channel
Date: Thu, 04 Sep 2014 21:00:11 +0200 [thread overview]
Message-ID: <4354903.8scPjxmpFT@wuerfel> (raw)
In-Reply-To: <CAJ5Y-eYj4vv3rmyaEiO5e9fmbeHX0eM1S9OuNn5R=9dPza_39Q@mail.gmail.com>
On Thursday 04 September 2014 13:24:25 Ashwin Chaugule wrote:
> On 4 September 2014 04:56, Arnd Bergmann <arnd@arndb.de> wrote:
>
> >> + /* Write to the shared comm region. */
> >> + iowrite16(cmd, &generic_comm_base->command);
> >> +
> >> + /* Write Subspace MAGIC value so platform can identify destination. */
> >> + iowrite32((PCCS_SS_SIG_MAGIC | ss_idx), &generic_comm_base->signature);
> >> +
> >> + /* Flip CMD COMPLETE bit */
> >> + iowrite16(0, &generic_comm_base->status);
> >
> > using writel_relaxed/writew_relaxed should be more efficient here.
> >
>
> x86 doesn't seem to have the write*_relaxed variants? They seem to
> have read*_relaxed though.
That sounds highly inconsistent and should probably be fixed.
You could also use writew here, which would be the same as iowrite16
on ARM, but more efficient on x86.
Arnd
next prev parent reply other threads:[~2014-09-04 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 22:19 [PATCH v5 0/2] PCC: Platform Communication Channel Ashwin Chaugule
2014-09-03 22:19 ` [PATCH v5 1/2] Mailbox: Add support for " Ashwin Chaugule
2014-09-04 4:35 ` Zheng, Lv
2014-09-04 4:38 ` Zheng, Lv
2014-09-04 14:31 ` Ashwin Chaugule
[not found] ` <5470309.KpxVtJyk9p@wuerfel>
2014-09-04 14:48 ` Ashwin Chaugule
2014-09-04 14:55 ` Arnd Bergmann
2014-09-04 17:24 ` Ashwin Chaugule
2014-09-04 19:00 ` Arnd Bergmann [this message]
2014-09-04 19:07 ` [Linaro-acpi] " Ashwin Chaugule
2014-09-04 22:20 ` Mark Brown
2014-09-03 22:19 ` [PATCH v5 2/2] PCC test Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4354903.8scPjxmpFT@wuerfel \
--to=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=broonie@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox