[PATCH] ACPI EC driver on ia64

[PATCH] ACPI EC driver on ia64

[Kenji Kaneshige]

Hi,

I need an ACPI EC driver on my IA64 machine. Currently CONFIG_ACPI_EC
depends on X86, so I cannot build ACPI EC driver on ia64. I tested
ACPI EC driver on ia64 with my special Kconfig, and it seemed to work
well. Could you consider applying the following patch to enable ACPI
EC driver on ia64?

Thanks,
Kenji Kaneshige


This patch enables ACPI EC driver on ia64.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

 drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
===================================================================
--- linux-2.6.15-rc5.orig/drivers/acpi/Kconfig
+++ linux-2.6.15-rc5/drivers/acpi/Kconfig
@@ -269,7 +269,7 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
+	depends on IA64 || X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of

Re: [PATCH] ACPI EC driver on ia64

[Bjorn Helgaas]

On Monday 05 December 2005 3:45 am, Kenji Kaneshige wrote:
> I need an ACPI EC driver on my IA64 machine. Currently CONFIG_ACPI_EC
> depends on X86, so I cannot build ACPI EC driver on ia64. I tested
> ACPI EC driver on ia64 with my special Kconfig, and it seemed to work
> well. Could you consider applying the following patch to enable ACPI
> EC driver on ia64?

>  config ACPI_EC
>  	bool
> -	depends on X86
> +	depends on IA64 || X86

Why not just remove the "depends on" altogether?  I don't see anything
in ec.c that's architecture-dependent.


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

Re: [PATCH] ACPI EC driver on ia64

[Kenji Kaneshige]

>> config ACPI_EC
>> 	bool
>>-	depends on X86
>>+	depends on IA64 || X86
> 
> 
> Why not just remove the "depends on" altogether?  I don't see anything
> in ec.c that's architecture-dependent.
> 

Only the reason was I didn't have x86_64 machine for testing
ACPI EC driver. But I think "depends on" should be removed,
as you said.

I'm attaching the updated patch.

Thanks,
Kenji Kaneshige


This patch removes "depends on X86" from config ACPI_EC. With this
patch, ACPI EC driver will be built also on x86_64 and ia64.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

 drivers/acpi/Kconfig |    1 -
 1 files changed, 1 deletion(-)

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
===================================================================
--- linux-2.6.15-rc5.orig/drivers/acpi/Kconfig
+++ linux-2.6.15-rc5/drivers/acpi/Kconfig
@@ -269,7 +269,6 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of