Re: [PATCH] acpi: make message more descriptive/meaningful

[Thomas Renninger <trenn@suse.de>]

Randy.Dunlap wrote:
> On Tue, 7 Feb 2006, Patrick Mochel wrote:
> 
>> On Mon, Feb 06, 2006 at 07:29:10PM -0800, Randy.Dunlap wrote:
>>
>>> Identify which device is not power-manageable to make
>>> the message more useful.
>>
>>> --- linux-2615-rc6g4.orig/drivers/acpi/bus.c
>>> +++ linux-2615-rc6g4/drivers/acpi/bus.c
>>> @@ -198,7 +198,8 @@ int acpi_bus_set_power(acpi_handle handl
>>>
>>>  	if (!device->flags.power_manageable) {
>>>  		ACPI_DEBUG_PRINT((ACPI_DB_WARN,
>>> -				  "Device is not power manageable\n"));
>>> +				  "Device '%s' is not power manageable\n",
>>> +					device->kobj.name));
>>
>> This is good information, but does it have to come in such a scary message?
>> It appears that something is wrong with the device, when in fact, it just
>> doesn't support an optional capability.
>>
>> Could we demote the message to e.g. ACPI_DB_INFO?
> 
I already moved this one with the big debug to error/warn ... patch.
It should now be ACPI_DB_INFO, but I did not add the device name though...

   Thomas