public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-acpi@vger.kernel.org, Pavel Machek <pavel@suse.cz>,
	"Brown, Len" <len.brown@intel.com>,
	davi.arnaut@gmail.com
Subject: Re: [PATCH] Avoid slab errors on suspend
Date: Wed, 08 Mar 2006 17:05:00 +0800	[thread overview]
Message-ID: <440E9E3C.5070802@intel.com> (raw)
In-Reply-To: <200603080951.29870.trenn@suse.de>

Thomas Renninger wrote:
> On Wednesday 08 March 2006 09:04, Thomas Renninger wrote:
>  > When going into suspend irqs must be disabled for a long time.
>  >
> Mine is very similar to recently posted:
> [patch 16/22] acpi_os_acquire_object (GFP_KERNEL) called with IRQs 
> disabled through suspend-resume
> 
> Hmm, but on my machine "acpi_os_derive_pci_id_2" is also invoked, 
> calling "acpi_evaluate_integer" in utils.c
> that also has a GFP_KERNEL call.
> 
> Davi, maybe it's best if you post the second part of your patch (which 
> is part of the
> ACPICA?) directly to Len/Robert.
> 
> Mine includes the first part of yours and adds some additional 
> acpi_in_resume checks that seem
> to be necessary on some machines.
If you want to workaround such issue, maybe we should change system_state
to !SYSTEM_RUNNING at the begining of irqrouter_resume' and restore it at
the end of this routine. This should solve all such issues.

Thanks,
Shaohua

      reply	other threads:[~2006-03-08  9:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-08  8:04 [PATH] Avoid slab errors on suspend Thomas Renninger
2006-03-08  8:51 ` [PATCH] " Thomas Renninger
2006-03-08  9:05   ` Shaohua Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440E9E3C.5070802@intel.com \
    --to=shaohua.li@intel.com \
    --cc=davi.arnaut@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox