Re: [RFC] [PATCH] Make ACPI button driver an input device

Pavel Machek
2006-04-24T21:30:06Z

Hi!

> >(Another interesting question is: is AC status 0/1 or is it number of
> > milivolts?)
>
> I'd say millivolts except for the problem of what you do on systems that
> don't support voltage readings. Use a very high value I guess. For a lot
> of devices millivolts also means in kernel conversion tables. Do such
> things belong in kernel or user space?

We should probably return 0/-1 in such case (-1 = on, but voltage unknown).

> > > to detect when its plugged in) ;). The battery class would export some
> > > information but not all of it and I don't know where the leftover
> > > information should go. If I knew that, I'd write the class.
> >
> > Leftover information?
>
> Where to put AC status and AC voltage readings amongst other things.
> Another sysfs class? Also, how do you control suspend/resume
> notifications to userspace if not using APM/ACPI?

I'd say that AC status should go to separate class, I'm
afraid. Potentially AC has more parameters (like current, current
frequency, difference between phase of current and voltage, ...?) and
UPSs even measure that.

Does userspace need to be notified of suspend/resume? [I keep
insisting that they do not, and I'm probably wrong, but... :-)]

Pavel
--
Thanks for all the (sleeping) penguins.