From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ashwin Chaugule <ashwin.chaugule@linaro.org>,
linux-acpi@vger.kernel.org, patches@linaro.org,
jassisinghbrar@gmail.com, rjw@rjwysocki.net,
linaro-acpi@lists.linaro.org, broonie@kernel.org
Subject: Re: [RFC v2 1/3] Mailbox: Add support for ACPI
Date: Thu, 12 Jun 2014 19:02:53 +0200 [thread overview]
Message-ID: <4476889.LvjMyVbGZ8@wuerfel> (raw)
In-Reply-To: <1402591692-7736-2-git-send-email-ashwin.chaugule@linaro.org>
On Thursday 12 June 2014 12:48:10 Ashwin Chaugule wrote:
>
> +#ifndef CONFIG_ACPI
> if (!mbox->of_xlate)
> mbox->of_xlate = of_mbox_index_xlate;
> -
> +#endif
> mutex_lock(&con_mutex);
> list_add_tail(&mbox->node, &mbox_cons);
> mutex_unlock(&con_mutex);
>
You can't do #ifndef here, the driver must still work if
both OF and ACPI are enabled.
Arnd
next prev parent reply other threads:[~2014-06-12 17:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 16:48 [RFC v2 0/3] ACPI Platform Communication Channel driver Ashwin Chaugule
2014-06-12 16:48 ` [RFC v2 1/3] Mailbox: Add support for ACPI Ashwin Chaugule
2014-06-12 16:52 ` Ashwin Chaugule
2014-06-12 17:02 ` Arnd Bergmann [this message]
2014-06-12 17:14 ` Ashwin Chaugule
2014-06-20 18:55 ` Ashwin Chaugule
2014-06-20 18:57 ` Ashwin Chaugule
2014-06-20 19:08 ` [Linaro-acpi] " Arnd Bergmann
2014-06-20 19:29 ` Ashwin Chaugule
2014-06-20 20:49 ` Arnd Bergmann
2014-06-20 21:43 ` Ashwin Chaugule
2014-06-21 9:34 ` Arnd Bergmann
2014-06-23 18:25 ` Ashwin Chaugule
2014-06-23 19:10 ` Arnd Bergmann
2014-06-23 19:46 ` Ashwin Chaugule
2014-06-23 20:21 ` Arnd Bergmann
2014-06-23 21:27 ` Ashwin Chaugule
2014-06-24 14:18 ` Arnd Bergmann
2014-06-24 17:55 ` Ashwin Chaugule
2014-06-25 15:08 ` Arnd Bergmann
2014-06-12 16:48 ` [RFC v2 2/3] ACPI: Add support for Platform Communication Channel Ashwin Chaugule
2014-06-12 16:48 ` [RFC v2 3/3] PCC test driver Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4476889.LvjMyVbGZ8@wuerfel \
--to=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=broonie@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox