From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46567C636D7 for ; Fri, 10 Feb 2023 21:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbjBJVxp (ORCPT ); Fri, 10 Feb 2023 16:53:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232860AbjBJVxo (ORCPT ); Fri, 10 Feb 2023 16:53:44 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB4AA36699; Fri, 10 Feb 2023 13:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676066023; x=1707602023; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vx5sAtd67oqSJ5HQNum0Qt2Ezi+uWPrpz/heDpnKEx0=; b=IGEZgCg1sV4E095GngvLPmkkfe6e78ZNdMMHsbTe8RQICzgbAqpSUPIC tr3mO2RskAhDXSXRieKnBtjWdCuoMMVH2K/IOlMFoy3z8QzL3YMnc/1im ZUsQjAp1vzsz6mfmyhG3LdJwI5SonvX0tQct+sLHZLTfVwqlabM461ktn JlaKp1FhxxQjvJYE5fjKPN8xwaPYIz6kOUA3PrJyA7wZmy8wWMYVKPSsy Pm1e+hy5ue2ityLkUWTJ7P1UbvRl9GOFS46YLQspiwv06p/9DFJ1aOKuo 3Pia9ZPmwqDoJ6ZDGEsG7r2qLWVyLEIVFK4ATE+66UNFXU/Whq5Hpa95k w==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="357937356" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="357937356" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:53:43 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="645765617" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="645765617" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.213.190.133]) ([10.213.190.133]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:53:42 -0800 Message-ID: <448c17f6-cdfa-9422-c35e-cf95e1b99604@intel.com> Date: Fri, 10 Feb 2023 14:53:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH v2 15/20] dax/hmem: Move HMAT and Soft reservation probe initcall level Content-Language: en-US To: Dan Williams , linux-cxl@vger.kernel.org Cc: Fan Ni , vishal.l.verma@intel.com, dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167602001107.1924368.11562316181038595611.stgit@dwillia2-xfh.jf.intel.com> From: Dave Jiang In-Reply-To: <167602001107.1924368.11562316181038595611.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2/10/23 2:06 AM, Dan Williams wrote: > In preparation for moving more filtering of "hmem" ranges into the > dax_hmem.ko module, update the initcall levels. HMAT range registration > moves to subsys_initcall() to be done before Soft Reservation probing, > and Soft Reservation probing is moved to device_initcall() to be done > before dax_hmem.ko initialization if it is built-in. > > Tested-by: Fan Ni > Link: https://lore.kernel.org/r/167564542109.847146.10113972881782419363.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang > --- > drivers/acpi/numa/hmat.c | 2 +- > drivers/dax/hmem/Makefile | 3 ++- > drivers/dax/hmem/device.c | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 605a0c7053be..ff24282301ab 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -869,4 +869,4 @@ static __init int hmat_init(void) > acpi_put_table(tbl); > return 0; > } > -device_initcall(hmat_init); > +subsys_initcall(hmat_init); > diff --git a/drivers/dax/hmem/Makefile b/drivers/dax/hmem/Makefile > index 57377b4c3d47..d4c4cd6bccd7 100644 > --- a/drivers/dax/hmem/Makefile > +++ b/drivers/dax/hmem/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > -obj-$(CONFIG_DEV_DAX_HMEM) += dax_hmem.o > +# device_hmem.o deliberately precedes dax_hmem.o for initcall ordering > obj-$(CONFIG_DEV_DAX_HMEM_DEVICES) += device_hmem.o > +obj-$(CONFIG_DEV_DAX_HMEM) += dax_hmem.o > > device_hmem-y := device.o > dax_hmem-y := hmem.o > diff --git a/drivers/dax/hmem/device.c b/drivers/dax/hmem/device.c > index 903325aac991..20749c7fab81 100644 > --- a/drivers/dax/hmem/device.c > +++ b/drivers/dax/hmem/device.c > @@ -104,4 +104,4 @@ static __init int hmem_init(void) > * As this is a fallback for address ranges unclaimed by the ACPI HMAT > * parsing it must be at an initcall level greater than hmat_init(). > */ > -late_initcall(hmem_init); > +device_initcall(hmem_init); >