linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 16/18] disable ACPI on some Phoenix BIOS
@ 2006-06-24 23:37 akpm
  0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2006-06-24 23:37 UTC (permalink / raw)
  To: len.brown; +Cc: linux-acpi, akpm, randy.dunlap, mjg59


From: Randy Dunlap <randy.dunlap@oracle.com>

Disable ACPI on some Phoenix BIOS, or the system will freeze.

http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=8ae54aeedb4b33a74ba5d811abef07d83f1838f4

Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 arch/i386/kernel/acpi/boot.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff -puN arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios arch/i386/kernel/acpi/boot.c
--- a/arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios
+++ a/arch/i386/kernel/acpi/boot.c
@@ -991,7 +991,15 @@ static struct dmi_system_id __initdata a
 		     DMI_MATCH(DMI_BOARD_NAME, "2629H1G"),
 		     },
 	 },
-
+	 {
+	  .callback = dmi_disable_acpi,
+	  .ident = "Phoenix Technologies",
+	  .matches = {
+	  	      DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies, LTD"),
+		      DMI_MATCH(DMI_BIOS_VERSION, "6.00 PG"),
+		      DMI_MATCH(DMI_BIOS_DATE, "11/05/2003"),
+	  	     },
+	 },
 	/*
 	 * Boxes that need acpi=ht
 	 */
_

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [patch 16/18] disable ACPI on some Phoenix BIOS
@ 2006-06-27  6:33 Brown, Len
  2006-06-27 17:37 ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Brown, Len @ 2006-06-27  6:33 UTC (permalink / raw)
  To: akpm; +Cc: linux-acpi, randy.dunlap, mjg59

What machine is this for?  The patch does not say.

What steps were taken to show that this is not
an ACPI bug in Linux that would be masked if we
applied this patch?

thanks,
-Len 

>-----Original Message-----
>From: akpm@osdl.org [mailto:akpm@osdl.org] 
>Sent: Saturday, June 24, 2006 7:37 PM
>To: Brown, Len
>Cc: linux-acpi@vger.kernel.org; akpm@osdl.org; 
>randy.dunlap@oracle.com; mjg59@srcf.ucam.org
>Subject: [patch 16/18] disable ACPI on some Phoenix BIOS
>
>
>From: Randy Dunlap <randy.dunlap@oracle.com>
>
>Disable ACPI on some Phoenix BIOS, or the system will freeze.
>
>http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-d
>apper.git;a=commitdiff;h=8ae54aeedb4b33a74ba5d811abef07d83f1838f4
>
>Cc: Matthew Garrett <mjg59@srcf.ucam.org>
>Signed-off-by: Andrew Morton <akpm@osdl.org>
>---
>
> arch/i386/kernel/acpi/boot.c |   10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff -puN 
>arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios 
>arch/i386/kernel/acpi/boot.c
>--- a/arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios
>+++ a/arch/i386/kernel/acpi/boot.c
>@@ -991,7 +991,15 @@ static struct dmi_system_id __initdata a
> 		     DMI_MATCH(DMI_BOARD_NAME, "2629H1G"),
> 		     },
> 	 },
>-
>+	 {
>+	  .callback = dmi_disable_acpi,
>+	  .ident = "Phoenix Technologies",
>+	  .matches = {
>+	  	      DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix 
>Technologies, LTD"),
>+		      DMI_MATCH(DMI_BIOS_VERSION, "6.00 PG"),
>+		      DMI_MATCH(DMI_BIOS_DATE, "11/05/2003"),
>+	  	     },
>+	 },
> 	/*
> 	 * Boxes that need acpi=ht
> 	 */
>_
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch 16/18] disable ACPI on some Phoenix BIOS
  2006-06-27  6:33 [patch 16/18] disable ACPI on some Phoenix BIOS Brown, Len
@ 2006-06-27 17:37 ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2006-06-27 17:37 UTC (permalink / raw)
  To: Brown, Len; +Cc: akpm, linux-acpi, mjg59

Brown, Len wrote:
> What machine is this for?  The patch does not say.
> 
> What steps were taken to show that this is not
> an ACPI bug in Linux that would be masked if we
> applied this patch?

We don't have a record of that info.

Matthew from Ubuntu wrote:
Yeah, this was a quick workaround. I think we'd probably be better off 
figuring out /why/ the system was freezing, but, well.

and Andrew asked about the machine specifics, but we haven't
received any more info.  Best just to drop it IMO.

Thanks,
~Randy


> thanks,
> -Len 
> 
>> -----Original Message-----
>> From: akpm@osdl.org [mailto:akpm@osdl.org] 
>> Sent: Saturday, June 24, 2006 7:37 PM
>> To: Brown, Len
>> Cc: linux-acpi@vger.kernel.org; akpm@osdl.org; 
>> randy.dunlap@oracle.com; mjg59@srcf.ucam.org
>> Subject: [patch 16/18] disable ACPI on some Phoenix BIOS
>>
>>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Disable ACPI on some Phoenix BIOS, or the system will freeze.
>>
>> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-d
>> apper.git;a=commitdiff;h=8ae54aeedb4b33a74ba5d811abef07d83f1838f4
>>
>> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
>> Signed-off-by: Andrew Morton <akpm@osdl.org>
>> ---
>>
>> arch/i386/kernel/acpi/boot.c |   10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff -puN 
>> arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios 
>> arch/i386/kernel/acpi/boot.c
>> --- a/arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios
>> +++ a/arch/i386/kernel/acpi/boot.c
>> @@ -991,7 +991,15 @@ static struct dmi_system_id __initdata a
>> 		     DMI_MATCH(DMI_BOARD_NAME, "2629H1G"),
>> 		     },
>> 	 },
>> -
>> +	 {
>> +	  .callback = dmi_disable_acpi,
>> +	  .ident = "Phoenix Technologies",
>> +	  .matches = {
>> +	  	      DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix 
>> Technologies, LTD"),
>> +		      DMI_MATCH(DMI_BIOS_VERSION, "6.00 PG"),
>> +		      DMI_MATCH(DMI_BIOS_DATE, "11/05/2003"),
>> +	  	     },
>> +	 },
>> 	/*
>> 	 * Boxes that need acpi=ht
>> 	 */
>> _
>>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [patch 16/18] disable ACPI on some Phoenix BIOS
@ 2006-06-27 20:59 Brown, Len
  0 siblings, 0 replies; 4+ messages in thread
From: Brown, Len @ 2006-06-27 20:59 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: akpm, linux-acpi, mjg59

yep, that is a NAK.

thanks,
-Len 

>-----Original Message-----
>From: Randy Dunlap [mailto:randy.dunlap@oracle.com] 
>Sent: Tuesday, June 27, 2006 1:38 PM
>To: Brown, Len
>Cc: akpm@osdl.org; linux-acpi@vger.kernel.org; mjg59@srcf.ucam.org
>Subject: Re: [patch 16/18] disable ACPI on some Phoenix BIOS
>
>Brown, Len wrote:
>> What machine is this for?  The patch does not say.
>> 
>> What steps were taken to show that this is not
>> an ACPI bug in Linux that would be masked if we
>> applied this patch?
>
>We don't have a record of that info.
>
>Matthew from Ubuntu wrote:
>Yeah, this was a quick workaround. I think we'd probably be better off 
>figuring out /why/ the system was freezing, but, well.
>
>and Andrew asked about the machine specifics, but we haven't
>received any more info.  Best just to drop it IMO.
>
>Thanks,
>~Randy
>
>
>> thanks,
>> -Len 
>> 
>>> -----Original Message-----
>>> From: akpm@osdl.org [mailto:akpm@osdl.org] 
>>> Sent: Saturday, June 24, 2006 7:37 PM
>>> To: Brown, Len
>>> Cc: linux-acpi@vger.kernel.org; akpm@osdl.org; 
>>> randy.dunlap@oracle.com; mjg59@srcf.ucam.org
>>> Subject: [patch 16/18] disable ACPI on some Phoenix BIOS
>>>
>>>
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Disable ACPI on some Phoenix BIOS, or the system will freeze.
>>>
>>> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-d
>>> apper.git;a=commitdiff;h=8ae54aeedb4b33a74ba5d811abef07d83f1838f4
>>>
>>> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
>>> Signed-off-by: Andrew Morton <akpm@osdl.org>
>>> ---
>>>
>>> arch/i386/kernel/acpi/boot.c |   10 +++++++++-
>>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>>
>>> diff -puN 
>>> arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios 
>>> arch/i386/kernel/acpi/boot.c
>>> --- a/arch/i386/kernel/acpi/boot.c~disable-acpi-on-some-phoenix-bios
>>> +++ a/arch/i386/kernel/acpi/boot.c
>>> @@ -991,7 +991,15 @@ static struct dmi_system_id __initdata a
>>> 		     DMI_MATCH(DMI_BOARD_NAME, "2629H1G"),
>>> 		     },
>>> 	 },
>>> -
>>> +	 {
>>> +	  .callback = dmi_disable_acpi,
>>> +	  .ident = "Phoenix Technologies",
>>> +	  .matches = {
>>> +	  	      DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix 
>>> Technologies, LTD"),
>>> +		      DMI_MATCH(DMI_BIOS_VERSION, "6.00 PG"),
>>> +		      DMI_MATCH(DMI_BIOS_DATE, "11/05/2003"),
>>> +	  	     },
>>> +	 },
>>> 	/*
>>> 	 * Boxes that need acpi=ht
>>> 	 */
>>> _
>>>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-06-27 21:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-27  6:33 [patch 16/18] disable ACPI on some Phoenix BIOS Brown, Len
2006-06-27 17:37 ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2006-06-27 20:59 Brown, Len
2006-06-24 23:37 akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).