Re: [12/12] acpi: set fake hid

["Mika Penttilä" <mika.penttila@kolumbus.fi>]

Zhang Rui wrote:
> On Fri, 2006-09-22 at 14:59 +0300, Mika Penttilä wrote: 
>   
>> +static int acpi_pci_bridge_match(struct acpi_device *device)
>> +{
>> +       acpi_status status;
>> +       acpi_handle handle;
>> +
>> +       /* pci bridge has _PRT but isn't PNP0A03 */
>> +       status = acpi_get_handle(device->handle, METHOD_NAME__PRT, &handle);
>> +       if (ACPI_FAILURE(status))
>> +               return -ENODEV;
>> +       if (!acpi_match_ids(device, "PNP0A03"))
>> +               return -ENODEV;
>> +       return 0;
>> +}
>> +
>>
>>
>> You seem to handle pci-pci bridge here incorrectly (returns -ENODEV from match to PNP0A03)
>>
>>     
> Is there any pci-pci bridge that has a _HID of "PNP0A03"?
>
> thanks,
> --Rui
>
>   
Don't know, but isn't the purpose here for acpi_pci_bridge_match() to 
match pci-pci bridges also? They won't just because they aren't PNP0A03.

--Mika

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html