Linus Torvalds wrote: > On Sun, 19 Nov 2006, Alexey Starikovskiy wrote: > >> I agree to all your comments with one exception, please see below. Attached is >> the reworked patch against latest git. Please test. >> > > Ok, this one works for me too, and looks much simpler. > > >> Linus Torvalds wrote: >> >>> And we might as well do it when we add an entry to the _deferred_ queue, no? >>> >> >> acpi_os_execute() is called from interrupt context for insertion into >> _deferred_ queue, so it's not possible to yield in it, no? >> > > Hmm. Yes. Anyway, the new patch looks acceptable, and certainly much > simpler than trying to count events. > > It probably causes tons of new unnecessary scheduling events, but I doubt > we really care. > > That said, what we _really_ want here is a "priority queue" for the > events, and some way to put an event back on the queue while running it > (eg ACPI "Sleep" event). But I guess the ACPI interpreter isn't done that > way (ie you can't just push and pop ACPI state). > > Linus > Linus, thanks for diagnosing and testing. Yes, interpeter is not currently able to put its stack aside. David, could you try this patch too? Regards, Alex.