Re: sonypc with Sony Vaio VGN-SZ1VP

Re: sonypc with Sony Vaio VGN-SZ1VP

[stelian]

>> > Will sony_acpi ever make it to the mainline? Its very useful for new
>> Vaio
>> > models.
>
> Nope, not as it is.  Useful != supportable.
>
> 1. It must not create any files under /proc/acpi
>     This is creating a machine-specific API, which
>     is exactly what we don't want  Nobody can maintain
>     50 machine specific APIs.
>
>     These objects must appear generic and under sysfs
>     as if acpi were not involved in providing them.
>
> 2. its source code shall not live in drivers/acpi
>     it is not part of the ACPI implementation after all --
>     it is a platform specific driver.

In this case, would a patch ripping off asus_acpi, ibm_acpi and
toshiba_acpi  from the kernel be accepted ?

I don't really care much about sony_acpi (since I'm not maintaining it
anymore, even if I still answer support requests about it), but this is
just silly. This has been going on for more than one and a half year now.

Meanwhile (at least from what I've seen), the ACPI subsystem still doesn't
provide this "generic" API which platform specific driver need to
implement. drivers/acpi/{hotkey.c,video.c} are just rudimentary, and there
is no indication that this is going forward:

In March 2005 you (Len) said:

> The goal is to DELETE ibm, toshiba, and asus drivers -- or at least the
> duplicated functions in them.
>
> platform specific drivers make it harder, not easier, to support more
> hardware -- there are a zillion vendors out there, implementing special
> drivers for each of them is a strategy of last resort.

and

> I'd like to keep this driver out-of-tree
> until we prove that we can't enhance the
> generic code to handle this hardware
> without the addition of a new driver.

How long is this going to take ?

Stelian.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Yu Luming]

On Wednesday 27 September 2006 19:51, stelian@popies.net wrote:
> >> > Will sony_acpi ever make it to the mainline? Its very useful for new
> >>
> >> Vaio
> >>
> >> > models.
> >
> > Nope, not as it is.  Useful != supportable.
> >
> > 1. It must not create any files under /proc/acpi
> >     This is creating a machine-specific API, which
> >     is exactly what we don't want  Nobody can maintain
> >     50 machine specific APIs.
> >
> >     These objects must appear generic and under sysfs
> >     as if acpi were not involved in providing them.
> >
> > 2. its source code shall not live in drivers/acpi
> >     it is not part of the ACPI implementation after all --
> >     it is a platform specific driver.
>
> In this case, would a patch ripping off asus_acpi, ibm_acpi and
> toshiba_acpi  from the kernel be accepted ?
>
> I don't really care much about sony_acpi (since I'm not maintaining it
> anymore, even if I still answer support requests about it), but this is
> just silly. This has been going on for more than one and a half year now.
>
> Meanwhile (at least from what I've seen), the ACPI subsystem still doesn't
> provide this "generic" API which platform specific driver need to
> implement. drivers/acpi/{hotkey.c,video.c} are just rudimentary, and there
> is no indication that this is going forward:
>
> In March 2005 you (Len) said:
> > The goal is to DELETE ibm, toshiba, and asus drivers -- or at least the
> > duplicated functions in them.
> >
> > platform specific drivers make it harder, not easier, to support more
> > hardware -- there are a zillion vendors out there, implementing special
> > drivers for each of them is a strategy of last resort.

hotkey.c was expected to replace all platform specific driver under
acpi directory, and I have ever expected that ACPI spec would define
standard device ID, and AML method name and event number for common keys
such as brightness control, output switch. So, I was expecting the hotkey.c
could become the generic driver when such spec was published and accepted
by OEMs. But, I don't know if such kind of things will happen.

>
> and
>
> > I'd like to keep this driver out-of-tree
> > until we prove that we can't enhance the
> > generic code to handle this hardware
> > without the addition of a new driver.

So, if there are NO standards, and we don't want mess up user space tools with
a dozen of totally different acpi proc interface for different platform 
drivers. We have to use  generic code to create  unified interface for the 
sake of clean user space tool.  Some technique are:
1. use input layer to translate any hot-key event into key code defined in 
input.h
2. use backlight class (driver/video/backlight.c)  to hook generic brightness 
control interface for brightness control under sysfs. 
3. use output class to hook generic output switch control interface for 
display output switch control under sysfs.
4. other generic code.
..
>
> How long is this going to take ?
>
I think the maintainer of asus_acpi, toshiba_acpi, ibm_acpi, sony_acpi, 
panasonic_acpi, msi_acpi, ... should use the techniques mentioned above.
for new platform, Please don't just fork a new driver from toshiba_acpi.c, or
the existing ones in drivers/acpi. They also need to use  generic code 
mentioned above.   Then, the platform specific driver could be accepted into 
mainline. Otherwise, I don't know how these kind of platform specific driver
can be maintained, and deployed by OSV.

Thanks,
Luming

Re: sonypc with Sony Vaio VGN-SZ1VP

[Len Brown]

On Wednesday 27 September 2006 07:51, stelian@popies.net wrote:
> >> > Will sony_acpi ever make it to the mainline? Its very useful for new

> > Nope, not as it is.  Useful != supportable.
> >
> > 1. It must not create any files under /proc/acpi
> >     This is creating a machine-specific API, which
> >     is exactly what we don't want  Nobody can maintain
> >     50 machine specific APIs.
> >
> >     These objects must appear generic and under sysfs
> >     as if acpi were not involved in providing them.
> >
> > 2. its source code shall not live in drivers/acpi
> >     it is not part of the ACPI implementation after all --
> >     it is a platform specific driver.
> 
>...
> 
> I don't really care much about sony_acpi (since I'm not maintaining it
> anymore, even if I still answer support requests about it), but this is
> just silly. This has been going on for more than one and a half year now.
> 
> Meanwhile (at least from what I've seen), the ACPI subsystem still doesn't
> provide this "generic" API which platform specific driver need to
> implement. drivers/acpi/{hotkey.c,video.c} are just rudimentary, and there
> is no indication that this is going forward:

You are right.  And the reason is that platform specific drivers are not part of ACPI.
They must either be vendor documented/supplied or reverse-engineered.
Vendors have not been forthcoming with documentation or code to support
Linux laptops, and our happy team here at Intel is not allowed to be in
the reverse enginering business.

So I concur that hotkey.c is a failed experiment, and I'm going to delete it.
There is more different than common on these boxes, so it makes no sense.

video.c, however, is standard, and stays for those machines that actually
do follow the public specification.

> In March 2005 you (Len) said:
> 
> > The goal is to DELETE ibm, toshiba, and asus drivers -- or at least the
> video.c handles the standard compliant machines.> duplicated functions in them.
> >
> > platform specific drivers make it harder, not easier, to support more
> > hardware -- there are a zillion vendors out there, implementing special
> > drivers for each of them is a strategy of last resort.

Still true, though it is clear we'll never be able to delete platform specific parts --
just the parts that duplicate the generic standard functions..
 
> > I'd like to keep this driver out-of-tree
> > until we prove that we can't enhance the
> > generic code to handle this hardware
> > without the addition of a new driver.
> 
> How long is this going to take ?

How about 2.6.21?
What needs to happen is
1. a maintainer for sony_acpi.c needs to step forward
    I can't do this, I'm not allowed to be in the reverse engineering business.

2. /proc/acpi/sony API needs to be deleted

3. source needs to move out of drivers/acpi, and into drivers/misc along with msi.

Luming has a sony laptop and can help with this, but
he can't be the permanent maintainer any more than I can, for the same reason.
If we can get past #1, then I recommend we apply the patch series in -mm to
the acpi-test tree and go from there.

-Len

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 00:24 -0500, Len Brown a écrit :

> > > I'd like to keep this driver out-of-tree
> > > until we prove that we can't enhance the
> > > generic code to handle this hardware
> > > without the addition of a new driver.
> > 
> > How long is this going to take ?
> 
> How about 2.6.21?

Good news !

> What needs to happen is
> 1. a maintainer for sony_acpi.c needs to step forward
>     I can't do this, I'm not allowed to be in the reverse engineering business.

Well, I can't do this either, because I just don't have the required
hardware anymore.

If someone want to step forward now it is a great time !
> 
> 2. /proc/acpi/sony API needs to be deleted
> 
> 3. source needs to move out of drivers/acpi, and into drivers/misc along with msi.

Sensible suggestions, the new maintainer will have to work on this.

Thanks Len.

-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Thu, Jan 04, 2007 at 11:09:44AM +0100, Stelian Pop wrote:
> Le jeudi 04 janvier 2007 à 00:24 -0500, Len Brown a écrit :
> 
> > > > I'd like to keep this driver out-of-tree
> > > > until we prove that we can't enhance the
> > > > generic code to handle this hardware
> > > > without the addition of a new driver.
> > > 
> > > How long is this going to take ?
> > 
> > How about 2.6.21?
> 
> Good news !
> 
> > What needs to happen is
> > 1. a maintainer for sony_acpi.c needs to step forward
> >     I can't do this, I'm not allowed to be in the reverse engineering business.
> 
> Well, I can't do this either, because I just don't have the required
> hardware anymore.
> 
> If someone want to step forward now it is a great time !

I have the hw and I'd be happy to do some basic working on the code
but:
- I'll probably need some help;
- I'll have an almost-blackout between the end of February and the end
  of April as I'm moving to a different country and I'll need some time
  before I can be active again (I hope I'll have at least easy mail
  access for all the time though).
Anyway if it is still ok I can maintain the thing, to months seems
enough to give the driver a shape.

> > 2. /proc/acpi/sony API needs to be deleted
> > 
> > 3. source needs to move out of drivers/acpi, and into drivers/misc along with msi.

And turn extra-backlight features into platform_device stuff? So 2 and 3
can come together.

Moreover, I own an SZ72B and an older GR7 and have come to the same
findings of Cacy, plus a patch to allow a smarter "debug" mode.
So, how to proceed? (I've just cloned the linux-acpi-2.6 tree)

Thanks Len, Thanks Stelian
-- 
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrew Morton]

On Thu, 4 Jan 2007 20:15:12 +0100
Mattia Dongili <malattia@linux.it> wrote:

> On Thu, Jan 04, 2007 at 11:09:44AM +0100, Stelian Pop wrote:
> > Le jeudi 04 janvier 2007 __ 00:24 -0500, Len Brown a __crit :
> > 
> > > > > I'd like to keep this driver out-of-tree
> > > > > until we prove that we can't enhance the
> > > > > generic code to handle this hardware
> > > > > without the addition of a new driver.
> > > > 
> > > > How long is this going to take ?
> > > 
> > > How about 2.6.21?
> > 
> > Good news !
> > 
> > > What needs to happen is
> > > 1. a maintainer for sony_acpi.c needs to step forward
> > >     I can't do this, I'm not allowed to be in the reverse engineering business.
> > 
> > Well, I can't do this either, because I just don't have the required
> > hardware anymore.
> > 
> > If someone want to step forward now it is a great time !
> 
> I have the hw and I'd be happy to do some basic working on the code

Neato, thanks.

> but:
> - I'll probably need some help;
> - I'll have an almost-blackout between the end of February and the end
>   of April as I'm moving to a different country and I'll need some time
>   before I can be active again (I hope I'll have at least easy mail
>   access for all the time though).
> Anyway if it is still ok I can maintain the thing, to months seems
> enough to give the driver a shape.
> 
> > > 2. /proc/acpi/sony API needs to be deleted
> > > 
> > > 3. source needs to move out of drivers/acpi, and into drivers/misc along with msi.
> 
> And turn extra-backlight features into platform_device stuff? So 2 and 3
> can come together.
> 
> Moreover, I own an SZ72B and an older GR7 and have come to the same
> findings of Cacy, plus a patch to allow a smarter "debug" mode.
> So, how to proceed? (I've just cloned the linux-acpi-2.6 tree)
> 

I have a VGN-something-or-other notebook and I use this driver regularly.

The place to start (please) is the patches in -mm:

2.6-sony_acpi4.patch
sony_apci-resume.patch
sony_apci-resume-fix.patch
acpi-add-backlight-support-to-the-sony_acpi.patch
acpi-add-backlight-support-to-the-sony_acpi-v2.patch
video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch

It presently has both the /proc and /sys/.../backlight/.. interfaces, so the first
job would be to chop out the /proc stuff.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Thu, Jan 04, 2007 at 12:51:07PM -0800, Andrew Morton wrote:
> On Thu, 4 Jan 2007 20:15:12 +0100
> Mattia Dongili <malattia@linux.it> wrote:
[...]
> > but:
> > - I'll probably need some help;
> > - I'll have an almost-blackout between the end of February and the end
> >   of April as I'm moving to a different country and I'll need some time
> >   before I can be active again (I hope I'll have at least easy mail
> >   access for all the time though).
> > Anyway if it is still ok I can maintain the thing, to months seems
> > enough to give the driver a shape.
> > 
> > > > 2. /proc/acpi/sony API needs to be deleted
> > > > 
> > > > 3. source needs to move out of drivers/acpi, and into drivers/misc along with msi.
> > 
> > And turn extra-backlight features into platform_device stuff? So 2 and 3
> > can come together.
> > 
> > Moreover, I own an SZ72B and an older GR7 and have come to the same
> > findings of Cacy, plus a patch to allow a smarter "debug" mode.
> > So, how to proceed? (I've just cloned the linux-acpi-2.6 tree)
> > 
> 
> I have a VGN-something-or-other notebook and I use this driver regularly.

Hehehe, I think all the sony lappies are VGN-something :)

> The place to start (please) is the patches in -mm:
> 
> 2.6-sony_acpi4.patch
> sony_apci-resume.patch
> sony_apci-resume-fix.patch
> acpi-add-backlight-support-to-the-sony_acpi.patch
> acpi-add-backlight-support-to-the-sony_acpi-v2.patch
> video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch
> 
> It presently has both the /proc and /sys/.../backlight/.. interfaces, so the first
> job would be to chop out the /proc stuff.

Ok, I'll import all of them and start from there.
Is it ok to wipe all the /proc stuff without notice?

-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrew Morton]

On Thu, 4 Jan 2007 22:18:30 +0100
Mattia Dongili <malattia@linux.it> wrote:

> > The place to start (please) is the patches in -mm:
> > 
> > 2.6-sony_acpi4.patch
> > sony_apci-resume.patch
> > sony_apci-resume-fix.patch
> > acpi-add-backlight-support-to-the-sony_acpi.patch
> > acpi-add-backlight-support-to-the-sony_acpi-v2.patch
> > video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch
> > 
> > It presently has both the /proc and /sys/.../backlight/.. interfaces, so the first
> > job would be to chop out the /proc stuff.
> 
> Ok, I'll import all of them and start from there.
> Is it ok to wipe all the /proc stuff without notice?

spose so.  I don't know if any apps are dependent upon the /proc file,
but the driver isn't in mainline yet so it's unlikely that there's a
mountain of software depending upon existing interfaces.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Timo Hoenig]

Hi,

On Thu, 2007-01-04 at 13:28 -0800, Andrew Morton wrote:

> spose so.  I don't know if any apps are dependent upon the /proc file,
> but the driver isn't in mainline yet so it's unlikely that there's a
> mountain of software depending upon existing interfaces.

Not a mountain, but still a few applications support that interface.

At least the powersave daemon 'powersaved' and HAL support the
brightness interface of the Sony driver.

The responsible developers are following the linux-acpi list.

   Timo

Re: sonypc with Sony Vaio VGN-SZ1VP

[Richard Hughes]

On Thu, 2007-01-04 at 13:28 -0800, Andrew Morton wrote:
> On Thu, 4 Jan 2007 22:18:30 +0100
> Mattia Dongili <malattia@linux.it> wrote:
> 
> > > The place to start (please) is the patches in -mm:
> > > 
> > > 2.6-sony_acpi4.patch
> > > sony_apci-resume.patch
> > > sony_apci-resume-fix.patch
> > > acpi-add-backlight-support-to-the-sony_acpi.patch
> > > acpi-add-backlight-support-to-the-sony_acpi-v2.patch
> > > video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch
> > > 
> > > It presently has both the /proc and /sys/.../backlight/.. interfaces, so the first
> > > job would be to chop out the /proc stuff.
> > 
> > Ok, I'll import all of them and start from there.
> > Is it ok to wipe all the /proc stuff without notice?
> 
> spose so.  I don't know if any apps are dependent upon the /proc file,
> but the driver isn't in mainline yet so it's unlikely that there's a
> mountain of software depending upon existing interfaces.

Well, HAL has used it for changing the brightness for the last year or
so: /proc/acpi/sony/brightness

Although if you use a new enough HAL (CVS), the laptop will be supported
via the shiny new backlight class.

Richard.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Thu, Jan 04, 2007 at 09:36:36PM +0000, Richard Hughes wrote:
> On Thu, 2007-01-04 at 13:28 -0800, Andrew Morton wrote:
> > On Thu, 4 Jan 2007 22:18:30 +0100
> > Mattia Dongili <malattia@linux.it> wrote:
> > 
> > > > The place to start (please) is the patches in -mm:
> > > > 
> > > > 2.6-sony_acpi4.patch
> > > > sony_apci-resume.patch
> > > > sony_apci-resume-fix.patch
> > > > acpi-add-backlight-support-to-the-sony_acpi.patch
> > > > acpi-add-backlight-support-to-the-sony_acpi-v2.patch
> > > > video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch
> > > > 
> > > > It presently has both the /proc and /sys/.../backlight/.. interfaces, so the first
> > > > job would be to chop out the /proc stuff.
> > > 
> > > Ok, I'll import all of them and start from there.
> > > Is it ok to wipe all the /proc stuff without notice?
> > 
> > spose so.  I don't know if any apps are dependent upon the /proc file,
> > but the driver isn't in mainline yet so it's unlikely that there's a
> > mountain of software depending upon existing interfaces.
> 
> Well, HAL has used it for changing the brightness for the last year or
> so: /proc/acpi/sony/brightness
> 
> Although if you use a new enough HAL (CVS), the laptop will be supported
> via the shiny new backlight class.

great, -mm already has the /sys/class/backlight in place for sony_acpi
and I suppose the /proc entry can be kept until 2.6.20 is released, i.e.
just before pushing things for .21.

Len, would you allow it?

-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Len Brown]

> > Well, HAL has used it for changing the brightness for the last year or
> > so: /proc/acpi/sony/brightness
> > 
> > Although if you use a new enough HAL (CVS), the laptop will be supported
> > via the shiny new backlight class.
> 
> great, -mm already has the /sys/class/backlight in place for sony_acpi
> and I suppose the /proc entry can be kept until 2.6.20 is released, i.e.
> just before pushing things for .21.
> 
> Len, would you allow it?

Sure, no problem.
Checking it into my tree with /proc/acpi/sony is
no different than what is in -mm today.

When we push upstream, however, the /proc/acpi/sony part should be gone,
or at least scheduled for removal.

I suggest a sub CONFIG option under CONFIG_SONY_ACPI, say,
CONFIG_SONY_ACPI_PROCFS so you can #ifdef the code that
is going away.

thanks for stepping forward Mattia,
-Len
 

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Fri, Jan 05, 2007 at 12:02:30PM -0500, Len Brown wrote:
> > > Well, HAL has used it for changing the brightness for the last year or
> > > so: /proc/acpi/sony/brightness
> > > 
> > > Although if you use a new enough HAL (CVS), the laptop will be supported
> > > via the shiny new backlight class.
> > 
> > great, -mm already has the /sys/class/backlight in place for sony_acpi
> > and I suppose the /proc entry can be kept until 2.6.20 is released, i.e.
> > just before pushing things for .21.
> > 
> > Len, would you allow it?
> 
> Sure, no problem.
> Checking it into my tree with /proc/acpi/sony is
> no different than what is in -mm today.
> 
> When we push upstream, however, the /proc/acpi/sony part should be gone,
> or at least scheduled for removal.

I'd rather avoid pushing mainline something already scheduled for
removal. Also, a workaround can eventually be implemented in the
userspace tools using /proc/acpi/sony

[...]
> thanks for stepping forward Mattia,

It's me who should thank :)
Thanks
-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 12:51 -0800, Andrew Morton a écrit :

> The place to start (please) is the patches in -mm:
> 
> 2.6-sony_acpi4.patch
> sony_apci-resume.patch
> sony_apci-resume-fix.patch
> acpi-add-backlight-support-to-the-sony_acpi.patch
> acpi-add-backlight-support-to-the-sony_acpi-v2.patch
> video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register-sony_acpi-fix.patch

In addition to those, I also have the attached patch in my local tree.

Stelian.

---

Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
and made correspondent necessary changes for this to work.

Signed-off-by: Nilton Volpato <nilton.volpato@gmail.com>
---

 drivers/acpi/sony_acpi.c |   55 ++++++++++++++++++++++++----------------------
 1 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/drivers/acpi/sony_acpi.c b/drivers/acpi/sony_acpi.c
index e23522a..0c9367f 100644
--- a/drivers/acpi/sony_acpi.c
+++ b/drivers/acpi/sony_acpi.c
@@ -33,7 +33,7 @@
 
 #define ACPI_SNC_CLASS		"sony"
 #define ACPI_SNC_HID		"SNY5001"
-#define ACPI_SNC_DRIVER_NAME	"ACPI Sony Notebook Control Driver v0.2"
+#define ACPI_SNC_DRIVER_NAME	"ACPI Sony Notebook Control Driver v0.3"
 
 #define LOG_PFX			KERN_WARNING "sony_acpi: "
 
@@ -61,6 +61,7 @@ static struct acpi_driver sony_acpi_driv
 
 static acpi_handle sony_acpi_handle;
 static struct proc_dir_entry *sony_acpi_dir;
+static struct acpi_device *sony_acpi_acpi_device = NULL;
 
 static struct sony_acpi_value {
 	char			*name;	 /* name of the entry */
@@ -245,7 +246,9 @@ static int sony_acpi_write(struct file *
 
 static void sony_acpi_notify(acpi_handle handle, u32 event, void *data)
 {
-	printk(LOG_PFX "sony_acpi_notify\n");
+	if (debug)
+		printk(LOG_PFX "sony_acpi_notify, event: %d\n", event);
+	acpi_bus_generate_event(sony_acpi_acpi_device, 1, event);
 }
 
 static acpi_status sony_walk_callback(acpi_handle handle, u32 level,
@@ -269,6 +272,8 @@ static int sony_acpi_add(struct acpi_dev
 	int result;
 	struct sony_acpi_value *item;
 
+	sony_acpi_acpi_device = device;
+
 	sony_acpi_handle = device->handle;
 
 	acpi_driver_data(device) = NULL;
@@ -282,16 +287,16 @@ static int sony_acpi_add(struct acpi_dev
 			result = -ENODEV;
 			goto outwalk;
 		}
+	}
 
-		status = acpi_install_notify_handler(sony_acpi_handle,
-						     ACPI_DEVICE_NOTIFY,
-						     sony_acpi_notify,
-						     NULL);
-		if (ACPI_FAILURE(status)) {
-			printk(LOG_PFX "unable to install notify handler\n");
-			result = -ENODEV;
-			goto outnotify;
-		}
+	status = acpi_install_notify_handler(sony_acpi_handle,
+					     ACPI_DEVICE_NOTIFY,
+					     sony_acpi_notify,
+					     NULL);
+	if (ACPI_FAILURE(status)) {
+		printk(LOG_PFX "unable to install notify handler\n");
+		result = -ENODEV;
+		goto outnotify;
 	}
 
 	for (item = sony_acpi_values; item->name; ++item) {
@@ -310,7 +315,7 @@ static int sony_acpi_add(struct acpi_dev
 		    		 item->acpiset, &handle)))
 		    	continue;
 
-		item->proc = create_proc_entry(item->name, 0600,
+		item->proc = create_proc_entry(item->name, 0666,
 					       acpi_device_dir(device));
 		if (!item->proc) {
 			printk(LOG_PFX "unable to create proc entry\n");
@@ -329,13 +334,11 @@ static int sony_acpi_add(struct acpi_dev
 	return 0;
 
 outproc:
-	if (debug) {
-		status = acpi_remove_notify_handler(sony_acpi_handle,
-						    ACPI_DEVICE_NOTIFY,
-						    sony_acpi_notify);
-		if (ACPI_FAILURE(status))
-			printk(LOG_PFX "unable to remove notify handler\n");
-	}
+	status = acpi_remove_notify_handler(sony_acpi_handle,
+					    ACPI_DEVICE_NOTIFY,
+					    sony_acpi_notify);
+	if (ACPI_FAILURE(status))
+		printk(LOG_PFX "unable to remove notify handler\n");
 outnotify:
 	for (item = sony_acpi_values; item->name; ++item)
 		if (item->proc)
@@ -350,13 +353,13 @@ static int sony_acpi_remove(struct acpi_
 	acpi_status status;
 	struct sony_acpi_value *item;
 
-	if (debug) {
-		status = acpi_remove_notify_handler(sony_acpi_handle,
-						    ACPI_DEVICE_NOTIFY,
-						    sony_acpi_notify);
-		if (ACPI_FAILURE(status))
-			printk(LOG_PFX "unable to remove notify handler\n");
-	}
+	sony_acpi_acpi_device = NULL;
+
+	status = acpi_remove_notify_handler(sony_acpi_handle,
+					    ACPI_DEVICE_NOTIFY,
+					    sony_acpi_notify);
+	if (ACPI_FAILURE(status))
+		printk(LOG_PFX "unable to remove notify handler\n");
 
 	for (item = sony_acpi_values; item->name; ++item)
 		if (item->proc)

-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrew Morton]

On Fri, 05 Jan 2007 00:36:23 +0100
Stelian Pop <stelian@popies.net> wrote:

> Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
> and made correspondent necessary changes for this to work.

neato.

err, how does one use this?

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 15:44 -0800, Andrew Morton a écrit :
> On Fri, 05 Jan 2007 00:36:23 +0100
> Stelian Pop <stelian@popies.net> wrote:
> 
> > Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
> > and made correspondent necessary changes for this to work.
> 
> neato.
> 
> err, how does one use this?

:)

Well, it seems that on some Vaios (including Nilton's pcg-frv26 but not
only this one), the Fn key events aren't seen by sonypi or sony_acpi
GHKE method, but do generate an ACPI notify event.

For those laptops, the patch forwards the ACPI event to the ACPI system
and can be later interpreted in userspace using
acpid's /etc/acpi/default.sh (example directly from Nilton):

> case "$group" in
>     button)
>         case "$action" in
>             power) /usr/sbin/hibernate
>                 ;;
>
>             lid) cat /proc/acpi/button/lid/LID/state
>                 ;;
> 
>             *)  logger "ACPI action $action is not defined ($@)"
>                 ;;
>         esac
>         ;;
> 
>     SNC) echo "$@" > /dev/tcp/localhost/50007
>         ;;
> 
>     *) logger "ACPI group $group / action $action is not defined"
>         ;;
> esac
> 
> In which I just forward the SNC event to another userspace application
> listening on a TCP port.

Stelian.
-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrew Morton]

On Fri, 05 Jan 2007 00:54:32 +0100
Stelian Pop <stelian@popies.net> wrote:

> Le jeudi 04 janvier 2007 à 15:44 -0800, Andrew Morton a écrit :
> > On Fri, 05 Jan 2007 00:36:23 +0100
> > Stelian Pop <stelian@popies.net> wrote:
> > 
> > > Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
> > > and made correspondent necessary changes for this to work.
> > 
> > neato.
> > 
> > err, how does one use this?
> 
> :)
> 
> Well, it seems that on some Vaios (including Nilton's pcg-frv26 but not
> only this one), the Fn key events aren't seen by sonypi or sony_acpi
> GHKE method, but do generate an ACPI notify event.

Speak English ;)

> For those laptops, the patch forwards the ACPI event to the ACPI system
> and can be later interpreted in userspace using
> acpid's /etc/acpi/default.sh (example directly from Nilton):

The only things Mr Red Hat gave me are /etc/acpi/events/sample.conf and
/etc/acpi/events/video.conf.

> > case "$group" in
> >     button)
> >         case "$action" in
> >             power) /usr/sbin/hibernate
> >                 ;;
> >
> >             lid) cat /proc/acpi/button/lid/LID/state
> >                 ;;
> > 
> >             *)  logger "ACPI action $action is not defined ($@)"
> >                 ;;
> >         esac
> >         ;;
> > 
> >     SNC) echo "$@" > /dev/tcp/localhost/50007
> >         ;;
> > 
> >     *) logger "ACPI group $group / action $action is not defined"
> >         ;;
> > esac
> > 
> > In which I just forward the SNC event to another userspace application
> > listening on a TCP port.
> 

I pressed then released a button and dmesg said

[   76.961568] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 1
[   76.961576] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
[   76.963277] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 0
[   76.963284] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
[   76.967341] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 1
[   76.967349] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
[   76.968136] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 0
[   76.968143] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0

Nothing else happened.

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 20:16 -0800, Andrew Morton a écrit :
> On Fri, 05 Jan 2007 00:54:32 +0100
> Stelian Pop <stelian@popies.net> wrote:
> 
> > Le jeudi 04 janvier 2007 à 15:44 -0800, Andrew Morton a écrit :
> > > On Fri, 05 Jan 2007 00:36:23 +0100
> > > Stelian Pop <stelian@popies.net> wrote:
> > > 
> > > > Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
> > > > and made correspondent necessary changes for this to work.
> > > 
> > > neato.
> > > 
> > > err, how does one use this?
> > 
> > :)
> > 
> > Well, it seems that on some Vaios (including Nilton's pcg-frv26 but not
> > only this one), the Fn key events aren't seen by sonypi or sony_acpi
> > GHKE method, but do generate an ACPI notify event.
> 
> Speak English ;)

Oh, sorry, I'll try again :)

There are several ways of detecting the Fn key events, depending on the
Vaio series:
	- some Vaios report them using the SPIC device (driven by sonypi)
	- some Vaios let the driver poll for the Fn key status using the GHKE
ACPI method of the SNC device (driven by sony_acpi)
	- some Vaios generate an ACPI notify event on the SNC device when a Fn
key is pressed - this is what the latest patch is for.

Unfortunately there are way too many different Vaio series, and no
information about what series support what method. I should have
maintained some sort of wiki to let the users build themselves a
comprehensive list, but I never get around to do it. Maybe Mattia could
do it if he has the time and will...

> > For those laptops, the patch forwards the ACPI event to the ACPI system
> > and can be later interpreted in userspace using
> > acpid's /etc/acpi/default.sh (example directly from Nilton):
> 
> The only things Mr Red Hat gave me are /etc/acpi/events/sample.conf and
> /etc/acpi/events/video.conf.

Well, there was an /etc/acpi/default.sh in an older version of acpid...
I'm not sure what it looks like now on a recent Fedora but on my Ubuntu
I still have an acpid package, which has some files in /etc/acpi/
looking familiar.

> I pressed then released a button and dmesg said
> 
> [   76.961568] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 1
> [   76.961576] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
> [   76.963277] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 0
> [   76.963284] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
> [   76.967341] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 1
> [   76.967349] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
> [   76.968136] evbug.c: Event. Dev: <NULL>, Type: 1, Code: 148, Value: 0
> [   76.968143] evbug.c: Event. Dev: <NULL>, Type: 0, Code: 0, Value: 0
> 
> Nothing else happened.

Well, you got the events from evdev, which means you probably got them
directly from sonypi (or the regular keyboard..)

Unless your distribution does some neat tricks and somehow feeds the
events coming from somewhere into the event subsystem (like Ubuntu's
acpi_fakekey for example...).

Stelian.
-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[MoRpHeUz]

Hi,

  I own a Sony Vaio VGN-SZ340 and I had problems regarding acpi + it's
dual core processor. The guys from Intel gave me a workaround and now
it recognises both cores.

  The problem is that it does not do cpu frequency scaling for both
cores, just for cpu0...And when I boot with acpi the Nvidia graphic
card doesnt work also.

  I don't know if you know about these problems regarding sony acpi.
The guys from Intel said that this notebook have 2 dst's. So to detect
both cores the workaround just uses the second dst (although frequency
scaling does work for both.)

  I can help you to fix this bug...I have the machine where we can do
some tests..


Best regards,


On 1/4/07, Andrew Morton <akpm@osdl.org> wrote:
> On Fri, 05 Jan 2007 00:36:23 +0100
> Stelian Pop <stelian@popies.net> wrote:
>
> > Added acpi_bus_generate event for forwarding Fn-keys pressed to acpi subsystem,
> > and made correspondent necessary changes for this to work.
>
> neato.
>
> err, how does one use this?
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[Len Brown]

On Thursday 04 January 2007 21:20, MoRpHeUz wrote:
> Hi,
> 
>   I own a Sony Vaio VGN-SZ340 and I had problems regarding acpi + it's
> dual core processor. The guys from Intel gave me a workaround and now
> it recognises both cores.

What workaround are you using?

>   The problem is that it does not do cpu frequency scaling for both
> cores, just for cpu0...And when I boot with acpi the Nvidia graphic
> card doesnt work also.
> 
>   I don't know if you know about these problems regarding sony acpi.
> The guys from Intel said that this notebook have 2 dst's. So to detect
> both cores the workaround just uses the second dst (although frequency
> scaling does work for both.)
> 
>   I can help you to fix this bug...I have the machine where we can do
> some tests..

The frequency scaling issue sounds like a BIOS/Linux incompatibility.
Please open a bugzilla, if you haven't already, and include the
output from acpidump.

The nvidia issue sounds like an interrupt issue, so please reproduce
it using the open source nvidia driver (not the nvidia binary),
and include the lspci -vv output, dmesg, and /proc/interrupts.

thanks,
-Len

Re: Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[MoRpHeUz]

> What workaround are you using?

 This one: http://bugzilla.kernel.org/show_bug.cgi?id=7465

> The frequency scaling issue sounds like a BIOS/Linux incompatibility.
> Please open a bugzilla, if you haven't already, and include the
> output from acpidump.

  I agree that it sound like a BIOS/Linux incompatibility. You can
find my acpidump and DSDT inside the link above. That bug is still
opened.

> The nvidia issue sounds like an interrupt issue, so please reproduce
> it using the open source nvidia driver (not the nvidia binary),
> and include the lspci -vv output, dmesg, and /proc/interrupts.

  Will try that !

Thanks !

Re: Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[Len Brown]

On Friday 05 January 2007 12:24, MoRpHeUz wrote:
> > What workaround are you using?
> 
>  This one: http://bugzilla.kernel.org/show_bug.cgi?id=7465

Ah yes, the duplicate MADT issue is clearly a BIOS bug.
It is possible that we can tweak our Linux workaround for it to be more
Microsoft Windows Bug Compatbile(TM).

> > The frequency scaling issue sounds like a BIOS/Linux incompatibility.

It looks like this issue results from that above,
rather than being an additional problem.

> > The nvidia issue sounds like an interrupt issue, so please reproduce
> > it using the open source nvidia driver (not the nvidia binary),
> > and include the lspci -vv output, dmesg, and /proc/interrupts.
> 
>   Will try that !

If interrupts fail using the open source nvidia driver, (and using the workaround
from the bug above to use the right MADT, please open a new bug report
as I think it would be an independent issue.

thanks,
-Len

Re: Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[Bjorn Helgaas]

On Friday 05 January 2007 11:10, Len Brown wrote:
> On Friday 05 January 2007 12:24, MoRpHeUz wrote:
> > > What workaround are you using?
> > 
> >  This one: http://bugzilla.kernel.org/show_bug.cgi?id=7465
> 
> Ah yes, the duplicate MADT issue is clearly a BIOS bug.
> It is possible that we can tweak our Linux workaround for it to be more
> Microsoft Windows Bug Compatbile(TM).

Maybe Windows discovers processors using the namespace rather
than the MADT.

Re: Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[Len Brown]

On Friday 05 January 2007 23:09, Bjorn Helgaas wrote:
> On Friday 05 January 2007 11:10, Len Brown wrote:
> > On Friday 05 January 2007 12:24, MoRpHeUz wrote:
> > > > What workaround are you using?
> > > 
> > >  This one: http://bugzilla.kernel.org/show_bug.cgi?id=7465
> > 
> > Ah yes, the duplicate MADT issue is clearly a BIOS bug.
> > It is possible that we can tweak our Linux workaround for it to be more
> > Microsoft Windows Bug Compatbile(TM).
> 
> Maybe Windows discovers processors using the namespace rather
> than the MADT.

Nod.

Based on the fact that the 1st MADT on this box is toast, they're not using that.
If the last one also doesn't work universally, then they must be using the namespace.

For us to do the same would be a relatively significant change -- as it means
we either have to push SMP startup after the interpreter init, or move the
interpreter init yet sooner.

In general, over the last couple of years, we've been forced for compatibility
with various systems to move ACPI initialization sooner and sooner.
(I think the last issue was getting the HW into "ACPI mode" sooner
 because some stuff I don't recall didn't work if we didn't)
It would probably make sense to experiment with what the soonest we
can initialize ACPI, as I have a feeling we're going to have to head that way.

-Len

Re: Sony Vaio VGN-SZ340 (was Re: sonypc with Sony Vaio VGN-SZ1VP)

[Alexey Starikovskiy]

Len Brown wrote:
> On Friday 05 January 2007 23:09, Bjorn Helgaas wrote:
>   
>> On Friday 05 January 2007 11:10, Len Brown wrote:
>>     
>>> On Friday 05 January 2007 12:24, MoRpHeUz wrote:
>>>       
>>>>> What workaround are you using?
>>>>>           
>>>>  This one: http://bugzilla.kernel.org/show_bug.cgi?id=7465
>>>>         
>>> Ah yes, the duplicate MADT issue is clearly a BIOS bug.
>>> It is possible that we can tweak our Linux workaround for it to be more
>>> Microsoft Windows Bug Compatbile(TM).
>>>       
>> Maybe Windows discovers processors using the namespace rather
>> than the MADT.
>>     
>
> Nod.
>
> Based on the fact that the 1st MADT on this box is toast, they're not using that.
> If the last one also doesn't work universally, then they must be using the namespace.
>
> For us to do the same would be a relatively significant change -- as it means
> we either have to push SMP startup after the interpreter init, or move the
> interpreter init yet sooner.
>
> In general, over the last couple of years, we've been forced for compatibility
> with various systems to move ACPI initialization sooner and sooner.
> (I think the last issue was getting the HW into "ACPI mode" sooner
>  because some stuff I don't recall didn't work if we didn't)
> It would probably make sense to experiment with what the soonest we
> can initialize ACPI, as I have a feeling we're going to have to head that way.
>
> -Len
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

If any of the two tables does not work, may be we need both together?

Regards,
    Alex.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Jan Engelhardt]

On Jan 5 2007 00:36, Stelian Pop wrote:
>@@ -61,6 +61,7 @@ static struct acpi_driver sony_acpi_driv
> 
> static acpi_handle sony_acpi_handle;
> static struct proc_dir_entry *sony_acpi_dir;
>+static struct acpi_device *sony_acpi_acpi_device = NULL;

acpi_acpi?

>@@ -310,7 +315,7 @@ static int sony_acpi_add(struct acpi_dev
> 		    		 item->acpiset, &handle)))
> 		    	continue;
> 
>-		item->proc = create_proc_entry(item->name, 0600,
>+		item->proc = create_proc_entry(item->name, 0666,
> 					       acpi_device_dir(device));
> 		if (!item->proc) {
> 			printk(LOG_PFX "unable to create proc entry\n");

Is this safe? I would not want normal users to poke on that.


	-`J'
--
Himself owner of a VAIO U3.

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Fri, Jan 05, 2007 at 01:11:16AM +0100, Jan Engelhardt wrote:
> 
> On Jan 5 2007 00:36, Stelian Pop wrote:
> >@@ -61,6 +61,7 @@ static struct acpi_driver sony_acpi_driv
> > 
> > static acpi_handle sony_acpi_handle;
> > static struct proc_dir_entry *sony_acpi_dir;
> >+static struct acpi_device *sony_acpi_acpi_device = NULL;
> 
> acpi_acpi?
> 
> >@@ -310,7 +315,7 @@ static int sony_acpi_add(struct acpi_dev
> > 		    		 item->acpiset, &handle)))
> > 		    	continue;
> > 
> >-		item->proc = create_proc_entry(item->name, 0600,
> >+		item->proc = create_proc_entry(item->name, 0666,
> > 					       acpi_device_dir(device));
> > 		if (!item->proc) {
> > 			printk(LOG_PFX "unable to create proc entry\n");
> 
> Is this safe? I would not want normal users to poke on that.

Hmmm, seconded. It also seems quite a gratuitous change and I have a
different patch that takes care of permissions and the /proc stuff is
going away in any case.

-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le vendredi 05 janvier 2007 à 01:11 +0100, Jan Engelhardt a écrit :
> On Jan 5 2007 00:36, Stelian Pop wrote:
> >@@ -61,6 +61,7 @@ static struct acpi_driver sony_acpi_driv
> > 
> > static acpi_handle sony_acpi_handle;
> > static struct proc_dir_entry *sony_acpi_dir;
> >+static struct acpi_device *sony_acpi_acpi_device = NULL;
> 
> acpi_acpi?

Yeah, maybe Mattia will have more imagination than I at naming
variables :)

-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 20:15 +0100, Mattia Dongili a écrit :

> > If someone want to step forward now it is a great time !
> 
> I have the hw and I'd be happy to do some basic working on the code

Cool ! 

> but:
> - I'll probably need some help;

Feel free to ask...

> - I'll have an almost-blackout between the end of February and the end
>   of April as I'm moving to a different country and I'll need some time
>   before I can be active again (I hope I'll have at least easy mail
>   access for all the time though).

Well, I am the current "maintainer" for this and it has probably been a
year since I left Sony's laptop world, so I guess it won't make much
difference if you're not very active for a month or two :)

Stelian.
-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Neil Bird]

Around about 04/01/07 19:15, Mattia Dongili typed ...
> I have the hw and I'd be happy to do some basic working on the code

   OK, I'm going to jump in here with something I've been meaning to post 
for a while;  now seems as good a time as any :)

   I *think* I'm using the code you're all talking about on my Vaio:  the 
sony_acpi (0.3?) module that works where the stick s=kernel sonypi doesn't.

   I'm also (currently) using the fsfn daemon/osd-app, or at least modified 
versions of them (my laptop, like other poeple's, doesn't report back the 
current brightness, so the fsfn daemon remembers the value and uses that 
instead for higher/lower settings).


   I've been tinkering with the module code, initially just to add this 
brightness-value memory to the module (so the /proc entries do actually 
work) via a module param, and this works a treat.

   I've also added the ability to watch for key presses and inject fake key 
presses, so that the Fn buttons are seen by the kernel and X, etc., and can 
thus be bound by GNOME or KDE in the normal fashion, making it (for me) more 
immediately useful, esp. for the generic keys (S1/S2 on mine).

   But last time I tried (couple of kernel releases ago) it crashes on 
start-up;  I think it's something to do with kmallocs in the ACPI code tyhat 
I'm calling that aren't allowed in certain contexts, buit I have no control 
over what kmallocs are used in acpi.

   If anyone's interested, I'll email them my latest copy.  I got a bit 
stuck as the last attempt lost the actual error off the top of the screen 
before locking and I don't know how to get the console output, erm, output 
to anything other than the screen on my laptop.

-- 
[neil@fnx ~]# rm -f .signature
[neil@fnx ~]# ls -l .signature
ls: .signature: No such file or directory
[neil@fnx ~]# exit

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Fri, Jan 05, 2007 at 09:23:21AM +0000, Neil Bird wrote:
> Around about 04/01/07 19:15, Mattia Dongili typed ...
> >I have the hw and I'd be happy to do some basic working on the code
> 
>   OK, I'm going to jump in here with something I've been meaning to post 
> for a while;  now seems as good a time as any :)
> 
>   I *think* I'm using the code you're all talking about on my Vaio:  the 
> sony_acpi (0.3?) module that works where the stick s=kernel sonypi doesn't.
>
>   I'm also (currently) using the fsfn daemon/osd-app, or at least modified 
> versions of them (my laptop, like other poeple's, doesn't report back the 
> current brightness, so the fsfn daemon remembers the value and uses that 
> instead for higher/lower settings).
> 
> 
>   I've been tinkering with the module code, initially just to add this 
> brightness-value memory to the module (so the /proc entries do actually 
> work) via a module param, and this works a treat.
> 
>   I've also added the ability to watch for key presses and inject fake key 
> presses, so that the Fn buttons are seen by the kernel and X, etc., and can 
> thus be bound by GNOME or KDE in the normal fashion, making it (for me) 
> more immediately useful, esp. for the generic keys (S1/S2 on mine).
> 
>   But last time I tried (couple of kernel releases ago) it crashes on 
> start-up;  I think it's something to do with kmallocs in the ACPI code 
> tyhat I'm calling that aren't allowed in certain contexts, buit I have no 
> control over what kmallocs are used in acpi.
> 
>   If anyone's interested, I'll email them my latest copy.  I got a bit 
> stuck as the last attempt lost the actual error off the top of the screen 
> before locking and I don't know how to get the console output, erm, output 
> to anything other than the screen on my laptop.

Ok, could you send me a copy? I'll see if I can add some of your code.
BTW, which vaio model is this?

Can you send me the DSDT too?
(acpidump -b -t DSDT -o DSDT.aml && iasl -d DSDT.aml)

Thanks
-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Neil Bird]

Around about 05/01/07 16:24, Mattia Dongili typed ...
> Ok, could you send me a copy? I'll see if I can add some of your code.
> BTW, which vaio model is this?
> Can you send me the DSDT too?
> (acpidump -b -t DSDT -o DSDT.aml && iasl -d DSDT.aml)

   Will do.  it'll be a tarball of my build area, tho', not a diff;  I think 
that'd be too confusing.  I'll Cc: myself at hmoe and post it to you from there.

   It's an FJ3S OTTOMH.  Only got it in August, but it's not around any more :-/

http://vaio.sony-europe.com/view/ShowProduct.action?product=VGN-FJ3S%2FW&site=ite_en_GB&pageType=Overview&category=PM+FJ+Series


   BTW, in my original post, s/stick s=kernel/stock kernel/ :-)

-- 
[neil@fnx ~]# rm -f .signature
[neil@fnx ~]# ls -l .signature
ls: .signature: No such file or directory
[neil@fnx ~]# exit

Re: sonypc with Sony Vaio VGN-SZ1VP [repost]

[Neil Bird]

   [orig. quietly didn't make it to the list for some reason]


Around about 05/01/07 16:24, Mattia Dongili typed ...
> Ok, could you send me a copy? I'll see if I can add some of your code.
> BTW, which vaio model is this?
> Can you send me the DSDT too?
> (acpidump -b -t DSDT -o DSDT.aml && iasl -d DSDT.aml)

   Will do.  it'll be a tarball of my build area, tho', not a diff;  I think
that'd be too confusing.  I'll Cc: myself at hmoe and post it to you from there.

   It's an FJ3S OTTOMH.  Only got it in August, but it's not around any more :-/

http://vaio.sony-europe.com/view/ShowProduct.action?product=VGN-FJ3S%2FW&site=ite_en_GB&pageType=Overview&category=PM+FJ+Series


   BTW, in my original post, s/stick s=kernel/stock kernel/ :-)

-- 
[neil@fnx ~]# rm -f .signature
[neil@fnx ~]# ls -l .signature
ls: .signature: No such file or directory
[neil@fnx ~]# exit

Re: sonypc with Sony Vaio VGN-SZ1VP

[Len Brown]

On Friday 05 January 2007 04:23, Neil Bird wrote:

>    But last time I tried (couple of kernel releases ago) it crashes on 
> start-up;  I think it's something to do with kmallocs in the ACPI code tyhat 
> I'm calling that aren't allowed in certain contexts, buit I have no control 
> over what kmallocs are used in acpi.

running the AML interpreter in  interrupt context would be a no-no.

I thought we had deferred the notify handlers so that they wouldn't
run in interrupt context, but maybe there is a case here where
that does not happen.

-Len

Re: sonypc with Sony Vaio VGN-SZ1VP

[Neil Bird]

Around about 05/01/07 17:19, Len Brown typed ...
> running the AML interpreter in  interrupt context would be a no-no.
> I thought we had deferred the notify handlers so that they wouldn't
> run in interrupt context, but maybe there is a case here where
> that does not happen.

   Yes, I tracked though the kernel acpi code as much as I could, and found 
that I was making acpi calls that did kmalloc() with the 'wrong' arg. in a 
context that didn't allow it (where /proc reads would).

   Unfortunately, the solutions I tried (diff. ways of deferral using notify 
handlers) still failed, or at least stuffed it on boot (which is what my 
current code-base does).  The last code I traced was the bit that looked up 
the full ACPI ref. from a local ref., and that does a malloc, so I did the 
lookup at module init and stored that full string to bypass the lookup 
malloc later, but then it just goes wrong a bit later :-(

-- 
[neil@fnx ~]# rm -f .signature
[neil@fnx ~]# ls -l .signature
ls: .signature: No such file or directory
[neil@fnx ~]# exit

Re: sonypc with Sony Vaio VGN-SZ1VP [repost]

[Neil Bird]

   [orig. quietly didn't make it to the list for some reason]

Around about 05/01/07 17:19, Len Brown typed ...
> running the AML interpreter in  interrupt context would be a no-no.
> I thought we had deferred the notify handlers so that they wouldn't
> run in interrupt context, but maybe there is a case here where
> that does not happen.

   Yes, I tracked though the kernel acpi code as much as I could, and found
that I was making acpi calls that did kmalloc() with the 'wrong' arg. in a
context that didn't allow it (where /proc reads would).

   Unfortunately, the solutions I tried (diff. ways of deferral using notify
handlers) still failed, or at least stuffed it on boot (which is what my
current code-base does).  The last code I traced was the bit that looked up
the full ACPI ref. from a local ref., and that does a malloc, so I did the
lookup at module init and stored that full string to bypass the lookup
malloc later, but then it just goes wrong a bit later :-(

-- 
[neil@fnx ~]# rm -f .signature
[neil@fnx ~]# ls -l .signature
ls: .signature: No such file or directory
[neil@fnx ~]# exit

Re: sonypc with Sony Vaio VGN-SZ1VP

[Stelian Pop]

Le jeudi 04 janvier 2007 à 20:15 +0100, Mattia Dongili a écrit :

> > > What needs to happen is
> > > 1. a maintainer for sony_acpi.c needs to step forward
> > >     I can't do this, I'm not allowed to be in the reverse engineering business.
> > 
> > Well, I can't do this either, because I just don't have the required
> > hardware anymore.
> > 
> > If someone want to step forward now it is a great time !
> 
> I have the hw and I'd be happy to do some basic working on the code

FYI, sonypi is also searching for a new maintainer, and it is quite
closely related to sony_acpi...

If you are interested by the job, it is all yours. :)

Stelian.
-- 
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Fri, Jan 05, 2007 at 11:02:03AM +0100, Stelian Pop wrote:
> Le jeudi 04 janvier 2007 à 20:15 +0100, Mattia Dongili a écrit :
> 
> > > > What needs to happen is
> > > > 1. a maintainer for sony_acpi.c needs to step forward
> > > >     I can't do this, I'm not allowed to be in the reverse engineering business.
> > > 
> > > Well, I can't do this either, because I just don't have the required
> > > hardware anymore.
> > > 
> > > If someone want to step forward now it is a great time !
> > 
> > I have the hw and I'd be happy to do some basic working on the code
> 
> FYI, sonypi is also searching for a new maintainer, and it is quite
> closely related to sony_acpi...

Yes, probably the FnKeys stuff needs to worked out into a single driver
to ease it usage (I still remember some very old discussion about making
sonypi use the acpi methods to access the hw).

> If you are interested by the job, it is all yours. :)

Let's see if I can come up with something, I have also an ux50 that is
not very happy with current sonypi

Thanks
-- 
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Jan Engelhardt]

On Jan 5 2007 13:13, Mattia Dongili wrote:
>
>> If you are interested by the job, it is all yours. :)
>
>Let's see if I can come up with something, I have also an ux50 that is
>not very happy with current sonypi

Feel free to contact me for testing on U3.
FnKey is done through sonypi here, if I unload it, `showkey` does not give
keycodes for them anymore.

	-`J'
-- 

Re: sonypc with Sony Vaio VGN-SZ1VP

[Luming Yu]

> Luming has a sony laptop and can help with this, but
> he can't be the permanent maintainer any more than I can, for the same reason.
> If we can get past #1, then I recommend we apply the patch series in -mm to
> the acpi-test tree and go from there.

Yes, I happen to have a sony laptop. So, I can help the permanent
maintainer of sony acpi driver on acpi related issues.
--Luming

RE: sonypc with Sony Vaio VGN-SZ1VP

[Cacy Rodney]

Hello everyone!

I know that the thread is much further but I'd like to inform the 
maintainer (whoever is) that the driver v0.2 (there is v0.3 but in this 
context it is not important) with the updated sony_acpi_values structure 
(enclosed at the end) is working and gives me about 20% of energy 
conservation.
By clear, I have Sony Vaio SZ2.
The cdpower(cdrom),sound,lan files in sony directory can power off 
(_PS3) the relevant devices. To do that

echo 0 >/proc/acpi/sony/cdpower etc.

To ON the devices

echo 1 >/proc/acpi/sony/cdpower etc.

(unfortunately, after the commend sequence the lan card is not 
initialized properly and to use it again the computer must be rebooted - 
but i'm working to change it :))

The acpi methods of SNC are:

Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GBRT, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SBRT, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GPBR, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SPBR, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: PWAK, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: PWRN, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CSXB, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GWDP, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CDPW, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GCDP, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SLRS, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: RBMF, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: RSBI, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CBMF, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: AZPW, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GAZP, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: LNPW, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GLNP, args 0
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SCAM, args 1
Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GCAM, args 0

Anyone knows what the rest do?

Best regards
Cacy


} sony_acpi_values[] = {
         {
                 .name           = "brightness",
                 .acpiget        = "GBRT",
                 .acpiset        = "SBRT",
                 .min            = 1,
                 .max            = 8,
                 .debug          = 0,
         },
         {
                 .name           = "brightness_default",
                 .acpiget        = "GPBR",
                 .acpiset        = "SPBR",
                 .min            = 1,
                 .max            = 8,
                 .debug          = 0,
         },
         {
                 .name           = "cdpower",
                 .acpiget        = "GCDP",
                 .acpiset        = "CDPW",
                 .min            = 0,
                 .max            = 1,
                 .debug          = 0,
         },
         {
                 .name           = "sound",
                 .acpiget        = "GAZP",
                 .acpiset        = "AZPW",
                 .min            = 0,
                 .max            = 1,
                 .debug          = 0,
         },
         {
                 .name           = "lan",
                 .acpiget        = "GLNP",
                 .acpiset        = "LNPW",
                 .min            = 0,
                 .max            = 1,
                 .debug          = 0,
         },
         {
                 .name           = NULL,
         }
};

Re: sonypc with Sony Vaio VGN-SZ1VP

[Len Brown]

On Thursday 04 January 2007 12:58, Cacy Rodney wrote:
> Hello everyone!
> 
> I know that the thread is much further but I'd like to inform the 
> maintainer (whoever is) that the driver v0.2 (there is v0.3 but in this 
> context it is not important) with the updated sony_acpi_values structure 
> (enclosed at the end) is working and gives me about 20% of energy 
> conservation.
> By clear, I have Sony Vaio SZ2.
> The cdpower(cdrom),sound,lan files in sony directory can power off 
> (_PS3) the relevant devices. To do that
> 
> echo 0 >/proc/acpi/sony/cdpower etc.
> 
> To ON the devices
> 
> echo 1 >/proc/acpi/sony/cdpower etc.
> 
> (unfortunately, after the commend sequence the lan card is not 
> initialized properly and to use it again the computer must be rebooted - 
> but i'm working to change it :))
> 
> The acpi methods of SNC are:
> 
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GBRT, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SBRT, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GPBR, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SPBR, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: PWAK, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: PWRN, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CSXB, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GWDP, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CDPW, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GCDP, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SLRS, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: RBMF, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: RSBI, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: CBMF, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: AZPW, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GAZP, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: LNPW, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GLNP, args 0
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: SCAM, args 1
> Jan  4 17:56:12 darkstar kernel: sony_acpi: method: name: GCAM, args 0
> 
> Anyone knows what the rest do?
> 
> Best regards
> Cacy
> 
> 
> } sony_acpi_values[] = {
>          {
>                  .name           = "brightness",
>                  .acpiget        = "GBRT",
>                  .acpiset        = "SBRT",
>                  .min            = 1,
>                  .max            = 8,
>                  .debug          = 0,
>          },
>          {
>                  .name           = "brightness_default",
>                  .acpiget        = "GPBR",
>                  .acpiset        = "SPBR",
>                  .min            = 1,
>                  .max            = 8,
>                  .debug          = 0,
>          },
>          {
>                  .name           = "cdpower",
>                  .acpiget        = "GCDP",
>                  .acpiset        = "CDPW",
>                  .min            = 0,
>                  .max            = 1,
>                  .debug          = 0,
>          },
>          {
>                  .name           = "sound",
>                  .acpiget        = "GAZP",
>                  .acpiset        = "AZPW",
>                  .min            = 0,
>                  .max            = 1,
>                  .debug          = 0,
>          },
>          {
>                  .name           = "lan",
>                  .acpiget        = "GLNP",
>                  .acpiset        = "LNPW",
>                  .min            = 0,
>                  .max            = 1,
>                  .debug          = 0,
>          },
>          {
>                  .name           = NULL,
>          }
> };

With /proc/acpi/ going away, this raises the question of where sony_acpi should put stuff
that is under development -- as unlike brightness -- it will not have a generic home in sysfs.

To do it right,  some analysis of the DSDT which has these vendor methods in them
will be necessary.  It is conceivable that these methods can be hooked to the generic
device power management support if the "real" devices in sysfs can be found.

A word of warning, which may be totally obvious here, is that the method names above
are completely arbitrary choices on the part of a BIOS engineer at Sony, and the
next BIOS engineer can make completely different choices for what names are used
or what the same names do.

Only if we had documentation or some sort of support from Sony could we know or sure.
Happily they identified their platform device with PNPID SNY5001 -- so at least this
stuff will not run wild on non-Sony products.

cheers,
-Len

Re: sonypc with Sony Vaio VGN-SZ1VP

[Mattia Dongili]

On Fri, Jan 05, 2007 at 12:33:20PM -0500, Len Brown wrote:
[...]
> With /proc/acpi/ going away, this raises the question of where sony_acpi should put stuff
> that is under development -- as unlike brightness -- it will not have a generic home in sysfs.

I was thinking the same and had 2 options in my mind:

1- debugfs (with proper documentation)

2- turn the SNC into a platform_device driver (as is msi-laptop) and
   eventually  create .config options to enable experimental/debug
   features.

> To do it right,  some analysis of the DSDT which has these vendor methods in them
> will be necessary.  It is conceivable that these methods can be hooked to the generic
> device power management support if the "real" devices in sysfs can be found.

In my DSDT[1] some of the methods (the audio card power setter: AZPW)
references a method in the real device (the same used in
_PS0 and _PS3 for the device) so it's actually a duplicate and the real
device already has the capability. I'd say all the others are playing
with random IO registers or in the EC0 operation region.

[1]: sz72b http://oioio.altervista.org/linux/DSDT.sz72b.dsl

other DSDTs I have:
http://oioio.altervista.org/linux/DSDT.ux50.dsl
http://oioio.altervista.org/linux/DSDT.gr7k.dsl

> A word of warning, which may be totally obvious here, is that the method names above
> are completely arbitrary choices on the part of a BIOS engineer at Sony, and the
> next BIOS engineer can make completely different choices for what names are used
> or what the same names do.

This is already partly happened, at least a known old method name has
mutated.

I'll send a first rush of patches as soon as I decide how to deal with
the different method names.
-- 
mattia
:wq!

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrew Morton]

On Tue, 26 Sep 2006 20:56:31 +0300
Ismail Donmez <ismail@pardus.org.tr> wrote:

> 26 Eyl 2006 Sal 19:29 tarihinde şunları yazmıştınız:
> > Andrea Gelmini a écrit :
> > > Hi,
> > > 	I've got a Sony Vaio VGN-SZ1VP (dmidecode[1] and lspci[2]).
> > > 	Using default kernel (linux-image-2.6.15-27-686) of Ubuntu
> > > 	Dapper I've got /proc/acpi/sony/brightness and it works well
> > > 	(yes, Ubuntu drivers/char/sonypi.c is patched).
> > > 	With any other newer vanilla kernel, 2.6.15/16/17/18, /proc/acpi/sony
> > > 	doesn't appear, and it's impossibile to set brigthness, of
> > > 	course. Same thing with Ubuntu kernel package
> > > 	(linux-image-2.6.17-9-386).
> > > 	I tried to port Ubuntu sonypi.c patches to 2.6.18, but it doesn't
> > > 	work (I mean, it compiles clean, it "modprobes"[3] clean, but no
> > > 	/proc/acpi/sony/ directory).
> >
> > /proc/acpi/sony comes from the sony_acpi driver, not sonypi.
> >
> > You should get the latest sony_acpi driver, preferably from the -mm tree
> > which hosts the most up to date version.
> 
> Will sony_acpi ever make it to the mainline? Its very useful for new Vaio 
> models.
> 

I'm inclined to slip it in, but Len has good-sounding reasons for not
merging this sort of driver, and I always forget what they are?

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Jan Engelhardt]

>> Will sony_acpi ever make it to the mainline? Its very useful for new Vaio 
>> models.
>
>I'm inclined to slip it in, but Len has good-sounding reasons for not
>merging this sort of driver, and I always forget what they are?

http://lkml.org/lkml/2006/1/5/57


Jan Engelhardt
-- 

Re: sonypc with Sony Vaio VGN-SZ1VP

[Len Brown]

On Wednesday 27 September 2006 01:14, Andrew Morton wrote:
> On Tue, 26 Sep 2006 20:56:31 +0300
> Ismail Donmez <ismail@pardus.org.tr> wrote:
> 
> > 26 Eyl 2006 Sal 19:29 tarihinde şunları yazmıştınız:
> > > Andrea Gelmini a écrit :
> > > > Hi,
> > > > 	I've got a Sony Vaio VGN-SZ1VP (dmidecode[1] and lspci[2]).
> > > > 	Using default kernel (linux-image-2.6.15-27-686) of Ubuntu
> > > > 	Dapper I've got /proc/acpi/sony/brightness and it works well
> > > > 	(yes, Ubuntu drivers/char/sonypi.c is patched).
> > > > 	With any other newer vanilla kernel, 2.6.15/16/17/18, /proc/acpi/sony
> > > > 	doesn't appear, and it's impossibile to set brigthness, of
> > > > 	course. Same thing with Ubuntu kernel package
> > > > 	(linux-image-2.6.17-9-386).
> > > > 	I tried to port Ubuntu sonypi.c patches to 2.6.18, but it doesn't
> > > > 	work (I mean, it compiles clean, it "modprobes"[3] clean, but no
> > > > 	/proc/acpi/sony/ directory).
> > >
> > > /proc/acpi/sony comes from the sony_acpi driver, not sonypi.
> > >
> > > You should get the latest sony_acpi driver, preferably from the -mm tree
> > > which hosts the most up to date version.
> > 
> > Will sony_acpi ever make it to the mainline? Its very useful for new Vaio 
> > models.

Nope, not as it is.  Useful != supportable.

1. It must not create any files under /proc/acpi
    This is creating a machine-specific API, which
    is exactly what we don't want  Nobody can maintain
    50 machine specific APIs.

    These objects must appear generic and under sysfs
    as if acpi were not involved in providing them.

2. its source code shall not live in drivers/acpi
    it is not part of the ACPI implementation after all --
    it is a platform specific driver.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Ismail Donmez]

Hi,
27 Eyl 2006 Çar 09:04 tarihinde, Len Brown şunları yazmıştı: 
[...]
> > > Will sony_acpi ever make it to the mainline? Its very useful for new
> > > Vaio models.
>
> Nope, not as it is.  Useful != supportable.
>
> 1. It must not create any files under /proc/acpi
>     This is creating a machine-specific API, which
>     is exactly what we don't want  Nobody can maintain
>     50 machine specific APIs.
>
>     These objects must appear generic and under sysfs
>     as if acpi were not involved in providing them.
>
> 2. its source code shall not live in drivers/acpi
>     it is not part of the ACPI implementation after all --
>     it is a platform specific driver.

Is there a such example code under kernel now, so one could look at it and fix 
sony_acpi driver.

Regards,
ismail

-- 
They that can give up essential liberty to obtain a little temporary safety 
deserve neither liberty nor safety.
-- Benjamin Franklin
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Yu Luming]

On Wednesday 27 September 2006 15:50, Ismail Donmez wrote:
> Hi,
> 27 Eyl 2006 Çar 09:04 tarihinde, Len Brown şunları yazmıştı:
> [...]
>
> > > > Will sony_acpi ever make it to the mainline? Its very useful for new
> > > > Vaio models.
> >
> > Nope, not as it is.  Useful != supportable.
> >
> > 1. It must not create any files under /proc/acpi
> >     This is creating a machine-specific API, which
> >     is exactly what we don't want  Nobody can maintain
> >     50 machine specific APIs.
> >
> >     These objects must appear generic and under sysfs
> >     as if acpi were not involved in providing them.

Yes, the idea of generic code and sysfs things can
remove the supportable issues as to complete different
user interface exposed in /proc/acpi/ by different
platform specific drivers such as ibm_acpi.c,
asus_acpi.c, and toshiba_acpi.c,....

> >
> > 2. its source code shall not live in drivers/acpi
> >     it is not part of the ACPI implementation after all --
> >     it is a platform specific driver.
>
> Is there a such example code under kernel now, so one could look at it and
> fix sony_acpi driver.

Please take a look at drivers/video/backlight..
And here is a example to use backlight class for acpi video driver:
http://marc.theaimsgroup.com/?l=linux-acpi&m=115574087203605&w=2

Please let me know if you have any other ideas to consolidate the
platform specific drivers such as ibm_acpi.c ,asus_acpi.c, toshiba_acpi.c
panasonic_acpi.c, sony_acpi.c , msi s270.c .....

Thanks,
Luming

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

[Andrea Gelmini]

On Tue, Sep 26, 2006 at 10:14:00PM -0700, Andrew Morton wrote:
> I'm inclined to slip it in, but Len has good-sounding reasons for not
> merging this sort of driver, and I always forget what they are?

well, for us, users/owners of newest vaio, there's no choice. with default
brightness it's impossibile, really impossibile, to read even the
characters of the console, in daylight.

carrie would say: "is it better to have sex with so-so partner, or not
having sex at all?".

Thanks a lot for your time,
Andrea