Bad libata resume behaviour due to ACPICA change (in acpi-test)

Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

On an otherwise ordinary ThinkPad T43, v2.6.20-rc7-g190ff5b runs and works
beaufully, however if I apply the acpi-test patches, it adds a 40-50s pause
right after libata tries to resume the disks.

Here's the relevant info:

1. The relevant detail of logs of a normal resume:
Feb  1 20:50:02 thorin kernel: ata2.00: configured for UDMA/33
Feb  1 20:50:02 thorin kernel: ata1.00: configured for UDMA/100
Feb  1 20:50:02 thorin kernel: SCSI device sda: 117210240 512-byte hdwr sectors (60012 MB)
Feb  1 20:50:02 thorin kernel: sda: Write Protect is off
Feb  1 20:50:02 thorin kernel: sda: Mode Sense: 00 3a 00 00
Feb  1 20:50:02 thorin kernel: SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Feb  1 20:50:20 thorin kernel: ...

2. The relevant detail of logs of a resume with the strange pause:
Feb  1 19:21:28 thorin kernel: Restarting tasks ... done.
Feb  1 19:21:29 thorin kernel: ata2.00: configured for UDMA/33
Feb  1 19:21:29 thorin kernel: ata1.00: configured for UDMA/100
Feb  1 19:21:29 thorin kernel: SCSI device sda: 117210240 512-byte hdwr sectors (60012 MB)
Feb  1 19:21:29 thorin kernel: sda: Write Protect is off
Feb  1 19:21:29 thorin kernel: sda: Mode Sense: 00 3a 00 00
Feb  1 19:21:29 thorin kernel: SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Feb  1 19:21:53 thorin kernel: ...

Note the timestamps on the two last lines of the log.  Another delay I had
was bigger by 20s.  It is really, *really* annoying.

3. The affected PCI device:

00:1f.2 IDE interface: Intel Corporation 82801FBM (ICH6M) SATA Controller (rev 03) (prog-if 80 [Master])
        Subsystem: IBM Unknown device 056a
        Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
        Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 0
        Region 0: I/O ports at 01f0 [size=8]
        Region 1: I/O ports at 03f4 [size=1]
        Region 2: I/O ports at 0170 [size=8]
        Region 3: I/O ports at 0374 [size=1]
        Region 4: I/O ports at 18c0 [size=16]
        Capabilities: [70] Power Management version 2
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-

4. The relevant DSDT:
http://acpi.sourceforge.net/dsdt/view.php?id=742

5. The culprit (insert ob. Linus-is-a-genius git bisect thanks here):

 5559e40e60632ab6927f08cd2a2a3b65c088fc03 is first bad commit
 commit 5559e40e60632ab6927f08cd2a2a3b65c088fc03
 Author: Bob Moore <robert.moore@intel.com>
 Date:   Tue Jan 23 15:49:27 2007 +0300

    ACPICA: Disable all wake GPEs after first one recieved
    
    Change for GPE support: when a wake GPE is
    received, now all wake GPEs are immediately disabled to
    prevent the waking GPE from firing again, and to prevent
    other wake GPEs from interrupting the wake process.
    
    Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>

I will try to run with the above commit reverted, so as to continue playing
with the acpi-test tree.

If there is anything I can contribute to help shape up the above into
something that is not annoying for ThinkPad T43 onwers, just tell me what,
and I'll see what I can do.

The bug is reproducible at will.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

RE: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Starikovskiy, Alexey Y]

Henrique,

I cannot reproduce your problem with T43 here on linux-acpi-test with
defconfig (relevant ACPI modules were tried both dynamic and static).
Resume time is about 4-6 seconds, not 20-40 as you mention.
Could you please send your .config and try defconfig on your machine?

BTW, my T43 use AHCI mode of SATA controller, if it matters...

Regards,
	Alex.

>-----Original Message-----
>From: Henrique de Moraes Holschuh [mailto:hmh@hmh.eng.br]
>Sent: Saturday, February 03, 2007 3:42 AM
>To: linux-acpi@vger.kernel.org
>Cc: Starikovskiy, Alexey Y; Brown, Len
>Subject: Bad libata resume behaviour due to ACPICA change (in
acpi-test)
>
>On an otherwise ordinary ThinkPad T43, v2.6.20-rc7-g190ff5b runs and
works
>beaufully, however if I apply the acpi-test patches, it adds a 40-50s
pause
>right after libata tries to resume the disks.
>
>Here's the relevant info:
>
>1. The relevant detail of logs of a normal resume:
>Feb  1 20:50:02 thorin kernel: ata2.00: configured for UDMA/33
>Feb  1 20:50:02 thorin kernel: ata1.00: configured for UDMA/100
>Feb  1 20:50:02 thorin kernel: SCSI device sda: 117210240 512-byte hdwr
>sectors (60012 MB)
>Feb  1 20:50:02 thorin kernel: sda: Write Protect is off
>Feb  1 20:50:02 thorin kernel: sda: Mode Sense: 00 3a 00 00
>Feb  1 20:50:02 thorin kernel: SCSI device sda: write cache: enabled,
read
>cache: enabled, doesn't support DPO or FUA
>Feb  1 20:50:20 thorin kernel: ...
>
>2. The relevant detail of logs of a resume with the strange pause:
>Feb  1 19:21:28 thorin kernel: Restarting tasks ... done.
>Feb  1 19:21:29 thorin kernel: ata2.00: configured for UDMA/33
>Feb  1 19:21:29 thorin kernel: ata1.00: configured for UDMA/100
>Feb  1 19:21:29 thorin kernel: SCSI device sda: 117210240 512-byte hdwr
>sectors (60012 MB)
>Feb  1 19:21:29 thorin kernel: sda: Write Protect is off
>Feb  1 19:21:29 thorin kernel: sda: Mode Sense: 00 3a 00 00
>Feb  1 19:21:29 thorin kernel: SCSI device sda: write cache: enabled,
read
>cache: enabled, doesn't support DPO or FUA
>Feb  1 19:21:53 thorin kernel: ...
>
>Note the timestamps on the two last lines of the log.  Another delay I
had
>was bigger by 20s.  It is really, *really* annoying.
>
>3. The affected PCI device:
>
>00:1f.2 IDE interface: Intel Corporation 82801FBM (ICH6M) SATA
Controller
>(rev 03) (prog-if 80 [Master])
>        Subsystem: IBM Unknown device 056a
>        Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr-
>Stepping- SERR- FastB2B-
>        Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium
>TAbort-
><TAbort- <MAbort- >SERR- <PERR-
>        Latency: 0
>        Region 0: I/O ports at 01f0 [size=8]
>        Region 1: I/O ports at 03f4 [size=1]
>        Region 2: I/O ports at 0170 [size=8]
>        Region 3: I/O ports at 0374 [size=1]
>        Region 4: I/O ports at 18c0 [size=16]
>        Capabilities: [70] Power Management version 2
>                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-
>,D3hot+,D3cold-)
>                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>
>4. The relevant DSDT:
>http://acpi.sourceforge.net/dsdt/view.php?id=742
>
>5. The culprit (insert ob. Linus-is-a-genius git bisect thanks here):
>
> 5559e40e60632ab6927f08cd2a2a3b65c088fc03 is first bad commit
> commit 5559e40e60632ab6927f08cd2a2a3b65c088fc03
> Author: Bob Moore <robert.moore@intel.com>
> Date:   Tue Jan 23 15:49:27 2007 +0300
>
>    ACPICA: Disable all wake GPEs after first one recieved
>
>    Change for GPE support: when a wake GPE is
>    received, now all wake GPEs are immediately disabled to
>    prevent the waking GPE from firing again, and to prevent
>    other wake GPEs from interrupting the wake process.
>
>    Signed-off-by: Alexey Starikovskiy
<alexey.y.starikovskiy@intel.com>
>    Signed-off-by: Len Brown <len.brown@intel.com>
>
>I will try to run with the above commit reverted, so as to continue
playing
>with the acpi-test tree.
>
>If there is anything I can contribute to help shape up the above into
>something that is not annoying for ThinkPad T43 onwers, just tell me
what,
>and I'll see what I can do.
>
>The bug is reproducible at will.
>
>--
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

On Mon, 05 Feb 2007, Starikovskiy, Alexey Y wrote:
> I cannot reproduce your problem with T43 here on linux-acpi-test with
> defconfig (relevant ACPI modules were tried both dynamic and static).
> Resume time is about 4-6 seconds, not 20-40 as you mention.

Never tried a thinkpad in defconfig mode.  Will do.

> Could you please send your .config and try defconfig on your machine?
> 
> BTW, my T43 use AHCI mode of SATA controller, if it matters...

Mine is stuck in legacy mode, so we are using different drivers (ata_piix in
my case).  Which BIOS and firmware you got?  What is your machine type?  I
am very interested in a way to get my T43 into AHCI mode...

Mine is a ThinkPad T43 2687-DDU, BIOS is 1.29, EC firmware is 1.06.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

RE: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Starikovskiy, Alexey Y]

T43 2668-NG2 BIOS 1.23 EC 1.03


>-----Original Message-----
>From: Henrique de Moraes Holschuh [mailto:hmh@hmh.eng.br]
>Sent: Tuesday, February 06, 2007 2:59 AM
>To: Starikovskiy, Alexey Y
>Cc: linux-acpi@vger.kernel.org; Brown, Len
>Subject: Re: Bad libata resume behaviour due to ACPICA change (in acpi-
>test)
>
>On Mon, 05 Feb 2007, Starikovskiy, Alexey Y wrote:
>> I cannot reproduce your problem with T43 here on linux-acpi-test with
>> defconfig (relevant ACPI modules were tried both dynamic and static).
>> Resume time is about 4-6 seconds, not 20-40 as you mention.
>
>Never tried a thinkpad in defconfig mode.  Will do.
>
>> Could you please send your .config and try defconfig on your machine?
>>
>> BTW, my T43 use AHCI mode of SATA controller, if it matters...
>
>Mine is stuck in legacy mode, so we are using different drivers
(ata_piix
>in
>my case).  Which BIOS and firmware you got?  What is your machine type?
I
>am very interested in a way to get my T43 into AHCI mode...
>
>Mine is a ThinkPad T43 2687-DDU, BIOS is 1.29, EC firmware is 1.06.
>
>--
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh

T43 BIOS and AHCI

[Henrique de Moraes Holschuh]

On Tue, 06 Feb 2007, Starikovskiy, Alexey Y wrote:
> T43 2668-NG2 BIOS 1.23 EC 1.03

We use the same BIOS (TP-1Y), but you are using a very old version.  A lot
might have changed since then, including AHCI support going away.  I don't
think I ever run a 1.23 bios on my machine...

And I know for a fact that the ACPI DSDT tables *did* change since 1.23, as
I have been looking at the DSDT changes in later versions of the BIOS as I
upgrade them.

Anyway, do you have anything in the BIOS that allows you to select AHCI
mode, or did Linux just load AHCI and skipped merrily along?  Here, AHCI
won't load with an error (supposedly because the ICH is already set to
non-AHCI mode).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: T43 BIOS and AHCI

[Alexey Starikovskiy]

Henrique de Moraes Holschuh wrote:
> On Tue, 06 Feb 2007, Starikovskiy, Alexey Y wrote:
>   
>> T43 2668-NG2 BIOS 1.23 EC 1.03
>>     
>
>   
I updated to 1.29/1.06 and still have 6 seconds resume time...
> We use the same BIOS (TP-1Y), but you are using a very old version.  A lot
> might have changed since then, including AHCI support going away.  I don't
> think I ever run a 1.23 bios on my machine...
>
> And I know for a fact that the ACPI DSDT tables *did* change since 1.23, as
> I have been looking at the DSDT changes in later versions of the BIOS as I
> upgrade them.
>
> Anyway, do you have anything in the BIOS that allows you to select AHCI
> mode, or did Linux just load AHCI and skipped merrily along?  Here, AHCI
> won't load with an error (supposedly because the ICH is already set to
> non-AHCI mode).
>   
Sorry, my mistake here ahci only says that it failed to find device, and 
then all output comes from pii_ata...

Regards,
    Alex.

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

On Mon, 05 Feb 2007, Starikovskiy, Alexey Y wrote:
> I cannot reproduce your problem with T43 here on linux-acpi-test with
> defconfig (relevant ACPI modules were tried both dynamic and static).
> Resume time is about 4-6 seconds, not 20-40 as you mention.
> Could you please send your .config and try defconfig on your machine?

Sorry for the delay on doing the tests.  2.6.20+acpi-test defconfig does NOT
do ACPI S3, so I had to use defconfig with SMP turned off (that was the only
change).  Are you sure you tried linux-acpi-test in 2.6.20 defconfig without
any changes?

gcc is Debian 3.4.6-5.  I am avoiding 4.1.1 because of the reports of it
miscompiling the kernel sometimes.

The bug changed behaviour a little in defconfig.  Now, I get the "Restarting
tasks ... done" right away after the line that used to hang (SCSI device
sda: write cache...", and THEN it hangs for about 20s.

In my default T43 kernel, I get "Restarting tasks ... done" *before* the
(SCSI device sda: write cache..." line.

So the hang is still there, it is still 100% reproducible here, but I am not
sure it has much to do with libata.  It might have something to do with
whatever happens after "Restarting tasks ... done", and libata resume just
happens to be running in another thread at that time and outputs its stuff
through printk.

Any ideas on how to debug this further?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Alexey Starikovskiy]

first thing to check is timing of acpi_hw_disable_all_gpes() at 
drivers/acpi/events/evgpe.c:647,
printk() around it should be good.


Henrique de Moraes Holschuh wrote:
> On Mon, 05 Feb 2007, Starikovskiy, Alexey Y wrote:
>   
>> I cannot reproduce your problem with T43 here on linux-acpi-test with
>> defconfig (relevant ACPI modules were tried both dynamic and static).
>> Resume time is about 4-6 seconds, not 20-40 as you mention.
>> Could you please send your .config and try defconfig on your machine?
>>     
>
> Sorry for the delay on doing the tests.  2.6.20+acpi-test defconfig does NOT
> do ACPI S3, so I had to use defconfig with SMP turned off (that was the only
> change).  Are you sure you tried linux-acpi-test in 2.6.20 defconfig without
> any changes?
>
> gcc is Debian 3.4.6-5.  I am avoiding 4.1.1 because of the reports of it
> miscompiling the kernel sometimes.
>
> The bug changed behaviour a little in defconfig.  Now, I get the "Restarting
> tasks ... done" right away after the line that used to hang (SCSI device
> sda: write cache...", and THEN it hangs for about 20s.
>
> In my default T43 kernel, I get "Restarting tasks ... done" *before* the
> (SCSI device sda: write cache..." line.
>
> So the hang is still there, it is still 100% reproducible here, but I am not
> sure it has much to do with libata.  It might have something to do with
> whatever happens after "Restarting tasks ... done", and libata resume just
> happens to be running in another thread at that time and outputs its stuff
> through printk.
>
> Any ideas on how to debug this further?
>
>   

RE: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Starikovskiy, Alexey Y]

Henrique,

Please also try to set acpi_gbl_system_awake_and_running to true in the
same place, if you find that disable_all_gpes() is called not once...

Thanks,
	Alex.

>-----Original Message-----
>From: Alexey Starikovskiy
[mailto:alexey.y.starikovskiy@linux.intel.com]
>Sent: Thursday, February 08, 2007 8:51 PM
>To: Henrique de Moraes Holschuh
>Cc: Starikovskiy, Alexey Y; linux-acpi@vger.kernel.org; Brown, Len
>Subject: Re: Bad libata resume behaviour due to ACPICA change (in acpi-
>test)
>
>first thing to check is timing of acpi_hw_disable_all_gpes() at
>drivers/acpi/events/evgpe.c:647,
>printk() around it should be good.
>
>
>Henrique de Moraes Holschuh wrote:
>> On Mon, 05 Feb 2007, Starikovskiy, Alexey Y wrote:
>>
>>> I cannot reproduce your problem with T43 here on linux-acpi-test
with
>>> defconfig (relevant ACPI modules were tried both dynamic and
static).
>>> Resume time is about 4-6 seconds, not 20-40 as you mention.
>>> Could you please send your .config and try defconfig on your
machine?
>>>
>>
>> Sorry for the delay on doing the tests.  2.6.20+acpi-test defconfig
does
>NOT
>> do ACPI S3, so I had to use defconfig with SMP turned off (that was
the
>only
>> change).  Are you sure you tried linux-acpi-test in 2.6.20 defconfig
>without
>> any changes?
>>
>> gcc is Debian 3.4.6-5.  I am avoiding 4.1.1 because of the reports of
it
>> miscompiling the kernel sometimes.
>>
>> The bug changed behaviour a little in defconfig.  Now, I get the
>"Restarting
>> tasks ... done" right away after the line that used to hang (SCSI
device
>> sda: write cache...", and THEN it hangs for about 20s.
>>
>> In my default T43 kernel, I get "Restarting tasks ... done" *before*
the
>> (SCSI device sda: write cache..." line.
>>
>> So the hang is still there, it is still 100% reproducible here, but I
am
>not
>> sure it has much to do with libata.  It might have something to do
with
>> whatever happens after "Restarting tasks ... done", and libata resume
>just
>> happens to be running in another thread at that time and outputs its
>stuff
>> through printk.
>>
>> Any ideas on how to debug this further?
>>
>>

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

On Thu, 08 Feb 2007, Starikovskiy, Alexey Y wrote:
> Please also try to set acpi_gbl_system_awake_and_running to true in the
> same place, if you find that disable_all_gpes() is called not once...

Here's what happens if I "acpi_gbl_system_awake_and_running = true;" right
after the call to acpi_hw_disable_all_gpes();

It stops the annoying the delay all right, as it won't loop anymore:

Feb  9 00:50:00 thorin kernel: Stopping tasks ... done.
Feb  9 00:50:00 thorin kernel: Suspending console(s)
Feb  9 00:50:00 thorin kernel: pnp: Device 00:09 disabled.
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1e.2 disabled
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.7 disabled
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.3 disabled
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.2 disabled
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.1 disabled
Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.0 disabled
Feb  9 00:50:00 thorin kernel:  hwsleep-0315 [03] enter_sleep_state     : Entering sleep state [S3]
Feb  9 00:50:00 thorin kernel: Intel machine check architecture supported.
Feb  9 00:50:00 thorin kernel: Intel machine check reporting enabled on CPU#0.
Feb  9 00:50:00 thorin kernel: Back to C!
Feb  9 00:50:00 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:50:00 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:01.0 at offset 7 (was 20002020, writing 2020)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:01.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:01.0 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1c.0 at offset 7 (was f0, writing 200000f0)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.0[A] -> GSI 20 (level, low) -> IRQ 17
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.0 to 64
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.2[C] -> GSI 22 (level, low) -> IRQ 18
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.2 to 64
Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.0 (0000 -> 0001)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.0 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset f (was 100, writing 10b)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset 8 (was 1, writing 1801)
Feb  9 00:50:00 thorin kernel: usb usb2: root hub lost power or was reset
Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.1 (0000 -> 0001)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.1[B] -> GSI 17 (level, low) -> IRQ 20
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.1 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset f (was 200, writing 20b)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset 8 (was 1, writing 1821)
Feb  9 00:50:00 thorin kernel: usb usb3: root hub lost power or was reset
Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.2 (0000 -> 0001)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.2[C] -> GSI 18 (level, low) -> IRQ 21
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.2 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset f (was 300, writing 30b)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset 8 (was 1, writing 1841)
Feb  9 00:50:00 thorin kernel: usb usb4: root hub lost power or was reset
Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.3 (0000 -> 0001)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.3[D] -> GSI 19 (level, low) -> IRQ 19
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.3 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset f (was 400, writing 40b)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset 8 (was 1, writing 1861)
Feb  9 00:50:00 thorin kernel: usb usb5: root hub lost power or was reset
Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.7 (0000 -> 0002)
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.7[D] -> GSI 19 (level, low) -> IRQ 19
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.7 to 64
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset f (was 400, writing 40b)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 4 (was 0, writing b0000000)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 1 (was 2900006, writing 2900106)
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1e.0 to 64
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1e.2[A] -> GSI 22 (level, low) -> IRQ 18
Feb  9 00:50:00 thorin kernel: i810_audio: Primary codec has ID 0
Feb  9 00:50:00 thorin kernel: ac97_codec: AC97 Audio codec, id: ADS116 (Analog Devices AD1981B)
Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device 0000:00:1f.2 at offset 1 (was 2b00005, writing 2b80005)
Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device 0000:00:1f.2 to 64
Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:0b:00.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:50:00 thorin kernel: pnp: Device 00:07 does not support activation.
Feb  9 00:50:00 thorin kernel: pnp: Device 00:08 does not support activation.
Feb  9 00:50:00 thorin kernel: pnp: Device 00:09 activated.
Feb  9 00:50:00 thorin kernel: ata1.00: configured for UDMA/100
Feb  9 00:50:00 thorin kernel: SCSI device sda: 117210240 512-byte hdwr sectors (60012 MB)
Feb  9 00:50:00 thorin kernel: sda: Write Protect is off
Feb  9 00:50:00 thorin kernel: sda: Mode Sense: 00 3a 00 00
Feb  9 00:50:00 thorin kernel: SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Feb  9 00:50:00 thorin kernel: ata2.00: configured for UDMA/33
Feb  9 00:50:00 thorin kernel: Restarting tasks ... done.
Feb  9 00:51:10 thorin kernel: Kernel logging (proc) stopped.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

RE: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Starikovskiy, Alexey Y]

Great, I will send a proper patch.
Thanks,
	Alex.

>-----Original Message-----
>From: Henrique de Moraes Holschuh [mailto:hmh@hmh.eng.br]
>Sent: Friday, February 09, 2007 6:02 AM
>To: Starikovskiy, Alexey Y
>Cc: Alexey Starikovskiy; linux-acpi@vger.kernel.org; Brown, Len
>Subject: Re: Bad libata resume behaviour due to ACPICA change (in acpi-
>test)
>
>On Thu, 08 Feb 2007, Starikovskiy, Alexey Y wrote:
>> Please also try to set acpi_gbl_system_awake_and_running to true in
the
>> same place, if you find that disable_all_gpes() is called not once...
>
>Here's what happens if I "acpi_gbl_system_awake_and_running = true;"
right
>after the call to acpi_hw_disable_all_gpes();
>
>It stops the annoying the delay all right, as it won't loop anymore:
>
>Feb  9 00:50:00 thorin kernel: Stopping tasks ... done.
>Feb  9 00:50:00 thorin kernel: Suspending console(s)
>Feb  9 00:50:00 thorin kernel: pnp: Device 00:09 disabled.
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1e.2
>disabled
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1d.7
>disabled
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1d.3
>disabled
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1d.2
>disabled
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1d.1
>disabled
>Feb  9 00:50:00 thorin kernel: ACPI: PCI interrupt for device
0000:00:1d.0
>disabled
>Feb  9 00:50:00 thorin kernel:  hwsleep-0315 [03] enter_sleep_state
:
>Entering sleep state [S3]
>Feb  9 00:50:00 thorin kernel: Intel machine check architecture
supported.
>Feb  9 00:50:00 thorin kernel: Intel machine check reporting enabled on
>CPU#0.
>Feb  9 00:50:00 thorin kernel: Back to C!
>Feb  9 00:50:00 thorin kernel: ACPI-DEBUG: before
>acpi_hw_disable_all_gpes()
>Feb  9 00:50:00 thorin kernel: ACPI-DEBUG: after
acpi_hw_disable_all_gpes()
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:01.0 at offset 7 (was 20002020, writing 2020)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:01.0[A] ->
GSI
>16 (level, low) -> IRQ 16
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:01.0 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1c.0 at offset 7 (was f0, writing 200000f0)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.0[A] ->
GSI
>20 (level, low) -> IRQ 17
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1c.0 to 64
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.2[C] ->
GSI
>22 (level, low) -> IRQ 18
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1c.2 to 64
>Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.0 (0000
->
>0001)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.0[A] ->
GSI
>16 (level, low) -> IRQ 16
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1d.0 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.0 at offset f (was 100, writing 10b)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.0 at offset 8 (was 1, writing 1801)
>Feb  9 00:50:00 thorin kernel: usb usb2: root hub lost power or was
reset
>Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.1 (0000
->
>0001)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.1[B] ->
GSI
>17 (level, low) -> IRQ 20
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1d.1 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.1 at offset f (was 200, writing 20b)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.1 at offset 8 (was 1, writing 1821)
>Feb  9 00:50:00 thorin kernel: usb usb3: root hub lost power or was
reset
>Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.2 (0000
->
>0001)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.2[C] ->
GSI
>18 (level, low) -> IRQ 21
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1d.2 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.2 at offset f (was 300, writing 30b)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.2 at offset 8 (was 1, writing 1841)
>Feb  9 00:50:00 thorin kernel: usb usb4: root hub lost power or was
reset
>Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.3 (0000
->
>0001)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.3[D] ->
GSI
>19 (level, low) -> IRQ 19
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1d.3 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.3 at offset f (was 400, writing 40b)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.3 at offset 8 (was 1, writing 1861)
>Feb  9 00:50:00 thorin kernel: usb usb5: root hub lost power or was
reset
>Feb  9 00:50:00 thorin kernel: PCI: Enabling device 0000:00:1d.7 (0000
->
>0002)
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.7[D] ->
GSI
>19 (level, low) -> IRQ 19
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1d.7 to 64
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.7 at offset f (was 400, writing 40b)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.7 at offset 4 (was 0, writing b0000000)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1d.7 at offset 1 (was 2900006, writing 2900106)
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1e.0 to 64
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:00:1e.2[A] ->
GSI
>22 (level, low) -> IRQ 18
>Feb  9 00:50:00 thorin kernel: i810_audio: Primary codec has ID 0
>Feb  9 00:50:00 thorin kernel: ac97_codec: AC97 Audio codec, id: ADS116
>(Analog Devices AD1981B)
>Feb  9 00:50:00 thorin kernel: PM: Writing back config space on device
>0000:00:1f.2 at offset 1 (was 2b00005, writing 2b80005)
>Feb  9 00:50:00 thorin kernel: PCI: Setting latency timer of device
>0000:00:1f.2 to 64
>Feb  9 00:50:00 thorin kernel: ACPI: PCI Interrupt 0000:0b:00.0[A] ->
GSI
>16 (level, low) -> IRQ 16
>Feb  9 00:50:00 thorin kernel: pnp: Device 00:07 does not support
>activation.
>Feb  9 00:50:00 thorin kernel: pnp: Device 00:08 does not support
>activation.
>Feb  9 00:50:00 thorin kernel: pnp: Device 00:09 activated.
>Feb  9 00:50:00 thorin kernel: ata1.00: configured for UDMA/100
>Feb  9 00:50:00 thorin kernel: SCSI device sda: 117210240 512-byte hdwr
>sectors (60012 MB)
>Feb  9 00:50:00 thorin kernel: sda: Write Protect is off
>Feb  9 00:50:00 thorin kernel: sda: Mode Sense: 00 3a 00 00
>Feb  9 00:50:00 thorin kernel: SCSI device sda: write cache: enabled,
read
>cache: enabled, doesn't support DPO or FUA
>Feb  9 00:50:00 thorin kernel: ata2.00: configured for UDMA/33
>Feb  9 00:50:00 thorin kernel: Restarting tasks ... done.
>Feb  9 00:51:10 thorin kernel: Kernel logging (proc) stopped.
>
>--
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

On Thu, 08 Feb 2007, Alexey Starikovskiy wrote:
> first thing to check is timing of acpi_hw_disable_all_gpes() at 
> drivers/acpi/events/evgpe.c:647,
> printk() around it should be good.

Done, and the thing is looping like heck, and wasting time:

Feb  9 00:23:44 thorin kernel: Stopping tasks ... done.
Feb  9 00:23:44 thorin kernel: Suspending console(s)
Feb  9 00:23:44 thorin kernel: pnp: Device 00:09 disabled.
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1e.2 disabled
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.7 disabled
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.3 disabled
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.2 disabled
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.1 disabled
Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.0 disabled
Feb  9 00:23:44 thorin kernel:  hwsleep-0315 [03] enter_sleep_state     : Entering sleep state [S3]
Feb  9 00:23:44 thorin kernel: Intel machine check architecture supported.
Feb  9 00:23:44 thorin kernel: Intel machine check reporting enabled on CPU#0.
Feb  9 00:23:44 thorin kernel: Back to C!
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:01.0 at offset 7 (was 20002020, writing 2020)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:01.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:01.0 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1c.0 at offset 7 (was f0, writing 200000f0)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.0[A] -> GSI 20 (level, low) -> IRQ 17
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.0 to 64
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.2[C] -> GSI 22 (level, low) -> IRQ 18
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.2 to 64
Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.0 (0000 -> 0001)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.0 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset f (was 100, writing 10b)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset 8 (was 1, writing 1801)
Feb  9 00:23:44 thorin kernel: usb usb2: root hub lost power or was reset
Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.1 (0000 -> 0001)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.1[B] -> GSI 17 (level, low) -> IRQ 20
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.1 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset f (was 200, writing 20b)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset 8 (was 1, writing 1821)
Feb  9 00:23:44 thorin kernel: usb usb3: root hub lost power or was reset
Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.2 (0000 -> 0001)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.2[C] -> GSI 18 (level, low) -> IRQ 21
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.2 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset f (was 300, writing 30b)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset 8 (was 1, writing 1841)
Feb  9 00:23:44 thorin kernel: usb usb4: root hub lost power or was reset
Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.3 (0000 -> 0001)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.3[D] -> GSI 19 (level, low) -> IRQ 19
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.3 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset f (was 400, writing 40b)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset 8 (was 1, writing 1861)
Feb  9 00:23:44 thorin kernel: usb usb5: root hub lost power or was reset
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.7 (0000 -> 0002)
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.7[D] -> GSI 19 (level, low) -> IRQ 19
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.7 to 64
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset f (was 400, writing 40b)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 4 (was 0, writing b0000000)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 1 (was 2900006, writing 2900106)
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1e.0 to 64
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1e.2[A] -> GSI 22 (level, low) -> IRQ 18
Feb  9 00:23:44 thorin kernel: i810_audio: Primary codec has ID 0
Feb  9 00:23:44 thorin kernel: ac97_codec: AC97 Audio codec, id: ADS116 (Analog Devices AD1981B)
Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1f.2 at offset 1 (was 2b00005, writing 2b80005)
Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1f.2 to 64
Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:0b:00.0[A] -> GSI 16 (level, low) -> IRQ 16
Feb  9 00:23:44 thorin kernel: pnp: Device 00:07 does not support activation.
Feb  9 00:23:44 thorin kernel: pnp: Device 00:08 does not support activation.
Feb  9 00:23:44 thorin kernel: pnp: Device 00:09 activated.
Feb  9 00:23:44 thorin kernel: ata2.00: configured for UDMA/33
Feb  9 00:23:44 thorin kernel: ata1.00: configured for UDMA/100
Feb  9 00:23:44 thorin kernel: SCSI device sda: 117210240 512-byte hdwr sectors (60012 MB)
Feb  9 00:23:44 thorin kernel: sda: Write Protect is off
Feb  9 00:23:44 thorin kernel: sda: Mode Sense: 00 3a 00 00
Feb  9 00:23:44 thorin kernel: SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Feb  9 00:23:44 thorin kernel: Restarting tasks ... done.
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:45 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:45 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:46 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:46 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:47 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:47 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:48 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:48 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:50 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:50 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:51 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:51 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:54 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:54 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:56 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:56 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:58 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:58 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:23:59 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:23:59 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:24:01 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
Feb  9 00:24:01 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
Feb  9 00:24:24 thorin kernel: Kernel logging (proc) stopped.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Alexey Starikovskiy]

[-- Attachment #1: Type: text/plain, Size: 11692 bytes --]

Here is the patch

Regards,
    Alex.

Henrique de Moraes Holschuh wrote:
> On Thu, 08 Feb 2007, Alexey Starikovskiy wrote:
>   
>> first thing to check is timing of acpi_hw_disable_all_gpes() at 
>> drivers/acpi/events/evgpe.c:647,
>> printk() around it should be good.
>>     
>
> Done, and the thing is looping like heck, and wasting time:
>
> Feb  9 00:23:44 thorin kernel: Stopping tasks ... done.
> Feb  9 00:23:44 thorin kernel: Suspending console(s)
> Feb  9 00:23:44 thorin kernel: pnp: Device 00:09 disabled.
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1e.2 disabled
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.7 disabled
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.3 disabled
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.2 disabled
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.1 disabled
> Feb  9 00:23:44 thorin kernel: ACPI: PCI interrupt for device 0000:00:1d.0 disabled
> Feb  9 00:23:44 thorin kernel:  hwsleep-0315 [03] enter_sleep_state     : Entering sleep state [S3]
> Feb  9 00:23:44 thorin kernel: Intel machine check architecture supported.
> Feb  9 00:23:44 thorin kernel: Intel machine check reporting enabled on CPU#0.
> Feb  9 00:23:44 thorin kernel: Back to C!
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:01.0 at offset 7 (was 20002020, writing 2020)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:01.0[A] -> GSI 16 (level, low) -> IRQ 16
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:01.0 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1c.0 at offset 7 (was f0, writing 200000f0)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.0[A] -> GSI 20 (level, low) -> IRQ 17
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.0 to 64
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1c.2[C] -> GSI 22 (level, low) -> IRQ 18
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1c.2 to 64
> Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.0 (0000 -> 0001)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.0[A] -> GSI 16 (level, low) -> IRQ 16
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.0 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset f (was 100, writing 10b)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.0 at offset 8 (was 1, writing 1801)
> Feb  9 00:23:44 thorin kernel: usb usb2: root hub lost power or was reset
> Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.1 (0000 -> 0001)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.1[B] -> GSI 17 (level, low) -> IRQ 20
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.1 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset f (was 200, writing 20b)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.1 at offset 8 (was 1, writing 1821)
> Feb  9 00:23:44 thorin kernel: usb usb3: root hub lost power or was reset
> Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.2 (0000 -> 0001)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.2[C] -> GSI 18 (level, low) -> IRQ 21
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.2 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset f (was 300, writing 30b)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.2 at offset 8 (was 1, writing 1841)
> Feb  9 00:23:44 thorin kernel: usb usb4: root hub lost power or was reset
> Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.3 (0000 -> 0001)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.3[D] -> GSI 19 (level, low) -> IRQ 19
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.3 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset f (was 400, writing 40b)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.3 at offset 8 (was 1, writing 1861)
> Feb  9 00:23:44 thorin kernel: usb usb5: root hub lost power or was reset
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: PCI: Enabling device 0000:00:1d.7 (0000 -> 0002)
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1d.7[D] -> GSI 19 (level, low) -> IRQ 19
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1d.7 to 64
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset f (was 400, writing 40b)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 4 (was 0, writing b0000000)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1d.7 at offset 1 (was 2900006, writing 2900106)
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1e.0 to 64
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:00:1e.2[A] -> GSI 22 (level, low) -> IRQ 18
> Feb  9 00:23:44 thorin kernel: i810_audio: Primary codec has ID 0
> Feb  9 00:23:44 thorin kernel: ac97_codec: AC97 Audio codec, id: ADS116 (Analog Devices AD1981B)
> Feb  9 00:23:44 thorin kernel: PM: Writing back config space on device 0000:00:1f.2 at offset 1 (was 2b00005, writing 2b80005)
> Feb  9 00:23:44 thorin kernel: PCI: Setting latency timer of device 0000:00:1f.2 to 64
> Feb  9 00:23:44 thorin kernel: ACPI: PCI Interrupt 0000:0b:00.0[A] -> GSI 16 (level, low) -> IRQ 16
> Feb  9 00:23:44 thorin kernel: pnp: Device 00:07 does not support activation.
> Feb  9 00:23:44 thorin kernel: pnp: Device 00:08 does not support activation.
> Feb  9 00:23:44 thorin kernel: pnp: Device 00:09 activated.
> Feb  9 00:23:44 thorin kernel: ata2.00: configured for UDMA/33
> Feb  9 00:23:44 thorin kernel: ata1.00: configured for UDMA/100
> Feb  9 00:23:44 thorin kernel: SCSI device sda: 117210240 512-byte hdwr sectors (60012 MB)
> Feb  9 00:23:44 thorin kernel: sda: Write Protect is off
> Feb  9 00:23:44 thorin kernel: sda: Mode Sense: 00 3a 00 00
> Feb  9 00:23:44 thorin kernel: SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> Feb  9 00:23:44 thorin kernel: Restarting tasks ... done.
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:44 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:45 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:45 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:46 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:46 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:47 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:47 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:48 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:48 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:49 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:50 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:50 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:51 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:51 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:52 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:53 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:54 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:54 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:55 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:56 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:56 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:57 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:58 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:58 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:23:59 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:23:59 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:24:00 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:24:01 thorin kernel: ACPI-DEBUG: before acpi_hw_disable_all_gpes()
> Feb  9 00:24:01 thorin kernel: ACPI-DEBUG: after acpi_hw_disable_all_gpes()
> Feb  9 00:24:24 thorin kernel: Kernel logging (proc) stopped.
>
>   


[-- Attachment #2: fix-disable_all_wake_gpes.patch --]
[-- Type: text/plain, Size: 656 bytes --]

Disable wake GPEs only once.

From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>


---

 drivers/acpi/events/evgpe.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c
index dfac3ec..263a001 100644
--- a/drivers/acpi/events/evgpe.c
+++ b/drivers/acpi/events/evgpe.c
@@ -644,6 +644,7 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
 		 * 1) We must disable this particular wake GPE so it won't fire again
 		 * 2) We want to disable all wake GPEs, since we are now awake
 		 */
+		acpi_gbl_system_awake_and_running = TRUE;
 		(void)acpi_hw_disable_all_gpes();
 	}
 

Re: Bad libata resume behaviour due to ACPICA change (in acpi-test)

[Henrique de Moraes Holschuh]

> Disable wake GPEs only once.
> 
> From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
> 
> ---
> 
>  drivers/acpi/events/evgpe.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c
> index dfac3ec..263a001 100644
> --- a/drivers/acpi/events/evgpe.c
> +++ b/drivers/acpi/events/evgpe.c
> @@ -644,6 +644,7 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
>  		 * 1) We must disable this particular wake GPE so it won't fire again
>  		 * 2) We want to disable all wake GPEs, since we are now awake
>  		 */
> +		acpi_gbl_system_awake_and_running = TRUE;
>  		(void)acpi_hw_disable_all_gpes();
>  	}

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

The above patch fixes the issue on the T43.  Tested with patch on top of
acpi-test a19357b3 in defconfig with SMP disabled.

Thanks, Alexey!

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh