linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ray Lee <ray-lk@madrabbit.org>
To: Len Brown <lenb@kernel.org>
Cc: Adrian Bunk <bunk@stusta.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>,
	Vladimir Lebedev <vladimir.p.lebedev@intel.com>,
	linux-acpi@vger.kernel.org
Subject: ACPI: resolve GPE immediate wakeup regression
Date: Mon, 12 Mar 2007 12:59:51 -0400	[thread overview]
Message-ID: <45F58707.1@madrabbit.org> (raw)
In-Reply-To: <200703121142.46705.lenb@kernel.org>

Len Brown wrote:
> On Saturday 10 March 2007 01:18, Ray Lee wrote:
>> Ray Lee wrote:
>>> In 2.6.21-rc1,2,3, my laptop will fully suspend to ram, but then
>>> *immediately* resumes back from suspension. (It resumes just fine, as well.)
>> [...]
>>> HP/Compaq NX6125 system, AMD64, dmesg attached.
> 
> I'd rather not break the Acer, if possible.
> 
> Ray, Please test the incremental patch below.

Tested and Alexey's patch (copied below) fixes the problem. I added a
signed-off-by just in case; feel free to yank it if inappropriate.
Regardless, please apply.

Thanks Len, Alexey.

Ray
---
Subject: ACPI: resolve GPE immediate wakeup regression
From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>

Removing disabling of GPEs from enter_sleep function causes regression
on nx6125.
Doing disable_all_gpes both in prepare to sleep and in enter sleep
resolves regression,
while still fixes Acer notebooks.

Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Ray Lee <ray-lk@madrabbit.org>
---

 drivers/acpi/hardware/hwsleep.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/hardware/hwsleep.c
b/drivers/acpi/hardware/hwsleep.c
index 8fa9312..c84b1fa 100644
--- a/drivers/acpi/hardware/hwsleep.c
+++ b/drivers/acpi/hardware/hwsleep.c
@@ -300,6 +300,11 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8
sleep_state)
 	/*
 	 * 2) Enable all wakeup GPEs
 	 */
+	status = acpi_hw_disable_all_gpes();
+	if (ACPI_FAILURE(status)) {
+		return_ACPI_STATUS(status);
+	}
+
 	acpi_gbl_system_awake_and_running = FALSE;

 	status = acpi_hw_enable_all_wakeup_gpes();



  reply	other threads:[~2007-03-12 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45F0C018.2020409@madrabbit.org>
     [not found] ` <45F24DCE.8060902@madrabbit.org>
2007-03-12 15:42   ` Odd suspend regression in 2.6.21-rc[123] Len Brown
2007-03-12 16:59     ` Ray Lee [this message]
2007-03-12 17:06       ` ACPI: resolve GPE immediate wakeup regression Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F58707.1@madrabbit.org \
    --to=ray-lk@madrabbit.org \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=bunk@stusta.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --cc=vladimir.p.lebedev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).