public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>, Len Brown <len.brown@intel.com>
Subject: [PATCH 01/19] ACPI video: dmi check for broken _BQC on Acer Aspire 5720
Date: Sat, 16 May 2009 02:01:58 -0400	[thread overview]
Message-ID: <45cb50e646d1560eff01c5ad0f0df3c7fd6148dd.1242453625.git.len.brown@intel.com> (raw)
In-Reply-To: <1242453736-20763-1-git-send-email-lenb@kernel.org>

From: Zhang Rui <rui.zhang@intel.com>

On Acer Aspire 5720, _BQC always returns a value 9 smaller than
the actual brightness level.  Add dmi quirk for this laptop.

http://bugzilla.kernel.org/show_bug.cgi?id=13121

Tested-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/video.c |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index cd4fb75..7e8ee49 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -538,6 +538,33 @@ acpi_video_device_lcd_set_level(struct acpi_video_device *device, int level)
 	return -EINVAL;
 }
 
+/*
+ * For some buggy _BQC methods, we need to add a constant value to
+ * the _BQC return value to get the actual current brightness level
+ */
+
+static int bqc_offset_aml_bug_workaround;
+static int __init video_set_bqc_offset(const struct dmi_system_id *d)
+{
+	bqc_offset_aml_bug_workaround = 9;
+	return 0;
+}
+
+static struct dmi_system_id video_dmi_table[] __initdata = {
+	/*
+	 * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
+	 */
+	{
+	 .callback = video_set_bqc_offset,
+	 .ident = "Acer Aspire 5720",
+	 .matches = {
+		DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5720"),
+		},
+	},
+	{}
+};
+
 static int
 acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
 					unsigned long long *level)
@@ -557,6 +584,7 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
 				*level = device->brightness->levels[*level + 2];
 
 			}
+			*level += bqc_offset_aml_bug_workaround;
 			device->brightness->curr = *level;
 			return 0;
 		} else {
@@ -2287,6 +2315,8 @@ EXPORT_SYMBOL(acpi_video_register);
 
 static int __init acpi_video_init(void)
 {
+	dmi_check_system(video_dmi_table);
+
 	if (intel_opregion_present())
 		return 0;
 
-- 
1.6.0.6


  reply	other threads:[~2009-05-16  6:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  6:01 ACPI & driver patches for 2.6.30-rc5 Len Brown
2009-05-16  6:01 ` Len Brown [this message]
2009-05-16  6:01   ` [PATCH 02/19] ACPICA: use acpi.* modparam namespace Len Brown
2009-05-16  6:02   ` [PATCH 03/19] ACPI: video: DMI workaround another broken Acer BIOS enabling display brightness Len Brown
2009-05-16  6:02   ` [PATCH 04/19] ACPI: power: update error message Len Brown
2009-05-16  6:02   ` [PATCH 05/19] ACPI: suspend: don't let device _PS3 failure prevent suspend Len Brown
2009-05-16  6:02   ` [PATCH 06/19] eeepc-laptop: fix wlan rfkill state change during init Len Brown
2009-05-16  6:02   ` [PATCH 07/19] eeepc-laptop: report brightness control events via the input layer Len Brown
2009-05-16  6:02   ` [PATCH 08/19] eeepc-laptop: Work around rfkill firmware bug Len Brown
2009-05-16  6:02   ` [PATCH 09/19] eeepc-laptop: support for super hybrid engine (SHE) Len Brown
2009-05-24  9:28     ` Alan Jenkins
2009-05-24 17:23       ` Corentin Chary
     [not found]         ` <4A198401.3040003@tuffmail.co.uk>
2009-05-25  8:12           ` Corentin Chary
2009-05-25  9:43             ` Alan Jenkins
2009-05-25  9:59               ` Corentin Chary
2009-05-25 10:07                 ` Alan Jenkins
2009-05-25 11:19                   ` Corentin Chary
2009-05-25 11:51                     ` Alan Jenkins
2009-05-26 10:12                       ` Corentin Chary
2009-05-26 10:15                         ` Alan Jenkins
2009-05-26 17:29                           ` Francesco Lattanzio
2009-05-26 17:43                             ` Alan Jenkins
2009-05-26 18:05                               ` Corentin Chary
2009-05-24 20:24       ` Corentin Chary
2009-05-16  6:02   ` [PATCH 10/19] asus-laptop: fix input keycode Len Brown
2009-05-16  6:02   ` [PATCH 11/19] eeepc-laptop: unregister_rfkill_notifier on failure Len Brown
2009-05-16  6:02   ` [PATCH 12/19] thermal: fix off-by-1 error in trip point trigger condition Len Brown
2009-05-16  6:02   ` [PATCH 13/19] ACPI: resume: re-enable SCI-enable workaround Len Brown
2009-05-16  6:02   ` [PATCH 14/19] ACPI: suspend: restore BM_RLD on resume Len Brown
2009-05-16  6:02   ` [PATCH 15/19] ACPI, i915: build fix Len Brown
2009-05-18  2:49     ` yakui_zhao
2009-05-16  6:02   ` [PATCH 16/19] ACPI processor: introduce module parameter processor.ignore_tpc Len Brown
2009-05-16  6:02   ` [PATCH 17/19] ACPI processor: reset the throttling state once it's invalid Len Brown
2009-05-16  6:02   ` [PATCH 18/19] ACPI: idle: fix init-time TSC check regression Len Brown
2009-05-16  6:02   ` [PATCH 19/19] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45cb50e646d1560eff01c5ad0f0df3c7fd6148dd.1242453625.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox