From: Stephan Berberig <s.berberig@arcor.de>
To: linux-acpi@vger.kernel.org
Subject: ACPI: bay: send envp with uevent - fix
Date: Sat, 09 Jun 2007 11:23:43 +0200 [thread overview]
Message-ID: <466A719F.3010509@arcor.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Hi,
attached a patch to fix the bay uevent so that udev doesn't get confused.
Kristen, could I get your Acked-by?
Best regards,
Stephan
[-- Attachment #2: bay-send-envp-with-uevent-fix.patch --]
[-- Type: text/x-patch, Size: 619 bytes --]
There must not be a new-line character in the uevent. Otherwise, udev gets confused.
Thanks to Kay Sievers for pointing it out.
Signed-off-by: Stephan Berberig <s.berberig@arcor.de>
CC: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
--- a/drivers/acpi/bay.c 2007-06-08 12:01:11.000000000 +0200
+++ b/drivers/acpi/bay.c 2007-06-08 12:02:49.000000000 +0200
@@ -337,7 +337,7 @@
char *envp[] = { event_string, NULL };
bay_dprintk(handle, "Bay event");
- sprintf(event_string, "BAY_EVENT=%d\n", event);
+ sprintf(event_string, "BAY_EVENT=%d", event);
kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp);
}
next reply other threads:[~2007-06-09 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 9:23 Stephan Berberig [this message]
2007-06-22 23:12 ` [PATCH] ACPI: bay: send envp with uevent - fix Stephan Berberig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466A719F.3010509@arcor.de \
--to=s.berberig@arcor.de \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).