ACPI: bay: send envp with uevent - fix

ACPI: bay: send envp with uevent - fix

[Stephan Berberig]

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]

Hi,
attached a patch to fix the bay uevent so that udev doesn't get confused.

Kristen, could I get your Acked-by?

Best regards,
Stephan

[-- Attachment #2: bay-send-envp-with-uevent-fix.patch --]
[-- Type: text/x-patch, Size: 619 bytes --]

There must not be a new-line character in the uevent. Otherwise, udev gets confused.
Thanks to Kay Sievers for pointing it out.

Signed-off-by: Stephan Berberig <s.berberig@arcor.de>
CC: Kristen Carlson Accardi <kristen.c.accardi@intel.com>

--- a/drivers/acpi/bay.c	2007-06-08 12:01:11.000000000 +0200
+++ b/drivers/acpi/bay.c	2007-06-08 12:02:49.000000000 +0200
@@ -337,7 +337,7 @@
 	char *envp[] = { event_string, NULL };
 
 	bay_dprintk(handle, "Bay event");
-	sprintf(event_string, "BAY_EVENT=%d\n", event);
+	sprintf(event_string, "BAY_EVENT=%d", event);
 	kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp);
 }
 

Re: [PATCH] ACPI: bay: send envp with uevent - fix

[Stephan Berberig]

Hi Len,

any news about applying this patch to acpi-test?

I got Kristen's Acked-by by private email.

Best regards,
Stephan

Stephan Berberig schrieb:
> Hi,
> attached a patch to fix the bay uevent so that udev doesn't get confused.
> 
> Kristen, could I get your Acked-by?
> 
> Best regards,
> Stephan
> 
> 
> ------------------------------------------------------------------------
> 
> There must not be a new-line character in the uevent. Otherwise, udev gets confused.
> Thanks to Kay Sievers for pointing it out.
> 
> Signed-off-by: Stephan Berberig <s.berberig@arcor.de>
> CC: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> 
> --- a/drivers/acpi/bay.c	2007-06-08 12:01:11.000000000 +0200
> +++ b/drivers/acpi/bay.c	2007-06-08 12:02:49.000000000 +0200
> @@ -337,7 +337,7 @@
>  	char *envp[] = { event_string, NULL };
>  
>  	bay_dprintk(handle, "Bay event");
> -	sprintf(event_string, "BAY_EVENT=%d\n", event);
> +	sprintf(event_string, "BAY_EVENT=%d", event);
>  	kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp);
>  }
>