From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings
Date: Mon, 06 Jan 2014 21:41:46 +0100 [thread overview]
Message-ID: <4679785.iPCX7mECEL@vostro.rjw.lan> (raw)
In-Reply-To: <CAE9FiQV1tui+nHMFF419dpTOKt_x4US6R=3uPhDvUDJ0zoMrEg@mail.gmail.com>
On Monday, January 06, 2014 11:28:43 AM Yinghai Lu wrote:
> On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote:
> >>
> >> No. It should be before removing all root bus devices.
> >> as they need to access the pci devices during stop ioapic and dmar.
> >>
> >> Also ioapic itself could one one pci device.
> >
> > Well, if we stop drivers first, then stop ioapic/dmar and *then* remove
> > devices, it is possible to rebind a driver to a device after ioapic/dmar has
> > been stopped, which I guess will not lead to anything nice?
>
> Not sure how that could happen.
>
> If it would really happen, we could set dev->match_driver to 0 in pci_stop_dev.
Simply, run "modprobe -r driver && modprobe driver" in a loop and
remove the PCI host bridge the given device is on in parallel to that. Chances
are, you'll see some nice breakage.
Also what happens if somebody uses the "remove" sysfs attribute on a device
needed by ioapic/dmar?
Rafael
next prev parent reply other threads:[~2014-01-06 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 23:20 [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings Rafael J. Wysocki
2013-12-29 3:59 ` Greg Kroah-Hartman
2013-12-30 3:30 ` Yinghai Lu
2013-12-30 12:51 ` Rafael J. Wysocki
2013-12-30 13:15 ` Rafael J. Wysocki
2013-12-31 18:45 ` Yinghai Lu
2013-12-31 21:03 ` Rafael J. Wysocki
2014-01-02 22:47 ` Yinghai Lu
2014-01-03 0:45 ` Rafael J. Wysocki
2014-01-06 19:28 ` Yinghai Lu
2014-01-06 20:41 ` Rafael J. Wysocki [this message]
2014-01-08 23:41 ` Yinghai Lu
2014-01-09 0:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4679785.iPCX7mECEL@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox