From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Knutsson Subject: Re: [PATCH] sonypi: Fix initialization warning Date: Sun, 05 Aug 2007 22:03:10 +0200 Message-ID: <46B62CFE.2010404@student.ltu.se> References: <46B61F70.90005@student.ltu.se> <1186343443.3858.46.camel@fanta4.site> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gepetto.dc.ltu.se ([130.240.42.40]:49473 "EHLO gepetto.dc.ltu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757014AbXHEUDf (ORCPT ); Sun, 5 Aug 2007 16:03:35 -0400 In-Reply-To: <1186343443.3858.46.camel@fanta4.site> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: trenn@suse.de Cc: Ben Collins , "Brown, Len" , linux-acpi@vger.kernel.org, Stelian Pop , linux-kernel@vger.kernel.org Thomas Renninger wrote: > On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote: > >> Signed-off-by: Richard Knutsson >> --- >> Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)): >> drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type >> >> >> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c >> index 73037a4..2dcd519 100644 >> --- a/drivers/char/sonypi.c >> +++ b/drivers/char/sonypi.c >> @@ -1147,10 +1147,15 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type) >> return 0; >> } >> >> +static const struct acpi_device_id sonypi_acpi_driver_ids[] = { >> + {ACPI_PROCESSOR_HID, 0}, >> > This is wrong. You need to take the HID the driver should match for, in > this case: {"SNY6001", 0 }, > Oh bugger, a cut 'n' paste error... Thanks for reviewing it.