From: Alexey Starikovskiy <aystarik@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-acpi@vger.kernel.org, Michael Gerdau <mgerdau@tiscali.de>
Subject: Re: Fw: 2.6.23-rc6-mm1 and acpi
Date: Wed, 19 Sep 2007 14:33:00 +0400 [thread overview]
Message-ID: <46F0FADC.6080805@gmail.com> (raw)
In-Reply-To: <20070919014932.316bb9d6.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Please add following patch.
Thanks,
Alex.
Andrew Morton wrote:
>
> Begin forwarded message:
>
> Date: Tue, 18 Sep 2007 23:42:25 +0200
> From: Michael Gerdau <mgerdau@tiscali.de>
> To: linux-kernel@vger.kernel.org
> Subject: 2.6.23-rc6-mm1 and acpi
>
>
> Hi,
>
> while trying to compile 2.6.23-rc6-mm1 I came across the following
> build error:
>
> mgd@seneca:/usr/src/linux-2.6.23-rc6-mm1> make modules
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> <stdin>:1389:2: warning: #warning syscall revokeat not implemented
> <stdin>:1393:2: warning: #warning syscall frevoke not implemented
> CC [M] drivers/acpi/sbs.o
> drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_show’:
> drivers/acpi/sbs.c:457: error: implicit declaration of function ‘acpi_battery_get_alarm’
> drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_store’:
> drivers/acpi/sbs.c:472: error: implicit declaration of function ‘acpi_battery_set_alarm’
> drivers/acpi/sbs.c: In function ‘acpi_battery_add’:
> drivers/acpi/sbs.c:829: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result
> make[2]: *** [drivers/acpi/sbs.o] Fehler 1
> make[1]: *** [drivers/acpi] Fehler 2
> make: *** [drivers] Fehler 2
>
> Not sure who to CC, which is why I send it to the list alone.
>
> Best,
> Michael
[-- Attachment #2: fix-sbs-add_alarm.patch --]
[-- Type: text/x-patch, Size: 814 bytes --]
ACPI: SBS: fix sbs add alarm patch
From: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---
drivers/acpi/sbs.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index 3f249df..a8fed51 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -395,8 +395,6 @@ static int acpi_battery_get_state(struct acpi_battery *battery)
return result;
}
-#ifdef CONFIG_ACPI_PROCFS
-
static int acpi_battery_get_alarm(struct acpi_battery *battery)
{
return acpi_smbus_read(battery->sbs->hc, SMBUS_READ_WORD,
@@ -433,8 +431,6 @@ static int acpi_battery_set_alarm(struct acpi_battery *battery)
return ret;
}
-#endif
-
static int acpi_ac_get_present(struct acpi_sbs *sbs)
{
int result;
prev parent reply other threads:[~2007-09-19 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 8:49 Fw: 2.6.23-rc6-mm1 and acpi Andrew Morton
2007-09-19 10:33 ` Alexey Starikovskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F0FADC.6080805@gmail.com \
--to=aystarik@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mgerdau@tiscali.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).