Fw: 2.6.23-rc6-mm1 and acpi

Fw: 2.6.23-rc6-mm1 and acpi

[Andrew Morton]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]



Begin forwarded message:

Date: Tue, 18 Sep 2007 23:42:25 +0200
From: Michael Gerdau <mgerdau@tiscali.de>
To: linux-kernel@vger.kernel.org
Subject: 2.6.23-rc6-mm1 and acpi


Hi,

while trying to compile 2.6.23-rc6-mm1 I came across the following
build error:

mgd@seneca:/usr/src/linux-2.6.23-rc6-mm1> make modules
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CALL    scripts/checksyscalls.sh
<stdin>:1389:2: warning: #warning syscall revokeat not implemented
<stdin>:1393:2: warning: #warning syscall frevoke not implemented
  CC [M]  drivers/acpi/sbs.o
drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_show’:
drivers/acpi/sbs.c:457: error: implicit declaration of function ‘acpi_battery_get_alarm’
drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_store’:
drivers/acpi/sbs.c:472: error: implicit declaration of function ‘acpi_battery_set_alarm’
drivers/acpi/sbs.c: In function ‘acpi_battery_add’:
drivers/acpi/sbs.c:829: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result
make[2]: *** [drivers/acpi/sbs.o] Fehler 1
make[1]: *** [drivers/acpi] Fehler 2
make: *** [drivers] Fehler 2

Not sure who to CC, which is why I send it to the list alone.

Best,
Michael
-- 
 Vote against SPAM - see http://www.politik-digital.de/spam/
 Michael Gerdau       email: mgerdau@tiscali.de
 GPG-keys available on request or at public keyserver


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: Fw: 2.6.23-rc6-mm1 and acpi

[Alexey Starikovskiy]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

Please add following patch.

Thanks,
Alex.

Andrew Morton wrote:
> 
> Begin forwarded message:
> 
> Date: Tue, 18 Sep 2007 23:42:25 +0200
> From: Michael Gerdau <mgerdau@tiscali.de>
> To: linux-kernel@vger.kernel.org
> Subject: 2.6.23-rc6-mm1 and acpi
> 
> 
> Hi,
> 
> while trying to compile 2.6.23-rc6-mm1 I came across the following
> build error:
> 
> mgd@seneca:/usr/src/linux-2.6.23-rc6-mm1> make modules
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CALL    scripts/checksyscalls.sh
> <stdin>:1389:2: warning: #warning syscall revokeat not implemented
> <stdin>:1393:2: warning: #warning syscall frevoke not implemented
>   CC [M]  drivers/acpi/sbs.o
> drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_show’:
> drivers/acpi/sbs.c:457: error: implicit declaration of function ‘acpi_battery_get_alarm’
> drivers/acpi/sbs.c: In function ‘acpi_battery_alarm_store’:
> drivers/acpi/sbs.c:472: error: implicit declaration of function ‘acpi_battery_set_alarm’
> drivers/acpi/sbs.c: In function ‘acpi_battery_add’:
> drivers/acpi/sbs.c:829: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result
> make[2]: *** [drivers/acpi/sbs.o] Fehler 1
> make[1]: *** [drivers/acpi] Fehler 2
> make: *** [drivers] Fehler 2
> 
> Not sure who to CC, which is why I send it to the list alone.
> 
> Best,
> Michael


[-- Attachment #2: fix-sbs-add_alarm.patch --]
[-- Type: text/x-patch, Size: 814 bytes --]

ACPI: SBS: fix sbs add alarm patch

From: Alexey Starikovskiy <astarikovskiy@suse.de>

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/sbs.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index 3f249df..a8fed51 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -395,8 +395,6 @@ static int acpi_battery_get_state(struct acpi_battery *battery)
 	return result;
 }
 
-#ifdef CONFIG_ACPI_PROCFS
-
 static int acpi_battery_get_alarm(struct acpi_battery *battery)
 {
 	return acpi_smbus_read(battery->sbs->hc, SMBUS_READ_WORD,
@@ -433,8 +431,6 @@ static int acpi_battery_set_alarm(struct acpi_battery *battery)
 	return ret;
 }
 
-#endif
-
 static int acpi_ac_get_present(struct acpi_sbs *sbs)
 {
 	int result;