From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan May Subject: Re: [PATCH 1/2] [PATCH] ACPI: video: Don't call absent methods Date: Tue, 02 Oct 2007 08:22:55 -0500 Message-ID: <4702462F.4070909@ou.edu> References: <20070903122958.20082.6843.stgit@z61m> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rossby.metr.ou.edu ([129.15.192.80]:4107 "EHLO rossby.metr.ou.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbXJBNX0 (ORCPT ); Tue, 2 Oct 2007 09:23:26 -0400 In-Reply-To: <20070903122958.20082.6843.stgit@z61m> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alexey Starikovskiy Cc: Thomas Tuttle , linux-acpi@vger.kernel.org, lenb@kernel.org Hi, What's the status of this patch? AFAICT, it hasn't been applied upstream anywhere. This fixes the problems on my HP dv2125nr with the new BIOS, so I'd really like to see it merged. Thanks, Ryan Alexey Starikovskiy wrote: > Signed-off-by: Ryan May > Signed-off-by: Alexey Starikovskiy > --- > > drivers/acpi/video.c | 18 ++++++++++-------- > 1 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index 3c9bb85..83aa41c 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -409,14 +409,16 @@ acpi_video_device_lcd_query_levels(struct acpi_video_device *device, > static int > acpi_video_device_lcd_set_level(struct acpi_video_device *device, int level) > { > - int status; > + int status = AE_OK; > union acpi_object arg0 = { ACPI_TYPE_INTEGER }; > struct acpi_object_list args = { 1, &arg0 }; > > > arg0.integer.value = level; > - status = acpi_evaluate_object(device->dev->handle, "_BCM", &args, NULL); > - > + if (device->cap._BCM) > + status = acpi_evaluate_object(device->dev->handle, "_BCM", > + &args, NULL); > + device->brightness->curr = level; > printk(KERN_DEBUG "set_level status: %x\n", status); > return status; > } > @@ -425,11 +427,11 @@ static int > acpi_video_device_lcd_get_level_current(struct acpi_video_device *device, > unsigned long *level) > { > - int status; > - > - status = acpi_evaluate_integer(device->dev->handle, "_BQC", NULL, level); > - > - return status; > + if (device->cap._BQC) > + return acpi_evaluate_integer(device->dev->handle, "_BQC", NULL, > + level); > + *level = device->brightness->curr; > + return AE_OK; > } > > static int > > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Ryan May Graduate Research Assistant School of Meteorology University of Oklahoma