From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Dumbre, Saket" <saket.dumbre@intel.com>
Subject: [PATCH v1 02/26] ACPICA: ACPICA: replace ACPI_FREE() with acpi_ut_delete_object_desc()
Date: Wed, 14 Jan 2026 13:17:36 +0100 [thread overview]
Message-ID: <4710853.LvFx2qVVIh@rafael.j.wysocki> (raw)
In-Reply-To: <12822121.O9o76ZdvQC@rafael.j.wysocki>
From: Zilin Guan <zilin@seu.edu.cn>
acpi_ut_create_internal_object() may allocate memory from a slab cache
via kmem_cache_zalloc(), but the code currently frees it with ACPI_FREE(),
which calls kfree().
This mismatch prevents the object from being released properly and may
lead to memory leaks or other issues.
Fix this by replacing ACPI_FREE() with acpi_ut_delete_object_desc(),
which matches the allocation method used for internal objects.
Link: https://github.com/acpica/acpica/commit/a1c55dfea194
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/acpica/nsxfname.c | 2 +-
drivers/acpi/acpica/utobject.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/nsxfname.c b/drivers/acpi/acpica/nsxfname.c
index 1db831545ec8..b6895a48ae68 100644
--- a/drivers/acpi/acpica/nsxfname.c
+++ b/drivers/acpi/acpica/nsxfname.c
@@ -601,7 +601,7 @@ acpi_status acpi_install_method(u8 *buffer)
error_exit:
ACPI_FREE(aml_buffer);
- ACPI_FREE(method_obj);
+ acpi_ut_delete_object_desc(method_obj);
return (status);
}
ACPI_EXPORT_SYMBOL(acpi_install_method)
diff --git a/drivers/acpi/acpica/utobject.c b/drivers/acpi/acpica/utobject.c
index 272e46208263..8362204b57b5 100644
--- a/drivers/acpi/acpica/utobject.c
+++ b/drivers/acpi/acpica/utobject.c
@@ -148,7 +148,7 @@ union acpi_operand_object *acpi_ut_create_package_object(u32 count)
package_elements = ACPI_ALLOCATE_ZEROED(((acpi_size)count +
1) * sizeof(void *));
if (!package_elements) {
- ACPI_FREE(package_desc);
+ acpi_ut_delete_object_desc(package_desc);
return_PTR(NULL);
}
--
2.51.0
next prev parent reply other threads:[~2026-01-14 12:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 12:14 [PATCH v1 00/26] ACPICA: ACPICA 20251212 Rafael J. Wysocki
2026-01-14 12:16 ` [PATCH v1 01/26] ACPICA: Add support for the new ACPI Table: DTPR Rafael J. Wysocki
2026-01-14 12:17 ` Rafael J. Wysocki [this message]
2026-01-14 12:18 ` [PATCH v1 03/26] ACPICA: Add UUID for Microsoft fan extensions Rafael J. Wysocki
2026-01-14 12:19 ` [PATCH v1 04/26] ACPICA: Add UUIDs associated with TPM 2.0 devices Rafael J. Wysocki
2026-01-14 12:20 ` [PATCH v1 05/26] ACPICA: Fix NULL pointer dereference in acpi_ev_address_space_dispatch() Rafael J. Wysocki
2026-03-16 17:46 ` Guenter Roeck
2026-03-17 20:44 ` Rafael J. Wysocki
[not found] ` <SJ0PR11MB500584283698C48BD431BE5D804BA@SJ0PR11MB5005.namprd11.prod.outlook.com>
2026-03-24 4:21 ` Guenter Roeck
2026-01-14 12:21 ` [PATCH v1 06/26] ACPICA: Add KEYP table definition Rafael J. Wysocki
2026-01-14 12:21 ` [PATCH v1 07/26] ACPICA: Add support for the Microsoft display mux _OSI string Rafael J. Wysocki
2026-01-14 12:22 ` [PATCH v1 08/26] ACPICA: iASL: Add definitions for the IOVT table Rafael J. Wysocki
2026-01-14 12:23 ` [PATCH v1 09/26] ACPICA: Add DTPR table support for the ASL compiler Rafael J. Wysocki
2026-01-14 12:24 ` [PATCH v1 10/26] ACPICA: Define DTPR structure related info tables and data template Rafael J. Wysocki
2026-01-14 12:25 ` [PATCH v1 11/26] ACPICA: Abort AML bytecode execution when executing AML_FATAL_OP Rafael J. Wysocki
2026-01-14 12:26 ` [PATCH v1 12/26] ACPICA: ACPI 6.4: PPTT: include all fields in subtable type1 Rafael J. Wysocki
2026-01-14 12:27 ` [PATCH v1 13/26] ACPICA: Fix asltests using the Fatal() opcode Rafael J. Wysocki
2026-01-14 12:29 ` [PATCH v1 14/26] ACPICA: Add GICv5 MADT structures Rafael J. Wysocki
2026-01-14 12:29 ` [PATCH v1 15/26] ACPICA: Add Arm IORT IWB node definitions Rafael J. Wysocki
2026-01-14 12:31 ` [PATCH v1 16/26] ACPICA: actbl2.h: ACPI 6.6: RAS2: Update Parameter Block structure Rafael J. Wysocki
2026-01-14 12:31 ` [PATCH v1 17/26] ACPICA: actbl3.h: ACPI 6.6: SRAT: New flag in Memory Affinity Structure Rafael J. Wysocki
2026-01-14 12:32 ` [PATCH v1 18/26] ACPICA: ACPI 6.6: Add _VDM (Voltage Domain) object Rafael J. Wysocki
2026-01-14 12:33 ` [PATCH v1 19/26] ACPICA: Create auxiliary ACPI_TPR_AUX_SR structure for iASL compiler Rafael J. Wysocki
2026-01-14 12:34 ` [PATCH v1 20/26] ACPICA: Fix Segmentation Fault error related to DTPR Rafael J. Wysocki
2026-01-14 12:35 ` [PATCH v1 21/26] ACPICA: Verify DTPR and TPR Instance buffer pointers Rafael J. Wysocki
2026-01-14 12:36 ` [PATCH v1 22/26] ACPICA: Cleanup comments and DTPR Table handle functions Rafael J. Wysocki
2026-01-14 12:37 ` [PATCH v1 23/26] ACPICA: Align comments in TPRn-related structures Rafael J. Wysocki
2026-01-14 12:38 ` [PATCH v1 24/26] ACPICA: Logfile: Changes for version 20251212 Rafael J. Wysocki
2026-01-14 12:39 ` [PATCH v1 25/26] ACPICA: Replace TPRn Base and Limit registers Rafael J. Wysocki
2026-01-14 12:40 ` [PATCH v1 26/26] ACPICA: Refactor for TPR Base/Limit registers bitmasks Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4710853.LvFx2qVVIh@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saket.dumbre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox