Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Danny Baumann]

Hi,

after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
them generates F6 and F7 key events instead of ACPI events. This used to work
fine in Fedora 7's 2.6.22.9 kernel.

Is there anything I can do to debug this? Writing a value to
/proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
the key mapping.
I would try to debug this myself, if I just knew where to look at; so any
pointers in this direction would be appreciated, too.

Thanks,

Danny

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Chuck Ebbert]

On 10/16/2007 08:49 AM, Danny Baumann wrote:
> Hi,
> 
> after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
> use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
> them generates F6 and F7 key events instead of ACPI events. This used to work
> fine in Fedora 7's 2.6.22.9 kernel.
> 
> Is there anything I can do to debug this? Writing a value to
> /proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
> the key mapping.
> I would try to debug this myself, if I just knew where to look at; so any
> pointers in this direction would be appreciated, too.
> 

Did you look here? I think all you need is keyboard quirks for those keys...

http://people.freedesktop.org/~hughsient/quirk/

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Danny Baumann]

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

Hi,

> > after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
> > use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
> > them generates F6 and F7 key events instead of ACPI events. This used to work
> > fine in Fedora 7's 2.6.22.9 kernel.
> > 
> > Is there anything I can do to debug this? Writing a value to
> > /proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
> > the key mapping.
> > I would try to debug this myself, if I just knew where to look at; so any
> > pointers in this direction would be appreciated, too.
> > 
> 
> Did you look here? I think all you need is keyboard quirks for those keys...
> 
> http://people.freedesktop.org/~hughsient/quirk/

Yeah, I did look there before posting. Unfortunately, my keys don't show
up in dmesg, so I can't add a quirk. Additionally, this used to work
(and actually still works with the F7 kernel 2.6.22.9-91 that's still
installed, which unfortunately has other issues when used under F8), so
I can't really believe that's only the key mapping that is wrong.

It somehow looks wrong to me that all Fn+Fx key presses are recognized
as Fx key presses (e.g. Fn+F6 gives scancode 64) instead of being sent
out as ACPI events. 
A look at the decompiled dsdt seems to suggest that the ACPI table is
correct (well, that makes sense as it worked earlier ;-) ) (on keycode
0x40 send ACPI notify 0x87), but from where inside the kernel is this
evaluated?

Thanks,

Danny

[-- Attachment #2: dsdt.dat --]
[-- Type: application/octet-stream, Size: 31157 bytes --]

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Danny Baumann]

Hi,

> > after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
> > use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
> > them generates F6 and F7 key events instead of ACPI events. This used to work
> > fine in Fedora 7's 2.6.22.9 kernel.
> > 
> > Is there anything I can do to debug this? Writing a value to
> > /proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
> > the key mapping.
> > I would try to debug this myself, if I just knew where to look at; so any
> > pointers in this direction would be appreciated, too.

Ok, I played around with it some more. It seems that on my Laptop the
firmware sends out notifications on Fn+F6/7 press.
Kernel 2.6.23-rc2 worked fine, -rc3 is broken. Reverting ec.c in the
current Fedora kernel to the version in 2.6.23-rc2 makes brightness
control work again. After finding that, I tried the current HEAD version
of ec.c - unfortunately to no avail.
2.6.23-rc3 doesn't show up the (unwanted) key events for Fn+F6/7 though
- this behaviour was introduced in -rc4.

Is it possible to fix the problem with the amount of information
provided? If no, what additional information can I provide?

Thanks,

Danny

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Alexey Starikovskiy]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

Danny Baumann wrote:
> Hi,
> 
>>> after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
>>> use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
>>> them generates F6 and F7 key events instead of ACPI events. This used to work
>>> fine in Fedora 7's 2.6.22.9 kernel.
>>>
>>> Is there anything I can do to debug this? Writing a value to
>>> /proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
>>> the key mapping.
>>> I would try to debug this myself, if I just knew where to look at; so any
>>> pointers in this direction would be appreciated, too.
> 
> Ok, I played around with it some more. It seems that on my Laptop the
> firmware sends out notifications on Fn+F6/7 press.
> Kernel 2.6.23-rc2 worked fine, -rc3 is broken. Reverting ec.c in the
> current Fedora kernel to the version in 2.6.23-rc2 makes brightness
> control work again. After finding that, I tried the current HEAD version
> of ec.c - unfortunately to no avail.
> 2.6.23-rc3 doesn't show up the (unwanted) key events for Fn+F6/7 though
> - this behaviour was introduced in -rc4.
> 
> Is it possible to fix the problem with the amount of information
> provided? If no, what additional information can I provide?
Please check if attached patch changes situation.
Also, please open a new bug entry in bugzilla.kernel.org and put all the data you've collected there.
Please also attach full output from acpidump.

Thanks,
Alex.

[-- Attachment #2: x.patch --]
[-- Type: text/x-diff, Size: 327 bytes --]

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 06b78e5..22bc38c 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -866,6 +866,8 @@ int __init acpi_ec_ecdt_probe(void)
 	acpi_status status;
 	struct acpi_table_ecdt *ecdt_ptr;
 
+return -ENODEV;
+
 	boot_ec = make_acpi_ec();
 	if (!boot_ec)
 		return -ENOMEM;

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Danny Baumann]

Hi,

> > Ok, I played around with it some more. It seems that on my Laptop the
> > firmware sends out notifications on Fn+F6/7 press.
> > Kernel 2.6.23-rc2 worked fine, -rc3 is broken. Reverting ec.c in the
> > current Fedora kernel to the version in 2.6.23-rc2 makes brightness
> > control work again. After finding that, I tried the current HEAD version
> > of ec.c - unfortunately to no avail.
> > 2.6.23-rc3 doesn't show up the (unwanted) key events for Fn+F6/7 though
> > - this behaviour was introduced in -rc4.
> > 
> > Is it possible to fix the problem with the amount of information
> > provided? If no, what additional information can I provide?
> Please check if attached patch changes situation.

Yes, it does. With that patch, everything works as intended.
Gnome-power-manager doesn't seem to work properly with it, but that's a
different story ;-)

> Also, please open a new bug entry in bugzilla.kernel.org and put all the data you've collected there.
> Please also attach full output from acpidump.

Done: http://bugzilla.kernel.org/show_bug.cgi?id=9262 .
Sorry I didn't open it in the first place, but I wasn't sure if it was a
distro kernel problem, a hardware problem or a vanilla kernel problem.

Thanks,

Danny

Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Danny Baumann]

Hi,

> > > Ok, I played around with it some more. It seems that on my Laptop the
> > > firmware sends out notifications on Fn+F6/7 press.
> > > Kernel 2.6.23-rc2 worked fine, -rc3 is broken. Reverting ec.c in the
> > > current Fedora kernel to the version in 2.6.23-rc2 makes brightness
> > > control work again. After finding that, I tried the current HEAD version
> > > of ec.c - unfortunately to no avail.
> > > 2.6.23-rc3 doesn't show up the (unwanted) key events for Fn+F6/7 though
> > > - this behaviour was introduced in -rc4.
> > > 
> > > Is it possible to fix the problem with the amount of information
> > > provided? If no, what additional information can I provide?
> > Please check if attached patch changes situation.
> 
> Yes, it does. With that patch, everything works as intended.
> Gnome-power-manager doesn't seem to work properly with it, but that's a
> different story ;-)

Well, it is a different story. A fix for the gpm problem is at
http://bugzilla.kernel.org/show_bug.cgi?id=9277, but the underlying
problem is a different one that I need some help with:
The root problem is that I get two notifications per brightness hotkey
press. One is for video bus VGA, device LCD; the other one is for bus
GFX0, device LCD. The LCD device on GFX0 is of type 0x400 (internal
flat-panel), the one on VGA is of type 0x110 (external CRT - for
backwards compatibility). So I can somehow understand why Toshiba
duplicated the device in two busses, but the outcome of that is somewhat
inconvenient because it halves the amount of brightness levels I have
available ;-)

Now my question is: Can anything be done inside the kernel against this
kind of problem? I can hardly imagine that Toshiba is the only company
that duplicates the LCD device for backwards compatibility (as this is
even given in the example IDs in table B-3 in the ACPI spec). I thought
about that for some time, but didn't come up with a good idea so far.
Maybe an idea would be to prevent the inclusion of certain ACPI paths
into the namespace by a kernel command line parameter?

Thanks,

Danny