Re: Brightness buttons broken on Toshiba Satellite Proc A100 in kernel 2.6.23 (Fedora8)

[Alexey Starikovskiy <aystarik@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

Danny Baumann wrote:
> Hi,
> 
>>> after upgrading to Fedora 8 which brought kernel 2.6.23 with it I can no longer
>>> use the brightness buttons (Fn+F6/F7) on my above mentioned laptop. Pressing
>>> them generates F6 and F7 key events instead of ACPI events. This used to work
>>> fine in Fedora 7's 2.6.22.9 kernel.
>>>
>>> Is there anything I can do to debug this? Writing a value to
>>> /proc/acpi/video/VGA/LCD/brightness still works fine, so it's just a matter of
>>> the key mapping.
>>> I would try to debug this myself, if I just knew where to look at; so any
>>> pointers in this direction would be appreciated, too.
> 
> Ok, I played around with it some more. It seems that on my Laptop the
> firmware sends out notifications on Fn+F6/7 press.
> Kernel 2.6.23-rc2 worked fine, -rc3 is broken. Reverting ec.c in the
> current Fedora kernel to the version in 2.6.23-rc2 makes brightness
> control work again. After finding that, I tried the current HEAD version
> of ec.c - unfortunately to no avail.
> 2.6.23-rc3 doesn't show up the (unwanted) key events for Fn+F6/7 though
> - this behaviour was introduced in -rc4.
> 
> Is it possible to fix the problem with the amount of information
> provided? If no, what additional information can I provide?
Please check if attached patch changes situation.
Also, please open a new bug entry in bugzilla.kernel.org and put all the data you've collected there.
Please also attach full output from acpidump.

Thanks,
Alex.

[-- Attachment #2: x.patch --]
[-- Type: text/x-diff, Size: 327 bytes --]

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 06b78e5..22bc38c 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -866,6 +866,8 @@ int __init acpi_ec_ecdt_probe(void)
 	acpi_status status;
 	struct acpi_table_ecdt *ecdt_ptr;
 
+return -ENODEV;
+
 	boot_ec = make_acpi_ec();
 	if (!boot_ec)
 		return -ENOMEM;