From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Alexey Starikovskiy <aystarik@gmail.com>,
Roland Dreier <roland@digitalvampire.org>,
Len Brown <len.brown@intel.com>,
linux-acpi@vger.kernel.org,
Rolf Eike Beer <eike-kernel@sf-tec.de>
Subject: Re: ACPI: Always return valid 'status' from acpi_battery_get_property()
Date: Mon, 19 Nov 2007 21:41:08 +0300 [thread overview]
Message-ID: <4741D8C4.7020501@suse.de> (raw)
In-Reply-To: <20071119183606.GE3580@khazad-dum.debian.net>
Henrique de Moraes Holschuh wrote:
> On Mon, 19 Nov 2007, Alexey Starikovskiy wrote:
>> Henrique de Moraes Holschuh wrote:
>>> On Thu, 08 Nov 2007, Alexey Starikovskiy wrote:
>>>>> handle explicitly. There doesn't seem to be any status enum value
>>>>> defined that makes more sense than 'unknown' for a battery at a
>>>>> critical charge level.
>>> Maybe one should be added?
>>>
>> There is already "Critical" field for capacity.
>
> Ah, that's ok, then.
>
>> It seems that the state should be limited to only 3 options:
>> charging, discharging, and not charging.
>
> I'd call "not charging", "idle" instead. After all, discharging IS not
> charging as well...
>
There is power_supply interface, and authors already declared this "not charging"
state, also they already failed to invent "idle".
So, you might send them patch, renaming "not charging" to "idle"...
Regards,
Alex.
prev parent reply other threads:[~2007-11-19 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 23:09 ACPI: Always return valid 'status' from acpi_battery_get_property() Roland Dreier
2007-11-08 8:29 ` Alexey Starikovskiy
2007-11-08 14:42 ` Henrique de Moraes Holschuh
2007-11-19 12:46 ` Alexey Starikovskiy
2007-11-19 18:36 ` Henrique de Moraes Holschuh
2007-11-19 18:41 ` Alexey Starikovskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4741D8C4.7020501@suse.de \
--to=astarikovskiy@suse.de \
--cc=aystarik@gmail.com \
--cc=eike-kernel@sf-tec.de \
--cc=hmh@hmh.eng.br \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=roland@digitalvampire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox