Re: ACPI: Always return valid 'status' from acpi_battery_get_property()

Henrique de Moraes Holschuh
2007-11-19T18:36:13Z

On Mon, 19 Nov 2007, Alexey Starikovskiy wrote:
> Henrique de Moraes Holschuh wrote:
>> On Thu, 08 Nov 2007, Alexey Starikovskiy wrote:
>>>> handle explicitly. There doesn't seem to be any status enum value
>>>> defined that makes more sense than 'unknown' for a battery at a
>>>> critical charge level.
>>
>> Maybe one should be added?
>>
> There is already "Critical" field for capacity.

Ah, that's ok, then.

> It seems that the state should be limited to only 3 options:
> charging, discharging, and not charging.

I'd call "not charging", "idle" instead. After all, discharging IS not
charging as well...

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh