Re: ACPI: Always return valid 'status' from acpi_battery_get_property()

Alexey Starikovskiy
2007-11-19T18:40:53Z

Henrique de Moraes Holschuh wrote:
> On Mon, 19 Nov 2007, Alexey Starikovskiy wrote:
>> Henrique de Moraes Holschuh wrote:
>>> On Thu, 08 Nov 2007, Alexey Starikovskiy wrote:
>>>>> handle explicitly. There doesn't seem to be any status enum value
>>>>> defined that makes more sense than 'unknown' for a battery at a
>>>>> critical charge level.
>>> Maybe one should be added?
>>>
>> There is already "Critical" field for capacity.
>
> Ah, that's ok, then.
>
>> It seems that the state should be limited to only 3 options:
>> charging, discharging, and not charging.
>
> I'd call "not charging", "idle" instead. After all, discharging IS not
> charging as well...
>
There is power_supply interface, and authors already declared this "not charging"
state, also they already failed to invent "idle".
So, you might send them patch, renaming "not charging" to "idle"...

Regards,
Alex.