From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Christoph Hellwig <hch@lst.de>,
"david.e.box@linux.intel.com" <david.e.box@linux.intel.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"rrangel@chromium.org" <rrangel@chromium.org>,
"Shyam-sundar.S-k@amd.com" <Shyam-sundar.S-k@amd.com>,
"Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>,
"prike.liang@amd.com" <prike.liang@amd.com>,
"Derrick, Jonathan" <jonathan.derrick@intel.com>,
"N, Shyjumon" <shyjumon.n@intel.com>
Subject: Re: [PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead
Date: Tue, 1 Jun 2021 10:15:09 -0500 [thread overview]
Message-ID: <474a58bf-dcc9-48a8-c5ce-fb79f2b76a79@amd.com> (raw)
In-Reply-To: <PH0PR11MB4853EBD21B8D89AC8138308F9E3E9@PH0PR11MB4853.namprd11.prod.outlook.com>
>
> I think we need to wait for the confirmation from David. This looks good, but I'd like to see testing. I also wonder how many of the simple suspend quirks we can drop with this.
David, do you think you can get this soonish or are you similarly
blocked like Shyjumon by remote work restrictions? As this is causing
problems for a variety of already shipped OEM systems I would like to
see this series land for 5.14. If you can't get to it in time, I would
prefer that we switch this patch back to how it was conservatively done
in v1 for 5.14 (and redo 2/2 on top of that):
https://lore.kernel.org/linux-nvme/20210527113751.GB17266@lst.de/T/#t
and let you get back to the list when you can to optimize it "later".
>
> Shyjumon and Jon, can you retests the platforms quirked in
> 1fae37accfc5 ("nvme/pci: Add sleep quirk for Samsung and Toshiba drives") with this fix?
>
> Shyjumon>> Yes, I do agree we need to test this also. However the boards where which I had these issues are not in my remote access now (as the work frequency on this boards are less and also due to Covid situation),
> It might take some time for me to test. I will update as soon as I can.
>
next prev parent reply other threads:[~2021-06-01 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 16:02 [PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead Mario Limonciello
2021-05-31 6:46 ` Christoph Hellwig
2021-06-01 5:22 ` N, Shyjumon
2021-06-01 15:15 ` Limonciello, Mario [this message]
2021-06-02 22:49 ` David E. Box
2021-06-01 19:12 ` David E. Box
2021-06-03 7:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474a58bf-dcc9-48a8-c5ce-fb79f2b76a79@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=david.e.box@linux.intel.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=prike.liang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=rrangel@chromium.org \
--cc=sagi@grimberg.me \
--cc=shyjumon.n@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox