From: Alexey Starikovskiy <aystarik@gmail.com>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: "Moore, Robert" <robert.moore@intel.com>,
Linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: Re: [ACPICA] EmbeddedControl region handling bug in PNP0C14
Date: Wed, 12 Dec 2007 21:13:35 +0300 [thread overview]
Message-ID: <476024CF.3000800@gmail.com> (raw)
In-Reply-To: <200712121726.53180.carlos@strangeworlds.co.uk>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
Carlos Corbacho wrote:
> Alexey,
>
> Is the code in EC0 interfering then with the EC access code in AMW0? (See
> lines 962 onwards for the AMW0 EmbeddedControl region bits)?
>
> Because AFAICT, the EC0 code is fine (my 5020 has the same AML for EC0 and
> doesn't have any problem, and the user didn't report any other EC problems -
> we only see this problem when we try to use the EmbeddedControl region in
> AMW0).
>
> -Carlos
>
>
Please check if making AMW0' RAM an alias to EC0 one helps... See
attachment.
[-- Attachment #2: a.diff --]
[-- Type: text/x-patch, Size: 3438 bytes --]
--- 5040.dsl 2007-12-12 21:03:04.000000000 +0300
+++ 5040a.dsl 2007-12-12 21:02:54.000000000 +0300
@@ -721,7 +721,7 @@
Device (AMW0)
{
- Name (_HID, "*pnp0c14")
+ Name (_HID, "PNP0C14")
Name (_UID, 0x00)
Name (WLMP, 0x00)
Name (B0ED, Buffer (0x04)
@@ -959,7 +959,8 @@
CreateDWordField (CBE0, 0x00, BER4)
CreateWordField (CBE0, 0x00, BUF0)
CreateWordField (CBE0, 0x02, BER2)
- OperationRegion (RAM, EmbeddedControl, 0x00, 0xFF)
+// OperationRegion (RAM, EmbeddedControl, 0x00, 0xFF)
+ Alias(\_SB.PCI0.LPC0.EC0.RAM, RAM)
Field (RAM, ByteAcc, Lock, Preserve)
{
CMD0, 8,
@@ -3614,7 +3615,7 @@
}
OperationRegion (RAM, EmbeddedControl, 0x00, 0xFF)
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x0A),
, 1,
@@ -3637,7 +3638,7 @@
BL2W, 1
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x01),
TIID, 8,
@@ -3664,19 +3665,19 @@
THS7, 8
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x92),
KTAF, 8
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x92),
THSL, 4
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0xD0),
TSP0, 8,
@@ -3985,7 +3986,7 @@
Notify (\_TZ.TZS1, 0x80)
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x02),
NBID, 8,
@@ -3997,14 +3998,14 @@
NB1A, 1
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0x88),
NB0S, 8,
NB1S, 8
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0xE0),
BSRC, 16,
@@ -4018,7 +4019,7 @@
BSBS, 8
}
- Field (RAM, AnyAcc, Lock, Preserve)
+ Field (RAM, ByteAcc, Lock, Preserve)
{
Offset (0xE0),
BSDC, 16,
next prev parent reply other threads:[~2007-12-12 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 3:50 [ACPICA] EmbeddedControl region handling bug in PNP0C14 Carlos Corbacho
2007-11-28 18:08 ` Moore, Robert
2007-12-12 14:10 ` Carlos Corbacho
2007-12-12 15:44 ` Alexey Starikovskiy
2007-12-12 17:26 ` Carlos Corbacho
2007-12-12 18:13 ` Alexey Starikovskiy [this message]
2007-12-16 3:42 ` Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476024CF.3000800@gmail.com \
--to=aystarik@gmail.com \
--cc=Linux-acpi@vger.kernel.org \
--cc=astarikovskiy@suse.de \
--cc=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox