Re: [PATCH 2/2] gpio / ACPI: Use pin index and bit length

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Wednesday, September 24, 2014 01:25:03 PM Linus Walleij wrote:
> On Tue, Sep 23, 2014 at 12:27 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Tue, Sep 23, 2014 at 10:35:54AM +0800, Lv Zheng wrote:
> >> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> >>
> >> Fix code when the operation region callback is for an gpio, which
> >> is not at index 0 and for partial pins in a GPIO definition.
> >> For example:
> >> Name (GMOD, ResourceTemplate ()
> >> {
> >>       //3 Outputs that define the Power mode of the device
> >>       GpioIo (Exclusive, PullDown, , , , "\\_SB.GPI2") {10, 11, 12}
> >>       })
> >> }
> >>
> >> If opregion callback calls is for:
> >> - Set pin 10, then address = 0 and bit length = 1
> >> - Set pin 11, then address = 1 and bit length = 1
> >> - Set for both pin 11 and pin 12, then address = 1, bit length = 2
> >>
> >> This change requires updated ACPICA gpio operation handler code to
> >> send the pin index and bit length.
> >>
> >> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> >> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Adding the GPIO maintainers since we need their ACK to get this merged
> > through ACPI tree.
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> When it comes to ACPI GPIO stuff I basically trust Rafael, Mika
> and Darren to do the right thing. I'm trying to learn a bit as we go.

Thanks!  We're doing our best. :-)

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.