From: Randy Dunlap <randy.dunlap@oracle.com>
To: Len Brown <lenb@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, sujith.thomas@intel.com
Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver
Date: Thu, 17 Jan 2008 12:51:39 -0800 [thread overview]
Message-ID: <478FBFDB.4000600@oracle.com> (raw)
In-Reply-To: <200801171451.18613.lenb@kernel.org>
Len Brown wrote:
>>> +static int
>>> +memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev,
>>> + unsigned long *max_state)
>> Don't put 'static int' (return type etc.) on a line by itself.
>> That format is not wanted in Linux. (many places here)
>
> if checkpatch.pl and Lindent are happey (which they are not, totally)
> then I'm satisifed witht he Linux style of the code.
>
> Randy, if you feel strongly about this this style nit,
> then change Lindent to implement it -- nagging
> developers about trivia is a waste of everybody's time.
>
> thanks,
> -Len
http://marc.info/?l=linux-kernel&m=105451996829576&w=2
Thanks.
--
~Randy
next prev parent reply other threads:[~2008-01-17 20:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 7:51 [PATCH 9/10] introduce intel_menlow platform specific driver Zhang Rui
2008-01-17 8:18 ` Sam Ravnborg
2008-01-17 17:20 ` Randy Dunlap
2008-01-17 19:51 ` Len Brown
2008-01-17 20:51 ` Randy Dunlap [this message]
2008-01-18 3:32 ` Zhang Rui
2008-01-18 3:55 ` Li Zefan
2008-01-21 5:26 ` Thomas, Sujith
2008-01-21 5:45 ` Li Zefan
2008-01-25 3:45 ` Zhang Rui
2008-01-21 9:53 ` Christoph Hellwig
2008-01-21 14:19 ` Thomas, Sujith
2008-01-23 15:58 ` Jan Engelhardt
2008-01-24 21:39 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478FBFDB.4000600@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rui.zhang@intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).