Re: [PATCH 2/2] asus-laptop add kill switch support

[Fabien Crespel <fabien-czgx1wgAc3rR7s880joybQ@public.gmane.org>]

Thomas Renninger wrote :
> Hi,
>
> On Thu, 2008-02-07 at 19:06 +0100, Fabien Crespel wrote:
>> Basically:
>> - there is now a killswitch file in /sys/devices/platform/asus-laptop/ to report 
>> the KS status (read from HWRS)
>>     
> Not sure, but:
> Shouldn't this one register against a general kill-switch interface?
> E.g. include/linux/rfkill.h
> instead of starting an own interface...
>
>    Thomas
>   
Hello,

after looking at the rfkill interface, it doesn't seem to have the same 
purpose here : rfkill seems to be here to allow toggling radio frequency 
of devices in response to a key or another *software* generated event, 
while the "killswitch" sysfs file in my patch simply provides a way to 
read whether the *hardware* kill switch is ON (and not write or toggle 
anything, since it's completely out of software control).

My intention when adding this interface was to allow userspace tools 
like Lapsus to know when WLAN/Bluetooth are completely *disabled* (and 
not simply "off"). I don't think the rfkill interface provides a way to 
know that, or I missed it..? if it doesn't, wouldn't it be interesting 
to add it?

The rfkill interface seems interesting to support the Fn+F2 key though 
(WLAN/Bluetooth toggle), since currently it doesn't work on all models.

- Fabien.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/